public inbox for [email protected]
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], [email protected], [email protected],
	[email protected], [email protected]
Subject: Re: [PATCH 3/9] iomap: treat a write through cache the same as FUA
Date: Fri, 21 Jul 2023 09:47:44 -0700	[thread overview]
Message-ID: <20230721164744.GW11352@frogsfrogsfrogs> (raw)
In-Reply-To: <[email protected]>

On Fri, Jul 21, 2023 at 10:27:16AM -0600, Jens Axboe wrote:
> On 7/21/23 10:25?AM, Darrick J. Wong wrote:
> >> @@ -560,12 +562,15 @@ __iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter,
> >>  
> >>  		       /*
> >>  			* For datasync only writes, we optimistically try
> >> -			* using FUA for this IO.  Any non-FUA write that
> >> -			* occurs will clear this flag, hence we know before
> >> -			* completion whether a cache flush is necessary.
> >> +			* using WRITE_THROUGH for this IO. Stable writes are
> > 
> > "...using WRITE_THROUGH for this IO.  This flag requires either FUA
> > writes through the device's write cache, or a normal write..."
> > 
> >> @@ -627,10 +632,10 @@ __iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter,
> >>  		iomap_dio_set_error(dio, ret);
> >>  
> >>  	/*
> >> -	 * If all the writes we issued were FUA, we don't need to flush the
> >> +	 * If all the writes we issued were stable, we don't need to flush the
> > 
> > "If all the writes we issued were already written through to the media,
> > we don't need to flush..."
> > 
> > With those fixes,
> > Reviewed-by: Darrick J. Wong <[email protected]>
> 
> If you're queueing up this series, could you just make those two edits
> while applying? I don't want to spam resend with just a comment change,
> at least if I can avoid it...

How about pushing the updated branch, tagging it with the cover letter
as the message, and sending me a pull request?  Linus has been very
receptive to preserving cover letters this way.

--D

> -- 
> Jens Axboe
> 

  reply	other threads:[~2023-07-21 16:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21 16:16 [PATCHSET v5 0/9] Improve async iomap DIO performance Jens Axboe
2023-07-21 16:16 ` [PATCH 1/9] iomap: cleanup up iomap_dio_bio_end_io() Jens Axboe
2023-07-21 16:16 ` [PATCH 2/9] iomap: add IOMAP_DIO_INLINE_COMP Jens Axboe
2023-07-21 16:16 ` [PATCH 3/9] iomap: treat a write through cache the same as FUA Jens Axboe
2023-07-21 16:25   ` Darrick J. Wong
2023-07-21 16:27     ` Jens Axboe
2023-07-21 16:47       ` Darrick J. Wong [this message]
2023-07-21 16:52         ` Jens Axboe
2023-07-21 16:16 ` [PATCH 4/9] iomap: completed polled IO inline Jens Axboe
2023-07-21 16:16 ` [PATCH 5/9] iomap: only set iocb->private for polled bio Jens Axboe
2023-07-21 16:16 ` [PATCH 6/9] fs: add IOCB flags related to passing back dio completions Jens Axboe
2023-07-21 16:28   ` Darrick J. Wong
2023-07-21 16:30     ` Jens Axboe
2023-07-21 16:43       ` Jens Axboe
2023-07-21 16:16 ` [PATCH 7/9] io_uring/rw: add write support for IOCB_DIO_CALLER_COMP Jens Axboe
2023-07-21 16:29   ` Darrick J. Wong
2023-07-21 16:16 ` [PATCH 8/9] iomap: support IOCB_DIO_CALLER_COMP Jens Axboe
2023-07-21 16:16 ` [PATCH 9/9] iomap: use an unsigned type for IOMAP_DIO_* defines Jens Axboe
2023-07-21 16:29   ` Darrick J. Wong
2023-07-24 16:36   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230721164744.GW11352@frogsfrogsfrogs \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox