From: kernel test robot <[email protected]>
To: Xiaobing Li <[email protected]>,
[email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected], [email protected],
[email protected], [email protected], [email protected],
[email protected]
Cc: [email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected], [email protected],
[email protected], [email protected],
[email protected], Xiaobing Li <[email protected]>
Subject: Re: [PATCH 1/3] SCHEDULER: Add an interface for counting real utilization.
Date: Thu, 28 Sep 2023 15:52:33 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
Hi Xiaobing,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tip/sched/core]
[also build test WARNING on linus/master v6.6-rc3 next-20230928]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Xiaobing-Li/SCHEDULER-Add-an-interface-for-counting-real-utilization/20230928-103219
base: tip/sched/core
patch link: https://lore.kernel.org/r/20230928022228.15770-2-xiaobing.li%40samsung.com
patch subject: [PATCH 1/3] SCHEDULER: Add an interface for counting real utilization.
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230928/[email protected]/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230928/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
In file included from kernel/sched/build_policy.c:52:
>> kernel/sched/cputime.c:482:6: warning: no previous prototype for 'get_sqthread_util' [-Wmissing-prototypes]
482 | void get_sqthread_util(struct task_struct *p)
| ^~~~~~~~~~~~~~~~~
kernel/sched/cputime.c: In function 'get_sqthread_util':
kernel/sched/cputime.c:484:56: error: 'struct kernel_cpustat' has no member named 'sq_util'
484 | struct task_struct **sqstat = kcpustat_this_cpu->sq_util;
| ^~
kernel/sched/cputime.c:486:29: error: 'MAX_SQ_NUM' undeclared (first use in this function)
486 | for (int i = 0; i < MAX_SQ_NUM; i++) {
| ^~~~~~~~~~
kernel/sched/cputime.c:486:29: note: each undeclared identifier is reported only once for each function it appears in
kernel/sched/cputime.c:495:31: error: 'struct kernel_cpustat' has no member named 'flag'
495 | if (!kcpustat_this_cpu->flag) {
| ^~
kernel/sched/cputime.c:497:42: error: 'struct kernel_cpustat' has no member named 'sq_util'
497 | kcpustat_this_cpu->sq_util[j] = NULL;
| ^~
kernel/sched/cputime.c:498:34: error: 'struct kernel_cpustat' has no member named 'flag'
498 | kcpustat_this_cpu->flag = true;
| ^~
vim +/get_sqthread_util +482 kernel/sched/cputime.c
481
> 482 void get_sqthread_util(struct task_struct *p)
483 {
484 struct task_struct **sqstat = kcpustat_this_cpu->sq_util;
485
486 for (int i = 0; i < MAX_SQ_NUM; i++) {
487 if (sqstat[i] && (task_cpu(sqstat[i]) != task_cpu(p)
488 || sqstat[i]->__state == TASK_DEAD))
489 sqstat[i] = NULL;
490 }
491
492 if (strncmp(p->comm, "iou-sqp", 7))
493 return;
494
495 if (!kcpustat_this_cpu->flag) {
496 for (int j = 0; j < MAX_SQ_NUM; j++)
497 kcpustat_this_cpu->sq_util[j] = NULL;
498 kcpustat_this_cpu->flag = true;
499 }
500 int index = MAX_SQ_NUM;
501 bool flag = true;
502
503 for (int i = 0; i < MAX_SQ_NUM; i++) {
504 if (sqstat[i] == p)
505 flag = false;
506 if (!sqstat[i] || task_cpu(sqstat[i]) != task_cpu(p)) {
507 sqstat[i] = NULL;
508 if (i < index)
509 index = i;
510 }
511 }
512 if (flag && index < MAX_SQ_NUM)
513 sqstat[index] = p;
514 }
515
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-09-28 7:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230928023004epcas5p4a6dac4cda9c867f3673690521a8c18b6@epcas5p4.samsung.com>
2023-09-28 2:22 ` [PATCH 0/3] Sq thread real utilization statistics Xiaobing Li
[not found] ` <CGME20230928023007epcas5p276b6e029a67001a6ed8ab28c05b2be9c@epcas5p2.samsung.com>
2023-09-28 2:22 ` [PATCH 1/3] SCHEDULER: Add an interface for counting real utilization Xiaobing Li
2023-09-28 7:52 ` kernel test robot [this message]
2023-09-28 8:02 ` Peter Zijlstra
2023-09-29 0:31 ` Thomas Gleixner
[not found] ` <CGME20230928023011epcas5p32668b193b447f1cd6bf78035f4894c42@epcas5p3.samsung.com>
2023-09-28 2:22 ` [PATCH 2/3] PROC FILESYSTEM: Add real utilization data of sq thread Xiaobing Li
[not found] ` <CGME20230928023015epcas5p273b3eaebf3759790c278b03c7f0341c8@epcas5p2.samsung.com>
2023-09-28 2:22 ` [PATCH 3/3] IO_URING: Statistics of the true utilization of sq threads Xiaobing Li
2023-09-28 8:01 ` Peter Zijlstra
2023-09-28 8:23 ` Jens Axboe
2023-09-28 8:37 ` Matthew Wilcox
2023-09-28 8:41 ` Jens Axboe
2023-09-28 18:33 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox