From: kernel test robot <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Cc: [email protected], [email protected],
Jens Axboe <[email protected]>,
[email protected], [email protected],
[email protected], [email protected]
Subject: Re: [PATCH 1/3] io_uring: split out cmd api into a separate header
Date: Fri, 24 Nov 2023 23:23:20 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <547e56560b97cd66f00bfc5b53db24f2fa1a8852.1700668641.git.asml.silence@gmail.com>
Hi Pavel,
kernel test robot noticed the following build errors:
[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on linus/master v6.7-rc2 next-20231124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Pavel-Begunkov/io_uring-split-out-cmd-api-into-a-separate-header/20231123-001742
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link: https://lore.kernel.org/r/547e56560b97cd66f00bfc5b53db24f2fa1a8852.1700668641.git.asml.silence%40gmail.com
patch subject: [PATCH 1/3] io_uring: split out cmd api into a separate header
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20231124/[email protected]/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231124/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
>> security/selinux/hooks.c:6940:28: error: incomplete definition of type 'struct io_uring_cmd'
struct file *file = ioucmd->file;
~~~~~~^
include/linux/fs.h:1913:8: note: forward declaration of 'struct io_uring_cmd'
struct io_uring_cmd;
^
1 error generated.
vim +6940 security/selinux/hooks.c
f4d653dcaa4e40 Paul Moore 2022-08-10 6929
f4d653dcaa4e40 Paul Moore 2022-08-10 6930 /**
f4d653dcaa4e40 Paul Moore 2022-08-10 6931 * selinux_uring_cmd - check if IORING_OP_URING_CMD is allowed
f4d653dcaa4e40 Paul Moore 2022-08-10 6932 * @ioucmd: the io_uring command structure
f4d653dcaa4e40 Paul Moore 2022-08-10 6933 *
f4d653dcaa4e40 Paul Moore 2022-08-10 6934 * Check to see if the current domain is allowed to execute an
f4d653dcaa4e40 Paul Moore 2022-08-10 6935 * IORING_OP_URING_CMD against the device/file specified in @ioucmd.
f4d653dcaa4e40 Paul Moore 2022-08-10 6936 *
f4d653dcaa4e40 Paul Moore 2022-08-10 6937 */
f4d653dcaa4e40 Paul Moore 2022-08-10 6938 static int selinux_uring_cmd(struct io_uring_cmd *ioucmd)
f4d653dcaa4e40 Paul Moore 2022-08-10 6939 {
f4d653dcaa4e40 Paul Moore 2022-08-10 @6940 struct file *file = ioucmd->file;
f4d653dcaa4e40 Paul Moore 2022-08-10 6941 struct inode *inode = file_inode(file);
f4d653dcaa4e40 Paul Moore 2022-08-10 6942 struct inode_security_struct *isec = selinux_inode(inode);
f4d653dcaa4e40 Paul Moore 2022-08-10 6943 struct common_audit_data ad;
f4d653dcaa4e40 Paul Moore 2022-08-10 6944
f4d653dcaa4e40 Paul Moore 2022-08-10 6945 ad.type = LSM_AUDIT_DATA_FILE;
f4d653dcaa4e40 Paul Moore 2022-08-10 6946 ad.u.file = file;
f4d653dcaa4e40 Paul Moore 2022-08-10 6947
e67b79850fcc4e Stephen Smalley 2023-03-09 6948 return avc_has_perm(current_sid(), isec->sid,
f4d653dcaa4e40 Paul Moore 2022-08-10 6949 SECCLASS_IO_URING, IO_URING__CMD, &ad);
f4d653dcaa4e40 Paul Moore 2022-08-10 6950 }
740b03414b20e7 Paul Moore 2021-02-23 6951 #endif /* CONFIG_IO_URING */
740b03414b20e7 Paul Moore 2021-02-23 6952
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-11-24 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 16:01 [PATCH 0/3] clean up io_uring cmd header structure Pavel Begunkov
2023-11-22 16:01 ` [PATCH 1/3] io_uring: split out cmd api into a separate header Pavel Begunkov
2023-11-23 2:40 ` Ming Lei
2023-11-23 11:16 ` Pavel Begunkov
2023-11-24 2:05 ` Ming Lei
2023-11-24 13:20 ` kernel test robot
2023-11-24 15:23 ` kernel test robot [this message]
2023-11-22 16:01 ` [PATCH 2/3] io_uring/cmd: inline io_uring_cmd_do_in_task_lazy Pavel Begunkov
2023-11-22 16:01 ` [PATCH 3/3] io_uring/cmd: inline io_uring_cmd_get_task Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox