public inbox for [email protected]
 help / color / mirror / Atom feed
From: Christian Brauner <[email protected]>
To: Jens Axboe <[email protected]>
Cc: io-uring <[email protected]>,
	Pavel Begunkov <[email protected]>
Subject: Re: [PATCH] io_uring/openclose: add support for IORING_OP_FIXED_FD_INSTALL
Date: Fri, 8 Dec 2023 23:08:04 +0100	[thread overview]
Message-ID: <20231208-rausnehmen-intrigieren-0a3de99f22e8@brauner> (raw)
In-Reply-To: <[email protected]>

> > Meh, new opcode would suck. Don't deviate from the standard apis then.
> 
> Not a new opcode, it'd just be a flag for that opcode. We default to
> O_CLOEXEC is nothing is given, and you can do:
> 
> io_uring_prep_fixed_fd_install(sqe, fixed_index, IORING_FIXED_FD_NO_CLOEXEC);
> 
> to simply set that flag to turn it off. Only reason I bring it up as a
> bit annoying is that it'd be cleaner to have it be part of the O_*
> namespace as O_NOCLOEXEC, but it's not a huge deal.
> 
> It retains the part you cared about, which is making O_CLOEXEC the
> default, but retains the option of turning it off rather than needing to
> do an fcntl() to retrieve flags, mask it, then another fcntl().

Ok, sounds good.

      reply	other threads:[~2023-12-08 22:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-08  3:11 [PATCH] io_uring/openclose: add support for IORING_OP_FIXED_FD_INSTALL Jens Axboe
2023-12-08  3:13 ` Jens Axboe
2023-12-08 21:14 ` Christian Brauner
2023-12-08 21:49   ` Jens Axboe
2023-12-08 21:56     ` Christian Brauner
2023-12-08 22:06       ` Jens Axboe
2023-12-08 22:08         ` Christian Brauner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231208-rausnehmen-intrigieren-0a3de99f22e8@brauner \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox