From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5294618E15; Tue, 19 Dec 2023 12:00:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=gnuweeb.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gnuweeb.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gnuweeb.org header.i=@gnuweeb.org header.b="pD+ybuFa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1702986877; bh=6y7QcMNqdf/KzxtBMRwl6JBNpcXBvZAGKI4OW6AiOww=; h=From:To:Cc:Subject:Date; b=pD+ybuFaLCHla+Xm8wAgMyEK5gI/x5SO96VdrCCQ/4lOTx/nw8I/t1HxZ5pk9CXuT YVz1SR6nR9AImqcJWVILoePxd3wsaW36909Cgh8fkpmMs6dqa75fHKccbXrsASRCoU 5MV6dbpPUQ0FUOrKwFD0bBCYjM/14C8w2wQlYJH3vQDkJxK5V7Kp5VSUHz3iQfQv/P EsRS9w18Xb/Ype+DNYcctNnE+lkPWHSDqF57feR3Kul4GcGFD6iZ2BvHUPbDrF6aJL zu6eZR1heA06QblvA3ElBTaHvI9ZbtGx5Atn9zGIF3BMpURulPF3MVlcNy37I6x+AZ z5HG1iLqpA4cw== Received: from localhost.localdomain (unknown [182.253.230.19]) by gnuweeb.org (Postfix) with ESMTPSA id 1D1C724C190; Tue, 19 Dec 2023 18:54:33 +0700 (WIB) From: Ammar Faizi To: Jens Axboe Cc: Ammar Faizi , Alviro Iskandar Setiawan , Michael William Jonathan , io-uring Mailing List , Linux Kernel Mailing List , GNU/Weeb Mailing List Subject: [PATCH liburing v1 0/2] Makefile and t/no-mmap-inval updates Date: Tue, 19 Dec 2023 18:54:21 +0700 Message-Id: <20231219115423.222134-1-ammarfaizi2@gnuweeb.org> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Jens, There are two patches in this series: 1. Makefile: Remove the `partcheck` target. Remove the `partcheck` target because it has remained unused for nearly four years, and the associated TODO comment has not been actioned since its introduction in commit: b57dbc2d308a849 ("configure/Makefile: introduce libdevdir defaults to $(libdir)") 2. t/no-mmap-inval: Replace `valloc()` with `t_posix_memalign()`. Address the limitations of valloc(). This function, which is primarily used for allocating page-aligned memory, is not only absent in some systems but is also marked as obsolete according to the `man 3 valloc`. Replace valloc() with t_posix_memalign() to fix the following build error: no-mmap-inval.c:28:56: warning: call to undeclared function 'valloc'; ISO C99 and \ later do not support implicit function declarations [-Wimplicit-function-declaration] p.cq_off.user_addr = (unsigned long long) (uintptr_t) valloc(8192); ^ 1 warning generated. ld.lld: error: undefined symbol: valloc >>> referenced by no-mmap-inval.c:28 >>> /tmp/no-mmap-inval-ea16a2.o:(main) >>> did you mean: calloc >>> defined in: /system/lib64/libc.so clang-15: error: linker command failed with exit code 1 (use -v to see invocation) make[1]: *** [Makefile:239: no-mmap-inval.t] Error 1 Signed-off-by: Ammar Faizi --- Ammar Faizi (2): Makefile: Remove the `partcheck` target t/no-mmap-inval: Replace `valloc()` with `t_posix_memalign()` Makefile | 3 --- test/no-mmap-inval.c | 4 +++- 2 files changed, 3 insertions(+), 4 deletions(-) base-commit: bbd27495d302856b1f28d64b346d3ad80be3a86f -- Ammar Faizi