From: Ammar Faizi <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Ammar Faizi <[email protected]>,
Alviro Iskandar Setiawan <[email protected]>,
Michael William Jonathan <[email protected]>,
io-uring Mailing List <[email protected]>,
Linux Kernel Mailing List <[email protected]>,
GNU/Weeb Mailing List <[email protected]>
Subject: [PATCH liburing v1 2/2] t/no-mmap-inval: Replace `valloc()` with `t_posix_memalign()`
Date: Tue, 19 Dec 2023 18:54:23 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
Address the limitations of valloc(). This function, which is primarily
used for allocating page-aligned memory, is not only absent in some
systems but is also marked as obsolete according to the `man 3 valloc`.
Replace valloc() with t_posix_memalign() to fix the following build
error:
no-mmap-inval.c:28:56: warning: call to undeclared function 'valloc'; ISO C99 and \
later do not support implicit function declarations [-Wimplicit-function-declaration]
p.cq_off.user_addr = (unsigned long long) (uintptr_t) valloc(8192);
^
1 warning generated.
ld.lld: error: undefined symbol: valloc
>>> referenced by no-mmap-inval.c:28
>>> /tmp/no-mmap-inval-ea16a2.o:(main)
>>> did you mean: calloc
>>> defined in: /system/lib64/libc.so
clang-15: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [Makefile:239: no-mmap-inval.t] Error 1
Signed-off-by: Ammar Faizi <[email protected]>
---
test/no-mmap-inval.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/test/no-mmap-inval.c b/test/no-mmap-inval.c
index 9571fee0035ac5ce..244d4eb645115a44 100644
--- a/test/no-mmap-inval.c
+++ b/test/no-mmap-inval.c
@@ -20,12 +20,14 @@ int main(int argc, char *argv[])
.flags = IORING_SETUP_NO_MMAP,
};
struct io_uring ring;
+ void *addr;
int ret;
if (argc > 1)
return T_EXIT_SKIP;
- p.cq_off.user_addr = (unsigned long long) (uintptr_t) valloc(8192);
+ t_posix_memalign(&addr, sysconf(_SC_PAGESIZE), 8192);
+ p.cq_off.user_addr = (unsigned long long) (uintptr_t) addr;
ret = io_uring_queue_init_params(2, &ring, &p);
if (ret == -EINVAL) {
--
Ammar Faizi
next prev parent reply other threads:[~2023-12-19 11:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 11:54 [PATCH liburing v1 0/2] Makefile and t/no-mmap-inval updates Ammar Faizi
2023-12-19 11:54 ` [PATCH liburing v1 1/2] Makefile: Remove the `partcheck` target Ammar Faizi
2023-12-19 11:54 ` Ammar Faizi [this message]
2023-12-19 12:05 ` [PATCH liburing v1 2/2] t/no-mmap-inval: Replace `valloc()` with `t_posix_memalign()` Alviro Iskandar Setiawan
2023-12-19 15:22 ` [PATCH liburing v1 0/2] Makefile and t/no-mmap-inval updates Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox