From: Zorro Lang <[email protected]>
To: "Darrick J. Wong" <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH 1/3] fsstress: check io_uring_queue_init errno properly
Date: Thu, 7 Mar 2024 03:34:04 +0800 [thread overview]
Message-ID: <20240306193404.oc34ks4p5ez37s57@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com> (raw)
In-Reply-To: <20240306155357.GA6188@frogsfrogsfrogs>
On Wed, Mar 06, 2024 at 07:53:57AM -0800, Darrick J. Wong wrote:
> On Wed, Mar 06, 2024 at 05:19:33PM +0800, Zorro Lang wrote:
> > As the manual of io_uring_queue_init says "io_uring_queue_init(3)
> > returns 0 on success and -errno on failure". We should check if the
> > return value is -ENOSYS, not the errno.
>
> /me checks liburing source code and sees that the library returns a
> negative error code without touching errno (the semi global error code
> variable) at all. That's an unfortunate quirk of the manpage, but this
> code here is correct...
Yeah, that confuse me too, especially some io_uring functions set errno,
some return -errno ...
>
> > Fixes: d15b1721f284 ("ltp/fsstress: don't fail on io_uring ENOSYS")
> > Signed-off-by: Zorro Lang <[email protected]>
> > ---
> > ltp/fsstress.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/ltp/fsstress.c b/ltp/fsstress.c
> > index 63c75767..482395c4 100644
> > --- a/ltp/fsstress.c
> > +++ b/ltp/fsstress.c
> > @@ -763,8 +763,8 @@ int main(int argc, char **argv)
> > #ifdef URING
> > have_io_uring = true;
> > /* If ENOSYS, just ignore uring, other errors are fatal. */
> > - if (io_uring_queue_init(URING_ENTRIES, &ring, 0)) {
> > - if (errno == ENOSYS) {
> > + if ((c = io_uring_queue_init(URING_ENTRIES, &ring, 0)) != 0) {
> > + if (c == -ENOSYS) {
> > have_io_uring = false;
> > } else {
> > fprintf(stderr, "io_uring_queue_init failed\n");
>
> But why not:
>
> c = io_uring_queue_init(...);
> switch (c) {
> case 0:
> have_io_uring = true;
> break;
> case -ENOSYS:
> have_io_uring = false;
> break;
> default:
> fprintf(stderr, "io_uring_queue_init failed\n");
> break;
> }
>
> Especially since you add another case in the next patch?
Sure, that looks more clearly, I'll change this part. Thanks!
>
> I'll leave the style nits up to you though:
> Reviewed-by: Darrick J. Wong <[email protected]>
>
> --D
>
>
> --D
>
> > --
> > 2.43.0
> >
> >
>
next prev parent reply other threads:[~2024-03-06 19:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 9:19 [PATCH 0/3] fstests: fix io_uring testing Zorro Lang
2024-03-06 9:19 ` [PATCH 1/3] fsstress: check io_uring_queue_init errno properly Zorro Lang
2024-03-06 15:53 ` Darrick J. Wong
2024-03-06 19:34 ` Zorro Lang [this message]
2024-03-06 15:56 ` Jeff Moyer
2024-03-06 9:19 ` [PATCH 2/3] fsstress: bypass io_uring testing if io_uring_queue_init returns EPERM Zorro Lang
2024-03-06 15:55 ` Darrick J. Wong
2024-03-06 19:36 ` Zorro Lang
2024-03-06 15:57 ` Jeff Moyer
2024-03-06 19:38 ` Zorro Lang
2024-03-06 9:19 ` [PATCH 3/3] common/rc: force enable io_uring in _require_io_uring Zorro Lang
2024-03-06 15:43 ` Darrick J. Wong
2024-03-06 15:59 ` Jeff Moyer
2024-03-06 19:56 ` Zorro Lang
2024-03-06 19:51 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306193404.oc34ks4p5ez37s57@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox