From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E579A21085F for ; Mon, 25 Mar 2024 02:37:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711334252; cv=none; b=oMnmlc6tiG+53n8PA/4us4MwxD0FCKWm/+9R8zu+6GiQm/rCYDfY61tIHhxbUpdD8Ng9FMz0vDqqw9gqrsRcQZRrz+7QP4tSJpsg0OyfVILIwuAU5QUvECo5Fzo8OlIHobhKw/FZRGSnBh4i1VUM2LLJ3iUoz1Jd8QlQYcA1WPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711334252; c=relaxed/simple; bh=CUhu4fcoHxot+obl+L/lIB2mjnnCYJgKXU5JhtEOyz4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ad7kJKBcXn4QdR4ijfcLoN000P4n/CNxk6mPmYLpu/jl1zHv5un8mD+w4UjheeookQx0idjU78/vvmPklO8h0zyu1Dd5pwiho1+BuwCusUor4R6Fcfg0qaD1ou+pr1+XpV1ICbHP8Kg0K7f0LVf/wq1mRl35xufE/Tg0QixsEsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=layalina.io; spf=pass smtp.mailfrom=layalina.io; dkim=pass (2048-bit key) header.d=layalina-io.20230601.gappssmtp.com header.i=@layalina-io.20230601.gappssmtp.com header.b=2Jz0jA0+; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=layalina.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=layalina.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=layalina-io.20230601.gappssmtp.com header.i=@layalina-io.20230601.gappssmtp.com header.b="2Jz0jA0+" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-341cf77b86bso139277f8f.2 for ; Sun, 24 Mar 2024 19:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20230601.gappssmtp.com; s=20230601; t=1711334248; x=1711939048; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=OmGpqFfHYwDGnVVZ3jzAGoFdzesxBNnjTqhjXueHYVY=; b=2Jz0jA0+gY0hPyGeZZI/SS29mN7sv/9v/HpfhXgWqXrc9xBobiybpkROmw1LG7IR6n SD07nDUS2Nu1c8sz/xv+BGN8p9T9xHQLUZd5p0WVk8MOb6hJvau5X8rd2I0T5BenOE+U yedEE1zb2ySqyWfEPZlOfoAyZV5Wh3/MoOLmRNnfVb6lZpD3UMeIRj6JY3ZlTiaOeO6v GROdaPeZVy4uCnbht1zSMf9RKkSXPxkkWm503kszhbMEkS7oT6qH7VUFO66YxFLOR4Gb ELbzWQ+3C28ehNmvr+GwfFsPPhnkQOVVe/qZ9intuoj33pShgVlyIhXq2+E59QbtOnfc //7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711334248; x=1711939048; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OmGpqFfHYwDGnVVZ3jzAGoFdzesxBNnjTqhjXueHYVY=; b=RQ7AVFXQ+wTGofi0HO3xuElg53hy3qtpn8AX7TSuwnZbioSCeEa78hiseX6HT4Md7Q Dj3bncimpI7zD5MXhnJUpAUPd5XZYtatG5TBToD/GlxfdKwnVILuN2xoFHy5mhMmdTu5 WrGvt0l58DO41UBZagMVmpK1TgCNM4jwTW/+UO+GszcY/XeyMK1Q91BVd0yDBbXyqDhi dL4A1Gy9gFh2P5pPRe+HMvfo1CHHn9rEGW3mwY16xnZq1LKzrsxS4jOmVyIeySZMA4FI 3dowThgo1jTXB+M5SY+FSuoESttHVHxFv8d8jKboPBwOQ70EU+Ce4VxdUDf/wR47D3GV Dagw== X-Forwarded-Encrypted: i=1; AJvYcCVOTWf7+bcDUN+9ArO4eZbbbDhMdP+0EPCDMBZsMDPQemux3RjNBZtiCgsXeaRV3rY/DY/kxZ2fzLTnpEY8gxLLM+jgv0CHkyU= X-Gm-Message-State: AOJu0Yxs64E21Wjj01Gse27Q85+OmPsKTQ99FhMLnZD6uvyvU1bO9HlO bHKtOulIViJFHhT3h6RZdJOJDVad4c6HHGhIY/TQ52cEbjaNOpI4sBiIzaDYcYM= X-Google-Smtp-Source: AGHT+IEjg0Dx2wC73NkBfmUP1gPclrGptZkf2D1z3neuXuajn9j5XqsQLarLqd/JDV0rW21mR1/m4A== X-Received: by 2002:a05:6000:1d85:b0:341:c9d1:eae5 with SMTP id bk5-20020a0560001d8500b00341c9d1eae5mr2379711wrb.27.1711334248259; Sun, 24 Mar 2024 19:37:28 -0700 (PDT) Received: from airbuntu (host81-157-90-255.range81-157.btcentralplus.com. [81.157.90.255]) by smtp.gmail.com with ESMTPSA id ck19-20020a5d5e93000000b00341c6440c36sm3898009wrb.74.2024.03.24.19.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Mar 2024 19:37:27 -0700 (PDT) Date: Mon, 25 Mar 2024 02:37:26 +0000 From: Qais Yousef To: "Rafael J. Wysocki" Cc: Christian Loehle , linux-kernel@vger.kernel.org, peterz@infradead.org, juri.lelli@redhat.com, mingo@redhat.com, dietmar.eggemann@arm.com, vschneid@redhat.com, vincent.guittot@linaro.org, Johannes.Thumshirn@wdc.com, adrian.hunter@intel.com, ulf.hansson@linaro.org, andres@anarazel.de, asml.silence@gmail.com, linux-pm@vger.kernel.org, linux-block@vger.kernel.org, io-uring@vger.kernel.org Subject: Re: [RFC PATCH 2/2] cpufreq/schedutil: Remove iowait boost Message-ID: <20240325023726.itkhlg66uo5kbljx@airbuntu> References: <20240304201625.100619-1-christian.loehle@arm.com> <20240304201625.100619-3-christian.loehle@arm.com> <5060c335-e90a-430f-bca5-c0ee46a49249@arm.com> Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 03/18/24 18:08, Rafael J. Wysocki wrote: > On Mon, Mar 18, 2024 at 5:40 PM Christian Loehle > wrote: > > > > On 18/03/2024 14:07, Rafael J. Wysocki wrote: > > > On Mon, Mar 4, 2024 at 9:17 PM Christian Loehle > > > wrote: > > >> > > >> The previous commit provides a new cpu_util_cfs_boost_io interface for > > >> schedutil which uses the io boosted utilization of the per-task > > >> tracking strategy. Schedutil iowait boosting is therefore no longer > > >> necessary so remove it. > > > > > > I'm wondering about the cases when schedutil is used without EAS. > > > > > > Are they still going to be handled as before after this change? > > > > Well they should still get boosted (under the new conditions) and according > > to my tests that does work. > > OK > > > Anything in particular you're worried about? > > It is not particularly clear to me how exactly the boost is taken into > account without EAS. > > > So in terms of throughput I see similar results with EAS and CAS+sugov. > > I'm happy including numbers in the cover letter for future versions, too. > > So far my intuition was that nobody would care enough to include them > > (as long as it generally still works). > > Well, IMV clear understanding of the changes is more important. I think the major thing we need to be careful about is the behavior when the task is sleeping. I think the boosting will be removed when the task is dequeued and I can bet there will be systems out there where the BLOCK softirq being boosted when the task is sleeping will matter. FWIW I do have an implementation for per-task iowait boost where I went a step further and converted intel_pstate too and like Christian didn't notice a regression. But I am not sure (rather don't think) I triggered this use case. I can't tell when the systems truly have per-cpu cpufreq control or just appear so and they are actually shared but not visible at linux level.