public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH] Fix portability issues in configure script
@ 2024-04-09 17:27 Arthur Williams
  2024-04-09 17:37 ` Ammar Faizi
  0 siblings, 1 reply; 4+ messages in thread
From: Arthur Williams @ 2024-04-09 17:27 UTC (permalink / raw)
  To: axboe; +Cc: io-uring, Arthur Williams

The configure script failed on my setup because of the invalid printf
directive "%" and for use of the unportable "echo -e". These have been
replaced with more portable options.
---
 configure | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/configure b/configure
index 052920d..f6b590b 100755
--- a/configure
+++ b/configure
@@ -519,9 +519,9 @@ print_config "CXX" "$cxx"
 # generate io_uring_version.h
 # Reset MAKEFLAGS
 MAKEFLAGS=
-MAKE_PRINT_VARS="include Makefile.common\nprint-%: ; @echo \$(\$*)\n"
-VERSION_MAJOR=$(env echo -e "$MAKE_PRINT_VARS" | make -s --no-print-directory -f - print-VERSION_MAJOR)
-VERSION_MINOR=$(env echo -e "$MAKE_PRINT_VARS" | make -s --no-print-directory -f - print-VERSION_MINOR)
+MAKE_PRINT_VARS="include Makefile.common\nprint-%%: ; @echo \$(\$*)\n"
+VERSION_MAJOR=$(printf "$MAKE_PRINT_VARS" | make -s --no-print-directory -f - print-VERSION_MAJOR)
+VERSION_MINOR=$(printf "$MAKE_PRINT_VARS" | make -s --no-print-directory -f - print-VERSION_MINOR)
 io_uring_version_h="src/include/liburing/io_uring_version.h"
 cat > $io_uring_version_h << EOF
 /* SPDX-License-Identifier: MIT */
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix portability issues in configure script
  2024-04-09 17:27 [PATCH] Fix portability issues in configure script Arthur Williams
@ 2024-04-09 17:37 ` Ammar Faizi
  2024-04-26  6:31   ` Arthur Williams
  0 siblings, 1 reply; 4+ messages in thread
From: Ammar Faizi @ 2024-04-09 17:37 UTC (permalink / raw)
  To: Arthur Williams; +Cc: Jens Axboe, io-uring Mailing List

On Tue, Apr 09, 2024 at 10:27:35AM -0700, Arthur Williams wrote:
> The configure script failed on my setup because of the invalid printf
> directive "%" and for use of the unportable "echo -e". These have been
> replaced with more portable options.
> ---
>  configure | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

The patch is missing your Signed-off-by tag.

-- 
Ammar Faizi


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] Fix portability issues in configure script
  2024-04-09 17:37 ` Ammar Faizi
@ 2024-04-26  6:31   ` Arthur Williams
  2024-04-26 14:30     ` Jens Axboe
  0 siblings, 1 reply; 4+ messages in thread
From: Arthur Williams @ 2024-04-26  6:31 UTC (permalink / raw)
  To: axboe; +Cc: io-uring, Arthur Williams

The configure script failed on my setup because of the invalid printf
directive "%" and for use of the unportable "echo -e". These have been
replaced with more portable options.

Signed-off-by: Arthur Williams <[email protected]>
---
 configure | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/configure b/configure
index 052920d..f6b590b 100755
--- a/configure
+++ b/configure
@@ -519,9 +519,9 @@ print_config "CXX" "$cxx"
 # generate io_uring_version.h
 # Reset MAKEFLAGS
 MAKEFLAGS=
-MAKE_PRINT_VARS="include Makefile.common\nprint-%: ; @echo \$(\$*)\n"
-VERSION_MAJOR=$(env echo -e "$MAKE_PRINT_VARS" | make -s --no-print-directory -f - print-VERSION_MAJOR)
-VERSION_MINOR=$(env echo -e "$MAKE_PRINT_VARS" | make -s --no-print-directory -f - print-VERSION_MINOR)
+MAKE_PRINT_VARS="include Makefile.common\nprint-%%: ; @echo \$(\$*)\n"
+VERSION_MAJOR=$(printf "$MAKE_PRINT_VARS" | make -s --no-print-directory -f - print-VERSION_MAJOR)
+VERSION_MINOR=$(printf "$MAKE_PRINT_VARS" | make -s --no-print-directory -f - print-VERSION_MINOR)
 io_uring_version_h="src/include/liburing/io_uring_version.h"
 cat > $io_uring_version_h << EOF
 /* SPDX-License-Identifier: MIT */
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix portability issues in configure script
  2024-04-26  6:31   ` Arthur Williams
@ 2024-04-26 14:30     ` Jens Axboe
  0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2024-04-26 14:30 UTC (permalink / raw)
  To: Arthur Williams; +Cc: io-uring


On Thu, 25 Apr 2024 23:31:50 -0700, Arthur Williams wrote:
> The configure script failed on my setup because of the invalid printf
> directive "%" and for use of the unportable "echo -e". These have been
> replaced with more portable options.
> 
> 

Applied, thanks!

[1/1] Fix portability issues in configure script
      commit: 380d12d0f5d68be09ccc6151ccca3e15857b16fa

Best regards,
-- 
Jens Axboe




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-04-26 14:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-09 17:27 [PATCH] Fix portability issues in configure script Arthur Williams
2024-04-09 17:37 ` Ammar Faizi
2024-04-26  6:31   ` Arthur Williams
2024-04-26 14:30     ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox