From: Anuj Gupta <[email protected]>
To: [email protected]
Cc: [email protected], [email protected],
Anuj Gupta <[email protected]>
Subject: [PATCH] io_uring/rw: ensure retry isn't lost for write
Date: Mon, 22 Apr 2024 19:05:17 +0530 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: CGME20240422134215epcas5p4b5dcd1a5cd0308be5e43f691d7f92947@epcas5p4.samsung.com
In case of write, the iov_iter gets updated before retry kicks in.
Restore the iov_iter before retrying. It can be reproduced by issuing
a write greater than device limit.
Fixes: df604d2ad480 (io_uring/rw: ensure retry condition isn't lost)
Signed-off-by: Anuj Gupta <[email protected]>
---
io_uring/rw.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/io_uring/rw.c b/io_uring/rw.c
index 4fed829fe97c..9fadb29ec34f 100644
--- a/io_uring/rw.c
+++ b/io_uring/rw.c
@@ -1035,8 +1035,10 @@ int io_write(struct io_kiocb *req, unsigned int issue_flags)
else
ret2 = -EINVAL;
- if (req->flags & REQ_F_REISSUE)
+ if (req->flags & REQ_F_REISSUE) {
+ iov_iter_restore(&io->iter, &io->iter_state);
return IOU_ISSUE_SKIP_COMPLETE;
+ }
/*
* Raw bdev writes will return -EOPNOTSUPP for IOCB_NOWAIT. Just
--
2.25.1
next parent reply other threads:[~2024-04-22 17:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240422134215epcas5p4b5dcd1a5cd0308be5e43f691d7f92947@epcas5p4.samsung.com>
2024-04-22 13:35 ` Anuj Gupta [this message]
2024-04-23 12:15 ` [PATCH] io_uring/rw: ensure retry isn't lost for write Anuj gupta
2024-04-23 14:00 ` Pavel Begunkov
2024-04-24 13:36 ` Jens Axboe
2024-04-24 15:04 ` Pavel Begunkov
2024-04-25 15:15 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox