From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 814C2156232 for ; Mon, 6 May 2024 16:23:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715012606; cv=none; b=fEXyK0/v2tHnXgDUgM+Bmn5L364oy7FriRaGMVfLGQo66jhDEuVJwIyUyK2KWdRaIv0w/vS/EpMLnZVjBNNo7Y5O35VYoSeH9uM4ftQqO2eEb/TxFAE/IkcrVcsgBz6fNBoocy8NVOW3gOS3IcTJWdVrQZA8ZcGQDwLGAXNjicM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715012606; c=relaxed/simple; bh=+zyUlT9KJFbGaq9cJIsLWXCQw64UitjH+LsLVwiP20M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UcvUYam5hyrxEbQTpnWs97Xj4VXxtWa9We4Q05nwphaq7Hw2iasfHN6ld1I3+NOcsq+YYOAspTUPYgGRBavQbIlC93p3V7XzsVRTk5ffTKif3joIQRJuUxPfzk6/UjyEwiRGrn5k3bfAwSwOO0WEolmDKEbRuc9OkE9AQKXI49A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=deLApaAn; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="deLApaAn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715012603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=aIoSW/a8xQVbobfudbPMQ+S1MT42qVAVoLx53nUeMx8=; b=deLApaAnkJp+VDwqUCJ/JrVWEpqUdoYGoeqhKEm1wtP7NP8BjJ1fowNcrddFYAsm8wnAHI rgGkgC7T63aiFmLqvoRaErDHHkm+97rX/CUT05WAf4zxsq7QnDbKRxXqfl6HFByvtwFok0 uG6sYkJuSfAi28fkXlaEsH6aDEFCK4I= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-20-9ulM3rN9M_qZ93qF4VPNig-1; Mon, 06 May 2024 12:23:15 -0400 X-MC-Unique: 9ulM3rN9M_qZ93qF4VPNig-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B103329ABA09; Mon, 6 May 2024 16:23:14 +0000 (UTC) Received: from localhost (unknown [10.72.116.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id B030C40C6DAE; Mon, 6 May 2024 16:23:13 +0000 (UTC) From: Ming Lei To: Jens Axboe , io-uring@vger.kernel.org Cc: linux-block@vger.kernel.org, Pavel Begunkov , Kevin Wolf , Ming Lei Subject: [RFC PATCH V2 0/9] io_uring: support sqe group and provide group kbuf Date: Tue, 7 May 2024 00:22:36 +0800 Message-ID: <20240506162251.3853781-1-ming.lei@redhat.com> Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 Hello, The 1st 4 patches are cleanup, and prepare for adding sqe group. The 5th patch supports generic sqe group which is like link chain, but allows each sqe in group to be issued in parallel, so N:M dependency can be supported with sqe group & io link together. The 6th patch supports one variant of sqe group: allow members to depend on group leader, so that kernel resource lifetime can be aligned with group leader or group, then any kernel resource can be shared in this sqe group, and can be used in generic device zero copy. The 7th & 8th patches supports providing sqe group buffer via the sqe group variant. The 9th patch supports ublk zero copy based on io_uring providing sqe group buffer. Tests: 1) pass liburing test - make runtests 2) write/pass two sqe group test cases: https://github.com/axboe/liburing/compare/master...ming1:liburing:sqe_group_v2 covers related sqe flags combination and linking groups, both nop and one multi-destination file copy. 3) ublksrv zero copy: ublksrv userspace implements zero copy by sqe group & provide group kbuf: git clone https://github.com/ublk-org/ublksrv.git -b group-provide-buf_v2 make test T=loop/009:nbd/061:nbd/062 #ublk zc tests When running 64KB block size test on ublk-loop('ublk add -t loop --buffered_io -f $backing'), it is observed that perf can be doubled. Any comments are welcome! V2: - add generic sqe group, suggested by Kevin Wolf - add REQ_F_SQE_GROUP_DEP which is based on IOSQE_SQE_GROUP, for sharing kernel resource in group wide, suggested by Kevin Wolf - remove sqe ext flag, and use the last bit for IOSQE_SQE_GROUP(Pavel), in future we still can extend sqe flags with one uring context flag - initialize group requests via submit state pattern, suggested by Pavel - all kinds of cleanup & bug fixes Ming Lei (9): io_uring: add io_link_req() helper io_uring: add io_submit_fail_link() helper io_uring: add helper of io_req_commit_cqe() io_uring: move marking REQ_F_CQE_SKIP out of io_free_req() io_uring: support SQE group io_uring: support sqe group with members depending on leader io_uring: support providing sqe group buffer io_uring/uring_cmd: support provide group kernel buffer ublk: support provide io buffer drivers/block/ublk_drv.c | 158 ++++++++++++++- include/linux/io_uring/cmd.h | 7 + include/linux/io_uring_types.h | 48 +++++ include/uapi/linux/io_uring.h | 10 +- include/uapi/linux/ublk_cmd.h | 7 +- io_uring/io_uring.c | 356 +++++++++++++++++++++++++++++---- io_uring/io_uring.h | 29 ++- io_uring/kbuf.c | 60 ++++++ io_uring/kbuf.h | 13 ++ io_uring/net.c | 31 ++- io_uring/opdef.c | 5 + io_uring/opdef.h | 2 + io_uring/rw.c | 20 +- io_uring/timeout.c | 3 + io_uring/uring_cmd.c | 28 +++ 15 files changed, 724 insertions(+), 53 deletions(-) -- 2.42.0