public inbox for [email protected]
 help / color / mirror / Atom feed
From: Chenliang Li <[email protected]>
To: [email protected]
Cc: [email protected], [email protected],
	[email protected], [email protected],
	[email protected], [email protected],
	[email protected], [email protected]
Subject: Re: [PATCH liburing v2] test: add test cases for hugepage registered buffers
Date: Fri, 31 May 2024 09:41:31 +0800	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 2024-05-30 14:51 UTC, Jens Axboe wrote:
> Thanks for improving the test case. Note on the commit message - use
> '---' as the separator, not a random number of '-' as it would otherwise
> need hand editing after being applied.

Will pay attention next time.

> This is against a really old base, can you resend it so it applies to
> the current tree? Would not be hard to hand apply, but it's a bit
> worrying if your tree is that old.

Sure, will rebase it.

> Outside of that, if you get ENOMEM on mmap'ing a huge page because the
> system doesn't have huge pages allocated (quite common), the test case
> should print an information message and return T_EXIT_SKIP to skip the
> test case rather than hard failing.
> 
> A few other comments below.

Will fix these issues. Thanks!


      parent reply	other threads:[~2024-05-31  1:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240530031555epcas5p352110986064e3d9bcd31683fe59188ee@epcas5p3.samsung.com>
2024-05-30  3:15 ` [PATCH liburing v2] test: add test cases for hugepage registered buffers Chenliang Li
2024-05-30 14:51   ` Jens Axboe
     [not found]     ` <CGME20240531014136epcas5p2a13112956b5b492f7ac74d230270c8eb@epcas5p2.samsung.com>
2024-05-31  1:41       ` Chenliang Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox