public inbox for [email protected]
 help / color / mirror / Atom feed
From: Gabriel Krisman Bertazi <[email protected]>
To: [email protected]
Cc: [email protected], Gabriel Krisman Bertazi <[email protected]>
Subject: [PATCH 0/3] io_uring op probing fixes
Date: Tue, 18 Jun 2024 22:06:17 -0400	[thread overview]
Message-ID: <[email protected]> (raw)

Hi Jens,

I didn't know this interface existed until today, when I started looking
at creating exactly this feature.  My goal is to know which operation
supports which modes (registered buffers, bundled writes, iopoll).  Now
that I know it exists, I might just expose the extra information through
io_uring_probe_op->flags, instead of adding a new operation. What do you
think?

Anyway, this patchset is not implementing that.  Patch 1 fixes an issue
with the existing interface. Patches 2 and 3 are small cleanups to the
same path, since I was already looking at it.

I tested it with a !CONFIG_NET kernel to have some disabled operations.
It also survived the liburing testsuite.

Gabriel Krisman Bertazi (3):
  io_uring: Fix probe of disabled operations
  io_uring: Allocate only necessary memory in io_probe
  io_uring: Don't read userspace data in io_probe

 io_uring/opdef.c    |  8 ++++++++
 io_uring/opdef.h    |  4 ++--
 io_uring/register.c | 20 +++++---------------
 3 files changed, 15 insertions(+), 17 deletions(-)

-- 
2.45.2


             reply	other threads:[~2024-06-19  2:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19  2:06 Gabriel Krisman Bertazi [this message]
2024-06-19  2:06 ` [PATCH 1/3] io_uring: Fix probe of disabled operations Gabriel Krisman Bertazi
2024-06-19  2:06 ` [PATCH 2/3] io_uring: Allocate only necessary memory in io_probe Gabriel Krisman Bertazi
2024-06-19  2:06 ` [PATCH 3/3] io_uring: Don't read userspace data " Gabriel Krisman Bertazi
2024-06-19 13:44   ` Jens Axboe
2024-06-19 14:55     ` Gabriel Krisman Bertazi
2024-06-19 14:57       ` Jens Axboe
2024-06-19 13:42 ` [PATCH 0/3] io_uring op probing fixes Jens Axboe
2024-06-19 14:58 ` (subset) " Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox