From: Chenliang Li <[email protected]>
To: [email protected], [email protected]
Cc: [email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected],
Chenliang Li <[email protected]>
Subject: [PATCH v5 0/3] io_uring/rsrc: coalescing multi-hugepage registered buffers
Date: Fri, 28 Jun 2024 16:44:08 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: CGME20240628084418epcas5p14c304761ca375a6afba3aa199c27f9e3@epcas5p1.samsung.com
Registered buffers are stored and processed in the form of bvec array,
each bvec element typically points to a PAGE_SIZE page but can also work
with hugepages. Specifically, a buffer consisting of a hugepage is
coalesced to use only one hugepage bvec entry during registration.
This coalescing feature helps to save both the space and DMA-mapping time.
However, currently the coalescing feature doesn't work for multi-hugepage
buffers. For a buffer with several 2M hugepages, we still split it into
thousands of 4K page bvec entries while in fact, we can just use a
handful of hugepage bvecs.
This patch series enables coalescing registered buffers with more than
one hugepages. It optimizes the DMA-mapping time and saves memory for
these kind of buffers.
Testing:
The hugepage fixed buffer I/O can be tested using fio without
modification. The fio command used in the following test is given
in [1]. There's also a liburing testcase in [2]. Also, the system
should have enough hugepages available before testing.
Perf diff of 8M(4 * 2M hugepages) fio randread test:
Before After Symbol
.....................................................
5.88% [k] __blk_rq_map_sg
3.98% -3.95% [k] dma_direct_map_sg
2.47% [k] dma_pool_alloc
1.37% -1.36% [k] sg_next
+0.28% [k] dma_map_page_attrs
Perf diff of 8M fio randwrite test:
Before After Symbol
......................................................
2.80% [k] __blk_rq_map_sg
1.74% [k] dma_direct_map_sg
1.61% [k] dma_pool_alloc
0.67% [k] sg_next
+0.04% [k] dma_map_page_attrs
First two patches prepare for adding the multi-hugepage coalescing
into buffer registration, the 3rd patch enables the feature.
-----------------
Changes since v4:
- Use a new compacted array of pages instead of the original one,
if buffer can be coalesced.
- Clear unnecessary loops after using the new page array.
- Remove the account and init helper for coalesced imu. Use the original
path instead.
- Remove unnecessary nr_folios field in the io_imu_folio_data struct.
- Rearrange the helper functions.
v4 : https://lore.kernel.org/io-uring/[email protected]/T/#t
Changes since v3:
- Delete unnecessary commit message
- Update test command and test results
v3 : https://lore.kernel.org/io-uring/[email protected]/T/#t
Changes since v2:
- Modify the loop iterator increment to make code cleaner
- Minor fix to the return procedure in coalesced buffer account
- Correct commit messages
- Add test cases in liburing
v2 : https://lore.kernel.org/io-uring/[email protected]/T/#t
Changes since v1:
- Split into 4 patches
- Fix code style issues
- Rearrange the change of code for cleaner look
- Add speciallized pinned page accounting procedure for coalesced
buffers
- Reordered the newly add fields in imu struct for better compaction
v1 : https://lore.kernel.org/io-uring/[email protected]/T/#u
[1]
fio -iodepth=64 -rw=randread(-rw=randwrite) -direct=1 -ioengine=io_uring \
-bs=8M -numjobs=1 -group_reporting -mem=shmhuge -fixedbufs -hugepage-size=2M \
-filename=/dev/nvme0n1 -runtime=10s -name=test1
[2]
https://lore.kernel.org/io-uring/[email protected]/T/#u
Chenliang Li (3):
io_uring/rsrc: add hugepage fixed buffer coalesce helpers
io_uring/rsrc: store folio shift and mask into imu
io_uring/rsrc: enable multi-hugepage buffer coalescing
io_uring/rsrc.c | 149 +++++++++++++++++++++++++++++++++++-------------
io_uring/rsrc.h | 11 ++++
2 files changed, 120 insertions(+), 40 deletions(-)
base-commit: 50cf5f3842af3135b88b041890e7e12a74425fcb
--
2.34.1
next parent reply other threads:[~2024-06-29 7:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240628084418epcas5p14c304761ca375a6afba3aa199c27f9e3@epcas5p1.samsung.com>
2024-06-28 8:44 ` Chenliang Li [this message]
[not found] ` <CGME20240628084420epcas5p32f49e7c977695d20bcef7734eb2e38b4@epcas5p3.samsung.com>
2024-06-28 8:44 ` [PATCH v5 1/3] io_uring/rsrc: add hugepage fixed buffer coalesce helpers Chenliang Li
2024-07-09 13:09 ` Pavel Begunkov
[not found] ` <CGME20240710022336epcas5p2685a44c8e04962830f4e7f8ffee8168f@epcas5p2.samsung.com>
2024-07-10 2:23 ` Chenliang Li
[not found] ` <CGME20240628084422epcas5p3b5d4c93e5fa30069c703bcead1fa0033@epcas5p3.samsung.com>
2024-06-28 8:44 ` [PATCH v5 2/3] io_uring/rsrc: store folio shift and mask into imu Chenliang Li
[not found] ` <CGME20240628084424epcas5p3c34ec2fb8fb45752ef6a11447812ae0d@epcas5p3.samsung.com>
2024-06-28 8:44 ` [PATCH v5 3/3] io_uring/rsrc: enable multi-hugepage buffer coalescing Chenliang Li
2024-07-09 13:17 ` Pavel Begunkov
[not found] ` <CGME20240710022900epcas5p368c4ebc44f3ace1ca0804116bd913512@epcas5p3.samsung.com>
2024-07-10 2:28 ` Chenliang Li
[not found] ` <CGME20240708021432epcas5p4e7e74d81a42a559f2b059e94e7022740@epcas5p4.samsung.com>
2024-07-08 2:14 ` [PATCH v5 0/3] io_uring/rsrc: coalescing multi-hugepage registered buffers Chenliang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox