From: Gabriel Krisman Bertazi <[email protected]>
To: [email protected], [email protected]
Cc: [email protected], Gabriel Krisman Bertazi <[email protected]>
Subject: [PATCH liburing] configure: Respect relative prefix path
Date: Tue, 23 Jul 2024 19:20:26 -0400 [thread overview]
Message-ID: <[email protected]> (raw)
When the user passes a relative path, we end up splitting the
installation in multiple directories because it is relative to $CWD,
which changes when we recurse into subdirectories.
A common idiom I use is:
./configure --prefix=install ; make ; make install
and that currently results in part of the installation inside prefix
and part of it elsewhere:
$ find . -type d -name 'install'
./src/install
./install
Not biggy, but annoying. Let's use the path where the configure command
was invoked as basedir, like other projects usually do.
Signed-off-by: Gabriel Krisman Bertazi <[email protected]>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index f6b590b..21a9356 100755
--- a/configure
+++ b/configure
@@ -10,7 +10,7 @@ for opt do
case "$opt" in
--help|-h) show_help=yes
;;
- --prefix=*) prefix="$optarg"
+ --prefix=*) prefix="$(realpath -s $optarg)"
;;
--includedir=*) includedir="$optarg"
;;
--
2.45.2
next reply other threads:[~2024-07-23 23:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 23:20 Gabriel Krisman Bertazi [this message]
2024-07-24 0:22 ` [PATCH liburing] configure: Respect relative prefix path Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox