From: Mark Harmstone <[email protected]>
To: <[email protected]>, <[email protected]>
Cc: Mark Harmstone <[email protected]>
Subject: [PATCH v4 0/4] btrfs: fix reading from userspace in btrfs_uring_encoded_read()
Date: Fri, 3 Jan 2025 15:02:22 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
Version 4 of mine and Jens' patches, to make sure that when our io_uring
function gets called a second time, it doesn't accidentally read
something from userspace that's gone out of scope or otherwise gotten
corrupted.
I sent a version 3 on December 17, but it looks like that got forgotten
about over Christmas (unsurprisingly). Version 4 fixes a problem that I
noticed, namely that we weren't taking a copy of the iovs, which also
necessitated creating a struct to store these things in. This does
simplify things by removing the need for the kmemdup, however.
I also have a patch for io_uring encoded writes ready to go, but it's
waiting on some of the stuff introduced here.
Jens Axboe (2):
io_uring/cmd: rename struct uring_cache to io_uring_cmd_data
io_uring/cmd: add per-op data to struct io_uring_cmd_data
Mark Harmstone (2):
io_uring: add io_uring_cmd_get_async_data helper
btrfs: don't read from userspace twice in btrfs_uring_encoded_read()
fs/btrfs/ioctl.c | 125 +++++++++++++++++++----------------
include/linux/io_uring/cmd.h | 10 +++
io_uring/io_uring.c | 2 +-
io_uring/opdef.c | 3 +-
io_uring/uring_cmd.c | 23 +++++--
io_uring/uring_cmd.h | 4 --
6 files changed, 97 insertions(+), 70 deletions(-)
--
2.45.2
next reply other threads:[~2025-01-03 15:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 15:02 Mark Harmstone [this message]
2025-01-03 15:02 ` [PATCH 1/4] io_uring/cmd: rename struct uring_cache to io_uring_cmd_data Mark Harmstone
2025-01-03 15:02 ` [PATCH 2/4] io_uring/cmd: add per-op data to struct io_uring_cmd_data Mark Harmstone
2025-01-06 12:47 ` lizetao
2025-01-06 14:46 ` Jens Axboe
2025-01-07 2:04 ` lizetao
2025-01-07 2:17 ` Jens Axboe
2025-01-03 15:02 ` [PATCH 3/4] io_uring: add io_uring_cmd_get_async_data helper Mark Harmstone
2025-01-03 15:02 ` [PATCH 4/4] btrfs: don't read from userspace twice in btrfs_uring_encoded_read() Mark Harmstone
2025-01-03 17:55 ` [PATCH v4 0/4] btrfs: fix reading from userspace " Jens Axboe
2025-01-06 11:58 ` David Sterba
2025-01-06 14:24 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox