From: Bernd Schubert <bschubert@ddn.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Jens Axboe <axboe@kernel.dk>,
Pavel Begunkov <asml.silence@gmail.com>,
linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org,
Joanne Koong <joannelkoong@gmail.com>,
Josef Bacik <josef@toxicpanda.com>,
Amir Goldstein <amir73il@gmail.com>,
Ming Lei <tom.leiming@gmail.com>, David Wei <dw@davidwei.uk>,
bernd@bsbernd.com, Luis Henriques <luis@igalia.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Bernd Schubert <bschubert@ddn.com>,
Miklos Szeredi <mszeredi@redhat.com>
Subject: [PATCH v11 07/18] fuse: Make fuse_copy non static
Date: Thu, 23 Jan 2025 15:51:06 +0100 [thread overview]
Message-ID: <20250123-fuse-uring-for-6-10-rfc4-v11-7-11e9cecf4cfb@ddn.com> (raw)
In-Reply-To: <20250123-fuse-uring-for-6-10-rfc4-v11-0-11e9cecf4cfb@ddn.com>
Move 'struct fuse_copy_state' and fuse_copy_* functions
to fuse_dev_i.h to make it available for fuse-io-uring.
'copy_out_args()' is renamed to 'fuse_copy_out_args'.
Signed-off-by: Bernd Schubert <bschubert@ddn.com>
Reviewed-by: Joanne Koong <joannelkoong@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
---
fs/fuse/dev.c | 30 ++++++++----------------------
fs/fuse/fuse_dev_i.h | 25 +++++++++++++++++++++++++
2 files changed, 33 insertions(+), 22 deletions(-)
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
index 623c5a067c1841e8210b5b4e063e7b6690f1825a..6ee7e28a84c80a3e7c8dc933986c0388371ff6cd 100644
--- a/fs/fuse/dev.c
+++ b/fs/fuse/dev.c
@@ -678,22 +678,8 @@ static int unlock_request(struct fuse_req *req)
return err;
}
-struct fuse_copy_state {
- int write;
- struct fuse_req *req;
- struct iov_iter *iter;
- struct pipe_buffer *pipebufs;
- struct pipe_buffer *currbuf;
- struct pipe_inode_info *pipe;
- unsigned long nr_segs;
- struct page *pg;
- unsigned len;
- unsigned offset;
- unsigned move_pages:1;
-};
-
-static void fuse_copy_init(struct fuse_copy_state *cs, int write,
- struct iov_iter *iter)
+void fuse_copy_init(struct fuse_copy_state *cs, int write,
+ struct iov_iter *iter)
{
memset(cs, 0, sizeof(*cs));
cs->write = write;
@@ -1054,9 +1040,9 @@ static int fuse_copy_one(struct fuse_copy_state *cs, void *val, unsigned size)
}
/* Copy request arguments to/from userspace buffer */
-static int fuse_copy_args(struct fuse_copy_state *cs, unsigned numargs,
- unsigned argpages, struct fuse_arg *args,
- int zeroing)
+int fuse_copy_args(struct fuse_copy_state *cs, unsigned numargs,
+ unsigned argpages, struct fuse_arg *args,
+ int zeroing)
{
int err = 0;
unsigned i;
@@ -1933,8 +1919,8 @@ static struct fuse_req *request_find(struct fuse_pqueue *fpq, u64 unique)
return NULL;
}
-static int copy_out_args(struct fuse_copy_state *cs, struct fuse_args *args,
- unsigned nbytes)
+int fuse_copy_out_args(struct fuse_copy_state *cs, struct fuse_args *args,
+ unsigned nbytes)
{
unsigned reqsize = sizeof(struct fuse_out_header);
@@ -2036,7 +2022,7 @@ static ssize_t fuse_dev_do_write(struct fuse_dev *fud,
if (oh.error)
err = nbytes != sizeof(oh) ? -EINVAL : 0;
else
- err = copy_out_args(cs, req->args, nbytes);
+ err = fuse_copy_out_args(cs, req->args, nbytes);
fuse_copy_finish(cs);
spin_lock(&fpq->lock);
diff --git a/fs/fuse/fuse_dev_i.h b/fs/fuse/fuse_dev_i.h
index 08a7e88e002773fcd18c25a229c7aa6450831401..21eb1bdb492d04f0a406d25bb8d300b34244dce2 100644
--- a/fs/fuse/fuse_dev_i.h
+++ b/fs/fuse/fuse_dev_i.h
@@ -12,6 +12,23 @@
#define FUSE_INT_REQ_BIT (1ULL << 0)
#define FUSE_REQ_ID_STEP (1ULL << 1)
+struct fuse_arg;
+struct fuse_args;
+
+struct fuse_copy_state {
+ int write;
+ struct fuse_req *req;
+ struct iov_iter *iter;
+ struct pipe_buffer *pipebufs;
+ struct pipe_buffer *currbuf;
+ struct pipe_inode_info *pipe;
+ unsigned long nr_segs;
+ struct page *pg;
+ unsigned int len;
+ unsigned int offset;
+ unsigned int move_pages:1;
+};
+
static inline struct fuse_dev *fuse_get_dev(struct file *file)
{
/*
@@ -23,5 +40,13 @@ static inline struct fuse_dev *fuse_get_dev(struct file *file)
void fuse_dev_end_requests(struct list_head *head);
+void fuse_copy_init(struct fuse_copy_state *cs, int write,
+ struct iov_iter *iter);
+int fuse_copy_args(struct fuse_copy_state *cs, unsigned int numargs,
+ unsigned int argpages, struct fuse_arg *args,
+ int zeroing);
+int fuse_copy_out_args(struct fuse_copy_state *cs, struct fuse_args *args,
+ unsigned int nbytes);
+
#endif
--
2.43.0
next prev parent reply other threads:[~2025-01-23 14:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 14:50 [PATCH v11 00/18] fuse: fuse-over-io-uring Bernd Schubert
2025-01-23 14:51 ` [PATCH v11 01/18] fuse: rename to fuse_dev_end_requests and make non-static Bernd Schubert
2025-01-23 14:51 ` [PATCH v11 02/18] fuse: Move fuse_get_dev to header file Bernd Schubert
2025-01-23 14:51 ` [PATCH v11 03/18] fuse: Move request bits Bernd Schubert
2025-01-23 14:51 ` [PATCH v11 04/18] fuse: Add fuse-io-uring design documentation Bernd Schubert
2025-01-23 14:51 ` [PATCH v11 05/18] fuse: make args->in_args[0] to be always the header Bernd Schubert
2025-01-23 14:51 ` [PATCH v11 06/18] fuse: {io-uring} Handle SQEs - register commands Bernd Schubert
2025-01-23 14:51 ` Bernd Schubert [this message]
2025-01-23 14:51 ` [PATCH v11 08/18] fuse: Add fuse-io-uring handling into fuse_copy Bernd Schubert
2025-01-23 14:51 ` [PATCH v11 09/18] fuse: {io-uring} Make hash-list req unique finding functions non-static Bernd Schubert
2025-01-23 14:51 ` [PATCH v11 10/18] fuse: Add io-uring sqe commit and fetch support Bernd Schubert
2025-01-23 14:51 ` [PATCH v11 11/18] fuse: {io-uring} Handle teardown of ring entries Bernd Schubert
2025-01-23 14:51 ` [PATCH v11 12/18] fuse: {io-uring} Make fuse_dev_queue_{interrupt,forget} non-static Bernd Schubert
2025-01-23 14:51 ` [PATCH v11 13/18] fuse: Allow to queue fg requests through io-uring Bernd Schubert
2025-01-23 14:51 ` [PATCH v11 14/18] fuse: Allow to queue bg " Bernd Schubert
2025-01-23 14:51 ` [PATCH v11 15/18] fuse: {io-uring} Prevent mount point hang on fuse-server termination Bernd Schubert
2025-01-23 14:51 ` [PATCH v11 16/18] fuse: block request allocation until io-uring init is complete Bernd Schubert
2025-01-23 14:51 ` [PATCH v11 17/18] fuse: prevent disabling io-uring on active connections Bernd Schubert
2025-01-23 14:51 ` [PATCH v11 18/18] fuse: enable fuse-over-io-uring Bernd Schubert
2025-01-23 14:53 ` [PATCH v11 00/18] fuse: fuse-over-io-uring Bernd Schubert
2025-01-23 14:59 ` Miklos Szeredi
2025-01-23 15:02 ` Bernd Schubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250123-fuse-uring-for-6-10-rfc4-v11-7-11e9cecf4cfb@ddn.com \
--to=bschubert@ddn.com \
--cc=amir73il@gmail.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=bernd@bsbernd.com \
--cc=dan.carpenter@linaro.org \
--cc=dw@davidwei.uk \
--cc=io-uring@vger.kernel.org \
--cc=joannelkoong@gmail.com \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=luis@igalia.com \
--cc=miklos@szeredi.hu \
--cc=mszeredi@redhat.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox