From: Christoph Hellwig <[email protected]>
To: Anuj Gupta <[email protected]>
Cc: Christoph Hellwig <[email protected]>,
[email protected], [email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected],
[email protected],
Kanchan Joshi <[email protected]>
Subject: Re: [PATCH v11 07/10] block: introduce BIP_CHECK_GUARD/REFTAG/APPTAG bip_flags
Date: Tue, 4 Feb 2025 06:39:14 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <20250203143948.GA17571@green245>
On Mon, Feb 03, 2025 at 08:09:48PM +0530, Anuj Gupta wrote:
> + if (bi->csum_type == BLK_INTEGRITY_CSUM_IP)
> + bip->bip_flags |= BIP_IP_CHECKSUM;
I don't think this part will work, but it's a bug since day one of
the nvmet PI support: NVMe doesn't support IP checksum, but in this
case we'd expect the remoe side to supply it. So the setup path
needs to check for a support csum type. I can look into that as a
separate fix.
We'll also need to set the BIP_CHECK_GUARD flag here I think.
next prev parent reply other threads:[~2025-02-04 5:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20241128113036epcas5p397ba228852b72fff671fe695c322a3ef@epcas5p3.samsung.com>
2024-11-28 11:22 ` [PATCH v11 00/10] Read/Write with meta/integrity Anuj Gupta
[not found] ` <CGME20241128113056epcas5p2c9278736c88c646e6f3c7480ffb2211f@epcas5p2.samsung.com>
2024-11-28 11:22 ` [PATCH v11 01/10] block: define set of integrity flags to be inherited by cloned bip Anuj Gupta
[not found] ` <CGME20241128113058epcas5p1f544aa328a27b59f96b48b94dc0bdf94@epcas5p1.samsung.com>
2024-11-28 11:22 ` [PATCH v11 02/10] block: copy back bounce buffer to user-space correctly in case of split Anuj Gupta
[not found] ` <CGME20241128113101epcas5p3fefab67892c16c7bbaba8063c5c4a2c1@epcas5p3.samsung.com>
2024-11-28 11:22 ` [PATCH v11 03/10] block: modify bio_integrity_map_user to accept iov_iter as argument Anuj Gupta
[not found] ` <CGME20241128113104epcas5p4c4bd9f936403295e4cbac7c1f52d9b30@epcas5p4.samsung.com>
2024-11-28 11:22 ` [PATCH v11 04/10] fs, iov_iter: define meta io descriptor Anuj Gupta
[not found] ` <CGME20241128113106epcas5p1b5b06683bfa72225f3c1ab102b9f361c@epcas5p1.samsung.com>
2024-11-28 11:22 ` [PATCH v11 05/10] fs: introduce IOCB_HAS_METADATA for metadata Anuj Gupta
[not found] ` <CGME20241128113109epcas5p46022c85174da65853c85a8848b32f164@epcas5p4.samsung.com>
2024-11-28 11:22 ` [PATCH v11 06/10] io_uring: introduce attributes for read/write and PI support Anuj Gupta
2024-12-03 2:13 ` Martin K. Petersen
2024-12-03 6:56 ` Anuj Gupta
2024-12-03 12:00 ` Pavel Begunkov
2024-12-04 8:09 ` Anuj Gupta
2024-12-05 18:04 ` Keith Busch
2024-12-05 20:17 ` Martin K. Petersen
2024-12-06 12:07 ` Pavel Begunkov
[not found] ` <CGME20241128113112epcas5p186ef86baaa3054effb7244c54ee2f991@epcas5p1.samsung.com>
2024-11-28 11:22 ` [PATCH v11 07/10] block: introduce BIP_CHECK_GUARD/REFTAG/APPTAG bip_flags Anuj Gupta
2025-02-03 6:53 ` Christoph Hellwig
2025-02-03 14:39 ` Anuj Gupta
2025-02-04 5:39 ` Christoph Hellwig [this message]
[not found] ` <CGME20241128113114epcas5p29c7e2a71a136cb50c636a9fe5d87bb0b@epcas5p2.samsung.com>
2024-11-28 11:22 ` [PATCH v11 08/10] nvme: add support for passing on the application tag Anuj Gupta
[not found] ` <CGME20241128113117epcas5p3b0387c302753c5424ba410f5b38ddeb9@epcas5p3.samsung.com>
2024-11-28 11:22 ` [PATCH v11 09/10] scsi: add support for user-meta interface Anuj Gupta
[not found] ` <CGME20241128113120epcas5p3bd415b5a09b3d5b793cbdda0b4102a62@epcas5p3.samsung.com>
2024-11-28 11:22 ` [PATCH v11 10/10] block: add support to pass user meta buffer Anuj Gupta
2024-11-29 16:04 ` [PATCH v11 00/10] Read/Write with meta/integrity Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox