From: Sidong Yang <[email protected]>
To: Josef Bacik <[email protected]>,
David Sterba <[email protected]>, Jens Axboe <[email protected]>,
Pavel Begunkov <[email protected]>
Cc: [email protected], [email protected],
[email protected], Sidong Yang <[email protected]>
Subject: [RFC PATCH v3 3/3] btrfs: ioctl: introduce btrfs_uring_import_iovec()
Date: Sat, 15 Mar 2025 17:23:19 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
This patch introduces btrfs_uring_import_iovec(). In encoded read/write
with uring cmd, it uses import_iovec without supporting fixed buffer.
btrfs_using_import_iovec() could use fixed buffer if cmd flags has
IORING_URING_CMD_FIXED.
Signed-off-by: Sidong Yang <[email protected]>
---
fs/btrfs/ioctl.c | 32 ++++++++++++++++++++++++--------
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 6c18bad53cd3..a7b52fd99059 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -4802,6 +4802,28 @@ struct btrfs_uring_encoded_data {
struct iov_iter iter;
};
+static int btrfs_uring_import_iovec(struct io_uring_cmd *cmd,
+ unsigned int issue_flags, int rw)
+{
+ struct btrfs_uring_encoded_data *data =
+ io_uring_cmd_get_async_data(cmd)->op_data;
+ int ret;
+
+ if (cmd && (cmd->flags & IORING_URING_CMD_FIXED)) {
+ data->iov = NULL;
+ ret = io_uring_cmd_import_fixed_vec(cmd, data->args.iov,
+ data->args.iovcnt,
+ ITER_DEST, issue_flags,
+ &data->iter);
+ } else {
+ data->iov = data->iovstack;
+ ret = import_iovec(rw, data->args.iov, data->args.iovcnt,
+ ARRAY_SIZE(data->iovstack), &data->iov,
+ &data->iter);
+ }
+ return ret;
+}
+
static int btrfs_uring_encoded_read(struct io_uring_cmd *cmd, unsigned int issue_flags)
{
size_t copy_end_kernel = offsetofend(struct btrfs_ioctl_encoded_io_args, flags);
@@ -4874,10 +4896,7 @@ static int btrfs_uring_encoded_read(struct io_uring_cmd *cmd, unsigned int issue
goto out_acct;
}
- data->iov = data->iovstack;
- ret = import_iovec(ITER_DEST, data->args.iov, data->args.iovcnt,
- ARRAY_SIZE(data->iovstack), &data->iov,
- &data->iter);
+ ret = btrfs_uring_import_iovec(cmd, issue_flags, ITER_DEST);
if (ret < 0)
goto out_acct;
@@ -5022,10 +5041,7 @@ static int btrfs_uring_encoded_write(struct io_uring_cmd *cmd, unsigned int issu
if (data->args.len > data->args.unencoded_len - data->args.unencoded_offset)
goto out_acct;
- data->iov = data->iovstack;
- ret = import_iovec(ITER_SOURCE, data->args.iov, data->args.iovcnt,
- ARRAY_SIZE(data->iovstack), &data->iov,
- &data->iter);
+ ret = btrfs_uring_import_iovec(cmd, issue_flags, ITER_SOURCE);
if (ret < 0)
goto out_acct;
--
2.43.0
next prev parent reply other threads:[~2025-03-15 17:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-15 17:23 [RFC PATCH v3 0/3] introduce io_uring_cmd_import_fixed_vec Sidong Yang
2025-03-15 17:23 ` [RFC PATCH v3 1/3] io-uring/cmd: add iou_vec field for io_uring_cmd Sidong Yang
2025-03-16 7:24 ` Pavel Begunkov
2025-03-16 8:02 ` Sidong Yang
2025-03-16 8:49 ` Sidong Yang
2025-03-15 17:23 ` [RFC PATCH v3 2/3] io-uring/cmd: introduce io_uring_cmd_import_fixed_vec Sidong Yang
2025-03-15 17:23 ` Sidong Yang [this message]
2025-03-16 7:22 ` [RFC PATCH v3 0/3] " Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox