[PATCH 1/1] io_uring: fix typo in io_uring.h header

[PATCH 1/1] io_uring: fix typo in io_uring.h header

[Jonas Bonn]

Comment incorrectly implies that flags are mutually exclusive; in
reality, IORING_SETUP_TASKRUN_FLAG requires IORING_SETUP_COOP_TASKRUN.

Fixes: ef060ea9e4fd ("io_uring: add IORING_SETUP_TASKRUN_FLAG")
Signed-off-by: Jonas Bonn <jonas@norrbonn.se>
---
 include/uapi/linux/io_uring.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
index ed2beb4def3f6..e6637d693fa23 100644
--- a/include/uapi/linux/io_uring.h
+++ b/include/uapi/linux/io_uring.h
@@ -183,7 +183,7 @@ enum io_uring_sqe_flags_bit {
 /*
  * If COOP_TASKRUN is set, get notified if task work is available for
  * running and a kernel transition would be needed to run it. This sets
- * IORING_SQ_TASKRUN in the sq ring flags. Not valid with COOP_TASKRUN.
+ * IORING_SQ_TASKRUN in the sq ring flags. Not valid without COOP_TASKRUN.
  */
 #define IORING_SETUP_TASKRUN_FLAG	(1U << 9)
 #define IORING_SETUP_SQE128		(1U << 10) /* SQEs are 128 byte */
-- 
2.45.2

Re: [PATCH 1/1] io_uring: fix typo in io_uring.h header

[Jens Axboe]

On 4/4/25 12:08 AM, Jonas Bonn wrote:
> Comment incorrectly implies that flags are mutually exclusive; in
> reality, IORING_SETUP_TASKRUN_FLAG requires IORING_SETUP_COOP_TASKRUN.
> 
> Fixes: ef060ea9e4fd ("io_uring: add IORING_SETUP_TASKRUN_FLAG")
> Signed-off-by: Jonas Bonn <jonas@norrbonn.se>
> ---
>  include/uapi/linux/io_uring.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
> index ed2beb4def3f6..e6637d693fa23 100644
> --- a/include/uapi/linux/io_uring.h
> +++ b/include/uapi/linux/io_uring.h
> @@ -183,7 +183,7 @@ enum io_uring_sqe_flags_bit {
>  /*
>   * If COOP_TASKRUN is set, get notified if task work is available for
>   * running and a kernel transition would be needed to run it. This sets
> - * IORING_SQ_TASKRUN in the sq ring flags. Not valid with COOP_TASKRUN.
> + * IORING_SQ_TASKRUN in the sq ring flags. Not valid without COOP_TASKRUN.
>   */

IORING_SETUP_TASKRUN_FLAG is not valid if either COOP_TASKRUN or
DEFER_TASKRUN are used. It's not exclusive to COOP_TASKRUN. I do agree
the comment is currently wonky, but we should mention DEFER_TASKRUN as
well when correcting it.

-- 
Jens Axboe