From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAD6C1DB12E for ; Thu, 24 Apr 2025 04:03:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745467392; cv=none; b=tjdxKge2IAAF8SBkvpRVFlBE69MhdO77eWxR7Nu3dEqI7J7MQORwuY9IIHxptW+r+jPhDS3XD7D4/kD7rg+NcoU+QgTs8UO1tJAJOQwJBO+1JJVsKKeBIxIfRC9RWDj2uOkaX+39uIBrFglRHC7mhQx2zi2nYWnDyKgT8+BsGzU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745467392; c=relaxed/simple; bh=M+EoVe0iz3z6LK0bpxKAqvjY9FNWAhMyDmmOVRhy0yk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=dXRAy48zKIwV4r744/n58ht1ayJsr2cMjdn62DqTiKn1N9Un/Z2zwmWmt2bRARPk18JXuD7X9gSK1wC0vxiL1VxvJdP5h48kU+AwsmKljtH1gaYHzP8WdTbh5bZvZVVVDQA+90sHhVN2fbtlMjN+1hOYPvthytHewRLE9pG5EKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=reapeS/6; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="reapeS/6" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-3032f4ea8cfso588805a91.3 for ; Wed, 23 Apr 2025 21:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745467389; x=1746072189; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=UorbkxOGoi+kM8R/LRA30UsUBgYSiSm724ks3SFR6rA=; b=reapeS/6Aij6kj0doQ65kjNWJ513OBXnD6jImAb6/JpOhaHZ3k9ZOFdg9a4emRhw07 XviKAl9Qt9VEPBVhh33pH1wOcgcaIma5Cx+JbmoJJCi4xdJSklYKSYT/swLj1h+N08pj 9R2UHO66eLjLyKT2U1XfNbvLvUUnBl20IiYpXFKBxVO3X9e+icLw6Cp7OGcf1CrKi9+O KaFzA+L5XzZbWH6feK2X3zeP/OYEN0Yxb27fFmwWwByWhS2InkB7bujb+zigI9eLDq7g 9bb62YS7NOeYRHFQ+GjJJU1q2KhKNKXR+pf1hTqaXF+O9gy4e2NnDzNTZ18kyvq81Lcv H2Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745467389; x=1746072189; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UorbkxOGoi+kM8R/LRA30UsUBgYSiSm724ks3SFR6rA=; b=B6VdBdMBsP3wHQwO8e6dhWm8JeaJ5lU68fDdV8TljdtsV0GIyP+PJ/N9I5RwZx8YUE v8IG97l5GbLFxJLgBAJpa5LenzBs6jNV8LMgpFa8D6q/fGisP2X0h5ku4hzs2ZAqRPcX Q8wACErMzutbcMQ60HfBSFhqnVkYT5fdUsdevYdB4GG55I5QU0XejvuAitsiTQVtzEup IXM0nQ1RPTYkELoFmrtTTL/Hfz9+TnLGSyDLbbcHEo2ljcQUL0++yk9/RrMZbULJlrSJ ZSeiywAK+TER90aFj7d/Bd2Astun+zaSMKRYcP8uo+3fTZzvI7ePSugW3N82U3HHZL7h 88sw== X-Forwarded-Encrypted: i=1; AJvYcCWnG09YRseEqUdFp+/7nY8CCMyExSB9kRYNLs7CRevhNMQLdT5X+g4tkyx0vSWYEP0yw7R7mb4AlQ==@vger.kernel.org X-Gm-Message-State: AOJu0YyvJgTvbEyOVWNk+CncuN99SOtXp7Ucz28THNRIgNNMS9cC8YXg WRag6CjaHPfkYScYfmSrmT4RAmOhz6/5Nz38yYEphvJiIEZzQv7DGNVL8xHhxs9M3Ma2ekD29X+ Jy66MgQaS/varkRnKgQ6E8g== X-Google-Smtp-Source: AGHT+IE6UfSjjJaPb2Ixl4liBZlhcJYxBQp412BWCqCF1iqcJPfPbLJAycJrYuatJLsoDyOBxR3XgGhO3tRPxthSew== X-Received: from pjvf14.prod.google.com ([2002:a17:90a:da8e:b0:309:da3b:15d1]) (user=almasrymina job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5445:b0:305:2d27:7cb0 with SMTP id 98e67ed59e1d1-309ed29ce8bmr1728461a91.21.1745467388941; Wed, 23 Apr 2025 21:03:08 -0700 (PDT) Date: Thu, 24 Apr 2025 04:02:55 +0000 In-Reply-To: <20250424040301.2480876-1-almasrymina@google.com> Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250424040301.2480876-1-almasrymina@google.com> X-Mailer: git-send-email 2.49.0.805.g082f7c87e0-goog Message-ID: <20250424040301.2480876-4-almasrymina@google.com> Subject: [PATCH net-next v11 3/8] net: devmem: TCP tx netlink api From: Mina Almasry To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, io-uring@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org Cc: Mina Almasry , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Donald Hunter , Jonathan Corbet , Andrew Lunn , Jeroen de Borst , Harshitha Ramamurthy , Kuniyuki Iwashima , Willem de Bruijn , Jens Axboe , Pavel Begunkov , David Ahern , Neal Cardwell , Stefan Hajnoczi , Stefano Garzarella , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , "=?UTF-8?q?Eugenio=20P=C3=A9rez?=" , sdf@fomichev.me, dw@davidwei.uk, Jamal Hadi Salim , Victor Nogueira , Pedro Tammela , Samiullah Khawaja Content-Type: text/plain; charset="UTF-8" From: Stanislav Fomichev Add bind-tx netlink call to attach dmabuf for TX; queue is not required, only ifindex and dmabuf fd for attachment. Signed-off-by: Stanislav Fomichev Signed-off-by: Mina Almasry --- v3: - Fix ynl-regen.sh error (Simon). --- Documentation/netlink/specs/netdev.yaml | 12 ++++++++++++ include/uapi/linux/netdev.h | 1 + net/core/netdev-genl-gen.c | 13 +++++++++++++ net/core/netdev-genl-gen.h | 1 + net/core/netdev-genl.c | 6 ++++++ tools/include/uapi/linux/netdev.h | 1 + 6 files changed, 34 insertions(+) diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml index f5e0750ab71db..c0ef6d0d77865 100644 --- a/Documentation/netlink/specs/netdev.yaml +++ b/Documentation/netlink/specs/netdev.yaml @@ -743,6 +743,18 @@ operations: - defer-hard-irqs - gro-flush-timeout - irq-suspend-timeout + - + name: bind-tx + doc: Bind dmabuf to netdev for TX + attribute-set: dmabuf + do: + request: + attributes: + - ifindex + - fd + reply: + attributes: + - id kernel-family: headers: [ "net/netdev_netlink.h"] diff --git a/include/uapi/linux/netdev.h b/include/uapi/linux/netdev.h index 7600bf62dbdf0..7eb9571786b83 100644 --- a/include/uapi/linux/netdev.h +++ b/include/uapi/linux/netdev.h @@ -219,6 +219,7 @@ enum { NETDEV_CMD_QSTATS_GET, NETDEV_CMD_BIND_RX, NETDEV_CMD_NAPI_SET, + NETDEV_CMD_BIND_TX, __NETDEV_CMD_MAX, NETDEV_CMD_MAX = (__NETDEV_CMD_MAX - 1) diff --git a/net/core/netdev-genl-gen.c b/net/core/netdev-genl-gen.c index 739f7b6506a6a..4fc44587f4936 100644 --- a/net/core/netdev-genl-gen.c +++ b/net/core/netdev-genl-gen.c @@ -99,6 +99,12 @@ static const struct nla_policy netdev_napi_set_nl_policy[NETDEV_A_NAPI_IRQ_SUSPE [NETDEV_A_NAPI_IRQ_SUSPEND_TIMEOUT] = { .type = NLA_UINT, }, }; +/* NETDEV_CMD_BIND_TX - do */ +static const struct nla_policy netdev_bind_tx_nl_policy[NETDEV_A_DMABUF_FD + 1] = { + [NETDEV_A_DMABUF_IFINDEX] = NLA_POLICY_MIN(NLA_U32, 1), + [NETDEV_A_DMABUF_FD] = { .type = NLA_U32, }, +}; + /* Ops table for netdev */ static const struct genl_split_ops netdev_nl_ops[] = { { @@ -190,6 +196,13 @@ static const struct genl_split_ops netdev_nl_ops[] = { .maxattr = NETDEV_A_NAPI_IRQ_SUSPEND_TIMEOUT, .flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO, }, + { + .cmd = NETDEV_CMD_BIND_TX, + .doit = netdev_nl_bind_tx_doit, + .policy = netdev_bind_tx_nl_policy, + .maxattr = NETDEV_A_DMABUF_FD, + .flags = GENL_CMD_CAP_DO, + }, }; static const struct genl_multicast_group netdev_nl_mcgrps[] = { diff --git a/net/core/netdev-genl-gen.h b/net/core/netdev-genl-gen.h index 17d39fd64c948..cf3fad74511f5 100644 --- a/net/core/netdev-genl-gen.h +++ b/net/core/netdev-genl-gen.h @@ -34,6 +34,7 @@ int netdev_nl_qstats_get_dumpit(struct sk_buff *skb, struct netlink_callback *cb); int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info); int netdev_nl_napi_set_doit(struct sk_buff *skb, struct genl_info *info); +int netdev_nl_bind_tx_doit(struct sk_buff *skb, struct genl_info *info); enum { NETDEV_NLGRP_MGMT, diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c index 2c104947d224f..410df19d98d78 100644 --- a/net/core/netdev-genl.c +++ b/net/core/netdev-genl.c @@ -934,6 +934,12 @@ int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info) return err; } +/* stub */ +int netdev_nl_bind_tx_doit(struct sk_buff *skb, struct genl_info *info) +{ + return 0; +} + void netdev_nl_sock_priv_init(struct netdev_nl_sock *priv) { INIT_LIST_HEAD(&priv->bindings); diff --git a/tools/include/uapi/linux/netdev.h b/tools/include/uapi/linux/netdev.h index 7600bf62dbdf0..7eb9571786b83 100644 --- a/tools/include/uapi/linux/netdev.h +++ b/tools/include/uapi/linux/netdev.h @@ -219,6 +219,7 @@ enum { NETDEV_CMD_QSTATS_GET, NETDEV_CMD_BIND_RX, NETDEV_CMD_NAPI_SET, + NETDEV_CMD_BIND_TX, __NETDEV_CMD_MAX, NETDEV_CMD_MAX = (__NETDEV_CMD_MAX - 1) -- 2.49.0.805.g082f7c87e0-goog