From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>,
io-uring@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>,
linux-block@vger.kernel.org
Cc: Uday Shankar <ushankar@purestorage.com>,
Caleb Sander Mateos <csander@purestorage.com>,
Keith Busch <kbusch@kernel.org>, Ming Lei <ming.lei@redhat.com>
Subject: [RFC PATCH 0/7] ublk: support to register bvec buffer automatically
Date: Mon, 28 Apr 2025 17:44:11 +0800 [thread overview]
Message-ID: <20250428094420.1584420-1-ming.lei@redhat.com> (raw)
Hello Jens,
This patch tries to address limitation from in-tree ublk zero copy:
- one IO needs two extra uring_cmd for register/unregister bvec buffer, not
efficient
- introduced dependency on the two uring_cmd, so the buffer consumer has to
linked with the two uring_cmd, hard to use & less efficient
This patchset adds feature UBLK_F_AUTO_BUF_REG:
- register request buffer automatically before delivering io command to ublk server
- unregister request buffer automatically when completing the request
- both io_uring context and buffer index can be specified from ublk
uring_cmd header
With this way, 'fio/t/io_uring -p0 /dev/ublkb0' shows that IOPS is improved
by 50% compared with F_SUPPORT_ZERO_COPY in my test VM.
kernel selftests are added for covering both function & stress test.
Please review & comment!
Thanks,
Ming
Ming Lei (7):
io_uring: add 'struct io_buf_data' for register/unregister bvec buffer
io_uring: add helper __io_buffer_[un]register_bvec
io_uring: support to register bvec buffer to specified io_uring
ublk: convert to refcount_t
ublk: prepare for supporting to register request buffer automatically
ublk: register buffer to specified io_uring & buf index via
UBLK_F_AUTO_BUF_REG
selftests: ublk: support UBLK_F_AUTO_BUF_REG
drivers/block/ublk_drv.c | 165 ++++++++++++++----
include/linux/io_uring/cmd.h | 15 +-
include/uapi/linux/ublk_cmd.h | 38 ++++
io_uring/rsrc.c | 141 ++++++++++-----
tools/testing/selftests/ublk/Makefile | 2 +
tools/testing/selftests/ublk/file_backed.c | 12 +-
tools/testing/selftests/ublk/kublk.c | 24 ++-
tools/testing/selftests/ublk/kublk.h | 6 +
tools/testing/selftests/ublk/null.c | 43 +++--
tools/testing/selftests/ublk/stripe.c | 21 +--
.../testing/selftests/ublk/test_generic_08.sh | 32 ++++
.../testing/selftests/ublk/test_stress_03.sh | 6 +
.../testing/selftests/ublk/test_stress_04.sh | 6 +
.../testing/selftests/ublk/test_stress_05.sh | 8 +
14 files changed, 409 insertions(+), 110 deletions(-)
create mode 100755 tools/testing/selftests/ublk/test_generic_08.sh
--
2.47.0
next reply other threads:[~2025-04-28 9:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 9:44 Ming Lei [this message]
2025-04-28 9:44 ` [RFC PATCH 1/7] io_uring: add 'struct io_buf_data' for register/unregister bvec buffer Ming Lei
2025-04-29 0:35 ` Caleb Sander Mateos
2025-04-28 9:44 ` [RFC PATCH 2/7] io_uring: add helper __io_buffer_[un]register_bvec Ming Lei
2025-04-29 0:36 ` Caleb Sander Mateos
2025-04-28 9:44 ` [RFC PATCH 3/7] io_uring: support to register bvec buffer to specified io_uring Ming Lei
2025-04-28 10:28 ` Pavel Begunkov
2025-04-29 0:46 ` Caleb Sander Mateos
2025-04-29 0:47 ` Ming Lei
2025-04-30 8:25 ` Pavel Begunkov
2025-04-30 14:44 ` Ming Lei
2025-04-29 0:43 ` Caleb Sander Mateos
2025-04-30 15:34 ` Ming Lei
2025-05-02 1:31 ` Caleb Sander Mateos
2025-05-02 15:59 ` Ming Lei
2025-05-02 21:21 ` Caleb Sander Mateos
2025-05-03 1:00 ` Ming Lei
2025-05-03 18:55 ` Caleb Sander Mateos
2025-05-06 2:45 ` Ming Lei
2025-04-28 9:44 ` [RFC PATCH 4/7] ublk: convert to refcount_t Ming Lei
2025-04-28 17:13 ` Caleb Sander Mateos
2025-04-28 9:44 ` [RFC PATCH 5/7] ublk: prepare for supporting to register request buffer automatically Ming Lei
2025-04-29 0:50 ` Caleb Sander Mateos
2025-04-28 9:44 ` [RFC PATCH 6/7] ublk: register buffer to specified io_uring & buf index via UBLK_F_AUTO_BUF_REG Ming Lei
2025-04-29 0:52 ` Caleb Sander Mateos
2025-04-30 15:45 ` Ming Lei
2025-04-30 16:30 ` Caleb Sander Mateos
2025-05-02 14:09 ` Ming Lei
2025-04-28 9:44 ` [RFC PATCH 7/7] selftests: ublk: support UBLK_F_AUTO_BUF_REG Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428094420.1584420-1-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ushankar@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox