From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BAD2274FF2 for ; Tue, 29 Apr 2025 03:26:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745897221; cv=none; b=V5t+/ch6U/aokcmbMrL4QE+6eSmSwCI/vjeMn15J6Jo6Qzw6+trvjSZEizyzbc+p0ZAefvfCBUpGEPpFLznMzSGD4+835IJpfHqMCBgi2DArC6h2jKj3ZCRhi0E6ZVvm6yKeKcyw5fjp/s3JMOx0ddG1NL3guf6D+lWdVAMNmwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745897221; c=relaxed/simple; bh=DxNGESLbc0qqVVQoxhWRsbyN3RKHn/rRD32tjHejJ14=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=t775JJ4Foex7IIT/oRcVNPAQ8OkR+3VHix3Ep7kv3TuY8L4b6tKji/uNsawpgZp9DLE0iWojLSSFIf2lBUXYSUnPsGQ8bY1/+Eq2mj1PP1OaW18L0Y1rxaAHgxjvF4AmMA2MqBa9uMecHSWQM6fFoXsxZccseeXwuq6jtFtj02k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=MHkB/kfQ; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="MHkB/kfQ" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-7394792f83cso4088106b3a.3 for ; Mon, 28 Apr 2025 20:26:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745897218; x=1746502018; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=+dFmeE1yf4PP9xTqPlHFXHqExSPR7TIPbLaLRjFTwpQ=; b=MHkB/kfQDsWrX7+7Ss3fAvbTe3MBJJa2pacXmcs9IrjEeL0MYv5jIkJImZcA3GqhT8 0KVnwxg83KxCThkq7pXrhQSSbTYyNuBX1UJS4ikWTs0nWxXjd+w6Pux6AjqlkMUzv9SY 1D4SnoDJEjCsfFh3QO+8mjWX4rU3moHtQfrbstAsiSnj0l7204aOGJwz7B9vqGPcwJog t3gvrL01X7XCpTuKJRboVuvmpT9G8S3EXSXhhsguXQC88FKwcibwBeW4tSGe5daLTqO2 T6nZCpE8zfbOTqIHJ6IzoNvom8Evu+gfFg9UFjqImS24u9lqFH7XhR1jNNQXaOvFKC13 Dk8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745897218; x=1746502018; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+dFmeE1yf4PP9xTqPlHFXHqExSPR7TIPbLaLRjFTwpQ=; b=pnoMNzdEXZigaidioA2jUqrpTF8ovSL4QCqKOH/DaekXZs1dBkBKAYA/aGyxje4Cjs tKg1U8D7zRgt+s6Hxu4IiwX/kdzES9OSZAcUgAd0TjuHJoTN6WN++Wo1+d25MM6y9ZQP EuJYrOOGvTb0BaUBTi98p9Fh9V+oPo+v0BU5aaCndOdWGz5YtI/Cqzp9dqOSPmUAnk13 bHduobuUBczSZkEUflx2OV37iGbL0MCPR27nAHuwYzB/Np2N84mn/tUiPE8S+pJm+bIQ ynn5K5gy8S39Mfb5CnKpIn2xOoZwxdLASBvc7pWBIGwpDXxkalsitBEnLEoNB7aXku8w ELFg== X-Forwarded-Encrypted: i=1; AJvYcCXW7mq9t9Lr19HSuU/gw3IqhAy1Ni7e9YIRFC8PDdlQiH3DoM+3Gl5Eo4+a/ogCGzUzl4g2ehm4RA==@vger.kernel.org X-Gm-Message-State: AOJu0YzFm5KmGbej5FTHUNekx+7Om0Ucccac9LzGBKUB0gl3Z/FBqjbF WEgKm61kCJgZA5upj6tEwUsRVHbFm8sMp6URPmUKPEDPN6vMVKJIt4iUfpB7ycpirTBs+gLnc22 oQxCWffFdwiMUHhr5q8DvDg== X-Google-Smtp-Source: AGHT+IEtFbQcQFwgfi2OlOnNXQDfAjiiDlOUQypIclReqKRgNjYwf00+FBuMKAqeLwk9fSRN2LeUBT5sL/7m7Edo9g== X-Received: from pgtl4.prod.google.com ([2002:a65:6804:0:b0:b0d:bc6d:106]) (user=almasrymina job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:9101:b0:1f5:86f2:a674 with SMTP id adf61e73a8af0-2095b7235f0mr1748213637.12.1745897218573; Mon, 28 Apr 2025 20:26:58 -0700 (PDT) Date: Tue, 29 Apr 2025 03:26:42 +0000 In-Reply-To: <20250429032645.363766-1-almasrymina@google.com> Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250429032645.363766-1-almasrymina@google.com> X-Mailer: git-send-email 2.49.0.901.g37484f566f-goog Message-ID: <20250429032645.363766-7-almasrymina@google.com> Subject: [PATCH net-next v13 6/9] net: enable driver support for netmem TX From: Mina Almasry To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, io-uring@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Mina Almasry , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Donald Hunter , Jonathan Corbet , Andrew Lunn , Jeroen de Borst , Harshitha Ramamurthy , Kuniyuki Iwashima , Willem de Bruijn , Jens Axboe , Pavel Begunkov , David Ahern , Neal Cardwell , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , "=?UTF-8?q?Eugenio=20P=C3=A9rez?=" , Stefan Hajnoczi , Stefano Garzarella , Shuah Khan , sdf@fomichev.me, dw@davidwei.uk, Jamal Hadi Salim , Victor Nogueira , Pedro Tammela , Samiullah Khawaja Content-Type: text/plain; charset="UTF-8" Drivers need to make sure not to pass netmem dma-addrs to the dma-mapping API in order to support netmem TX. Add helpers and netmem_dma_*() helpers that enables special handling of netmem dma-addrs that drivers can use. Document in netmem.rst what drivers need to do to support netmem TX. Signed-off-by: Mina Almasry Acked-by: Stanislav Fomichev --- v8: - use spaces instead of tabs (Paolo) v5: - Fix netmet TX documentation (Stan). v4: - New patch --- .../networking/net_cachelines/net_device.rst | 1 + Documentation/networking/netdev-features.rst | 5 ++++ Documentation/networking/netmem.rst | 23 +++++++++++++++++-- include/linux/netdevice.h | 2 ++ include/net/netmem.h | 20 ++++++++++++++++ 5 files changed, 49 insertions(+), 2 deletions(-) diff --git a/Documentation/networking/net_cachelines/net_device.rst b/Documentation/networking/net_cachelines/net_device.rst index ca8605eb82ffc..c69cc89c958e0 100644 --- a/Documentation/networking/net_cachelines/net_device.rst +++ b/Documentation/networking/net_cachelines/net_device.rst @@ -10,6 +10,7 @@ Type Name fastpath_tx_acce =================================== =========================== =================== =================== =================================================================================== unsigned_long:32 priv_flags read_mostly __dev_queue_xmit(tx) unsigned_long:1 lltx read_mostly HARD_TX_LOCK,HARD_TX_TRYLOCK,HARD_TX_UNLOCK(tx) +unsigned long:1 netmem_tx:1; read_mostly char name[16] struct netdev_name_node* name_node struct dev_ifalias* ifalias diff --git a/Documentation/networking/netdev-features.rst b/Documentation/networking/netdev-features.rst index 5014f7cc1398b..02bd7536fc0ca 100644 --- a/Documentation/networking/netdev-features.rst +++ b/Documentation/networking/netdev-features.rst @@ -188,3 +188,8 @@ Redundancy) frames from one port to another in hardware. This should be set for devices which duplicate outgoing HSR (High-availability Seamless Redundancy) or PRP (Parallel Redundancy Protocol) tags automatically frames in hardware. + +* netmem-tx + +This should be set for devices which support netmem TX. See +Documentation/networking/netmem.rst diff --git a/Documentation/networking/netmem.rst b/Documentation/networking/netmem.rst index 7de21ddb54129..b63aded463370 100644 --- a/Documentation/networking/netmem.rst +++ b/Documentation/networking/netmem.rst @@ -19,8 +19,8 @@ Benefits of Netmem : * Simplified Development: Drivers interact with a consistent API, regardless of the underlying memory implementation. -Driver Requirements -=================== +Driver RX Requirements +====================== 1. The driver must support page_pool. @@ -77,3 +77,22 @@ Driver Requirements that purpose, but be mindful that some netmem types might have longer circulation times, such as when userspace holds a reference in zerocopy scenarios. + +Driver TX Requirements +====================== + +1. The Driver must not pass the netmem dma_addr to any of the dma-mapping APIs + directly. This is because netmem dma_addrs may come from a source like + dma-buf that is not compatible with the dma-mapping APIs. + + Helpers like netmem_dma_unmap_page_attrs() & netmem_dma_unmap_addr_set() + should be used in lieu of dma_unmap_page[_attrs](), dma_unmap_addr_set(). + The netmem variants will handle netmem dma_addrs correctly regardless of the + source, delegating to the dma-mapping APIs when appropriate. + + Not all dma-mapping APIs have netmem equivalents at the moment. If your + driver relies on a missing netmem API, feel free to add and propose to + netdev@, or reach out to the maintainers and/or almasrymina@google.com for + help adding the netmem API. + +2. Driver should declare support by setting `netdev->netmem_tx = true` diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 0321fd952f708..a661820a26c44 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -1772,6 +1772,7 @@ enum netdev_reg_state { * @lltx: device supports lockless Tx. Deprecated for real HW * drivers. Mainly used by logical interfaces, such as * bonding and tunnels + * @netmem_tx: device support netmem_tx. * * @name: This is the first field of the "visible" part of this structure * (i.e. as seen by users in the "Space.c" file). It is the name @@ -2087,6 +2088,7 @@ struct net_device { struct_group(priv_flags_fast, unsigned long priv_flags:32; unsigned long lltx:1; + unsigned long netmem_tx:1; ); const struct net_device_ops *netdev_ops; const struct header_ops *header_ops; diff --git a/include/net/netmem.h b/include/net/netmem.h index ecb6b29c93f61..386164fb9c185 100644 --- a/include/net/netmem.h +++ b/include/net/netmem.h @@ -8,6 +8,7 @@ #ifndef _NET_NETMEM_H #define _NET_NETMEM_H +#include #include #include @@ -276,4 +277,23 @@ static inline unsigned long netmem_get_dma_addr(netmem_ref netmem) void get_netmem(netmem_ref netmem); void put_netmem(netmem_ref netmem); +#define netmem_dma_unmap_addr_set(NETMEM, PTR, ADDR_NAME, VAL) \ + do { \ + if (!netmem_is_net_iov(NETMEM)) \ + dma_unmap_addr_set(PTR, ADDR_NAME, VAL); \ + else \ + dma_unmap_addr_set(PTR, ADDR_NAME, 0); \ + } while (0) + +static inline void netmem_dma_unmap_page_attrs(struct device *dev, + dma_addr_t addr, size_t size, + enum dma_data_direction dir, + unsigned long attrs) +{ + if (!addr) + return; + + dma_unmap_page_attrs(dev, addr, size, dir, attrs); +} + #endif /* _NET_NETMEM_H */ -- 2.49.0.901.g37484f566f-goog