public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: io-uring@vger.kernel.org
Cc: asml.silence@gmail.com, csander@purestorage.com,
	Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 1/5] io_uring: open code io_req_cqe_overflow()
Date: Fri, 16 May 2025 14:05:06 -0600	[thread overview]
Message-ID: <20250516201007.482667-2-axboe@kernel.dk> (raw)
In-Reply-To: <20250516201007.482667-1-axboe@kernel.dk>

From: Pavel Begunkov <asml.silence@gmail.com>

A preparation patch, just open code io_req_cqe_overflow().

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Reviewed-by: Caleb Sander Mateos <csander@purestorage.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
 io_uring/io_uring.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index 43c285cd2294..e4d6e572eabc 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -739,14 +739,6 @@ static bool io_cqring_event_overflow(struct io_ring_ctx *ctx, u64 user_data,
 	return true;
 }
 
-static void io_req_cqe_overflow(struct io_kiocb *req)
-{
-	io_cqring_event_overflow(req->ctx, req->cqe.user_data,
-				req->cqe.res, req->cqe.flags,
-				req->big_cqe.extra1, req->big_cqe.extra2);
-	memset(&req->big_cqe, 0, sizeof(req->big_cqe));
-}
-
 /*
  * writes to the cq entry need to come after reading head; the
  * control dependency is enough as we're using WRITE_ONCE to
@@ -1435,11 +1427,19 @@ void __io_submit_flush_completions(struct io_ring_ctx *ctx)
 		    unlikely(!io_fill_cqe_req(ctx, req))) {
 			if (ctx->lockless_cq) {
 				spin_lock(&ctx->completion_lock);
-				io_req_cqe_overflow(req);
+				io_cqring_event_overflow(req->ctx, req->cqe.user_data,
+							req->cqe.res, req->cqe.flags,
+							req->big_cqe.extra1,
+							req->big_cqe.extra2);
 				spin_unlock(&ctx->completion_lock);
 			} else {
-				io_req_cqe_overflow(req);
+				io_cqring_event_overflow(req->ctx, req->cqe.user_data,
+							req->cqe.res, req->cqe.flags,
+							req->big_cqe.extra1,
+							req->big_cqe.extra2);
 			}
+
+			memset(&req->big_cqe, 0, sizeof(req->big_cqe));
 		}
 	}
 	__io_cq_unlock_post(ctx);
-- 
2.49.0


  reply	other threads:[~2025-05-16 20:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-16 20:05 [PATCHSET v3 0/5] Allow non-atomic allocs for overflows Jens Axboe
2025-05-16 20:05 ` Jens Axboe [this message]
2025-05-16 20:05 ` [PATCH 2/5] io_uring: split alloc and add of overflow Jens Axboe
2025-05-16 23:00   ` Caleb Sander Mateos
2025-05-16 20:05 ` [PATCH 3/5] io_uring: make io_alloc_ocqe() take a struct io_cqe pointer Jens Axboe
2025-05-16 23:07   ` Caleb Sander Mateos
2025-05-16 23:08     ` Caleb Sander Mateos
2025-05-16 23:48     ` Jens Axboe
2025-05-16 20:05 ` [PATCH 4/5] io_uring: pass in struct io_big_cqe to io_alloc_ocqe() Jens Axboe
2025-05-16 23:10   ` Caleb Sander Mateos
2025-05-16 20:05 ` [PATCH 5/5] io_uring: add new helpers for posting overflows Jens Axboe
2025-05-16 23:17   ` Caleb Sander Mateos
2025-05-16 23:49     ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2025-05-17 11:42 [PATCHSET v4 0/5] Allow non-atomic allocs for overflows Jens Axboe
2025-05-17 11:42 ` [PATCH 1/5] io_uring: open code io_req_cqe_overflow() Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250516201007.482667-2-axboe@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asml.silence@gmail.com \
    --cc=csander@purestorage.com \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox