From: Penglei Jiang <superman.xpt@gmail.com>
To: axboe@kernel.dk
Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
Penglei Jiang <superman.xpt@gmail.com>
Subject: [PATCH] io_uring: fix page leak in io_sqe_buffer_register()
Date: Tue, 17 Jun 2025 05:39:40 -0700 [thread overview]
Message-ID: <20250617123940.40113-1-superman.xpt@gmail.com> (raw)
Add missing unpin_user_pages() in the error path
Fixes: d8c2237d0aa9 ("io_uring: add io_pin_pages() helper")
Signed-off-by: Penglei Jiang <superman.xpt@gmail.com>
---
io_uring/rsrc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c
index c592ceace97d..f5ac1b530e21 100644
--- a/io_uring/rsrc.c
+++ b/io_uring/rsrc.c
@@ -804,8 +804,10 @@ static struct io_rsrc_node *io_sqe_buffer_register(struct io_ring_ctx *ctx,
}
imu = io_alloc_imu(ctx, nr_pages);
- if (!imu)
+ if (!imu) {
+ unpin_user_pages(pages, nr_pages);
goto done;
+ }
imu->nr_bvecs = nr_pages;
ret = io_buffer_account_pin(ctx, pages, nr_pages, imu, last_hpage);
--
2.17.1
next reply other threads:[~2025-06-17 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 12:39 Penglei Jiang [this message]
2025-06-17 12:53 ` [PATCH] io_uring: fix page leak in io_sqe_buffer_register() Jens Axboe
2025-06-17 14:02 ` Penglei Jiang
2025-06-17 14:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617123940.40113-1-superman.xpt@gmail.com \
--to=superman.xpt@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox