From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f99.google.com (mail-oa1-f99.google.com [209.85.160.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F43023D298 for ; Tue, 8 Jul 2025 20:22:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752006144; cv=none; b=ENEXlAD2LI5PRM1as9WPOrJb/qeUtgXQoE7IuYO8QN8gHNqC+aXsz9a+YwYw8Ejh743xWdC/jLwXnF6WhG5AzJlZvTM1koC+y26ywuoDEIGZYBMiYVnafU8Le4mpFajxpK80ZBE5ro+cXu6PvCpPlVM6ZlaDNk94f801/aKpBxs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752006144; c=relaxed/simple; bh=4bIax1gyYYvpqMt8cPConX9wmrpXrYqQG/XPD2e8Ioo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NfauHaFXh9UD4pIkX+TwoEtOk6NOwgFFV4dyLtFAF9sLTUqSpbyoTb+nrm+TVNw0OUZ2deWLpAKtghwflKddog66Y/agxNvdQphmBKlC8TrNPVo2gCAmhV+GasIvO9VXSNGg43aMgvr6pT8PkftORlXdz5ZaV0LsH+qDCFQE2II= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=Whn2coy/; arc=none smtp.client-ip=209.85.160.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="Whn2coy/" Received: by mail-oa1-f99.google.com with SMTP id 586e51a60fabf-2e9332de8e2so635022fac.1 for ; Tue, 08 Jul 2025 13:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1752006142; x=1752610942; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IbVhQv8YJGYKLE0LWaArA9jYunrRwOqLWNMX36zOiHY=; b=Whn2coy/AFtW9ZPM+z1T2oH+6PoZhgsVQVCVe1CY2MCwCZDWPnGU4SdSu6ujxixljo Pl0MLQP6uico5tRnGCOyEQ0lnPeJ0flKLrF8K1p+xi0nlwuEHkJiyG/J/SDc32U16lWi l2PGmV57cNLNno4DI6/AM7DypdaSPu79+CE7kHRAq0S5ThHfF54DJ7xIJOmz2hfeN3sS wtEZ5fWLnXZC17tNYp05J2cgjSAR7UpSGKnd6ox9RMh7TPlpy2cs0SEjYv3I/91TnGht QUN88DmeaSbTsiW87q9pQIrA4ebMfLCPvfky5whTgQvxT/dfD7xIlJJ3+l6ecPckwHJ3 yCLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752006142; x=1752610942; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IbVhQv8YJGYKLE0LWaArA9jYunrRwOqLWNMX36zOiHY=; b=BUjSSFh80PBirPNWF4BJU8KaKE9LPaZ9/fx3xQNsmN6tgn2T6On/plkP+TuZXf3Qm2 /z+rZu3vpVlP85ObdY+3iwzqJuUvCMQJzepZBe+wAcC3KUonBpTeWoz3g5Dpy/rDRhS0 MX1sx39o6atiDOzbK4eFBP/vUn0LP1H1Vnwt1yXq6beHcjhSCU14pJc6mTRhuW6HPCaO OqA6OVu+zyr1qajZmXKbdzVvzYSbwdDaUoX4pwwzClzVCo5wpE5KqGnHyVP9V+BNANuf v0DQhWVMjOkh2V7MCNKZSIdXlDgGLzl7mChSZyRpTd1Z8wdIjXhE5BA7xXEQYtNnw0d0 J3FQ== X-Forwarded-Encrypted: i=1; AJvYcCUD/vwNXTZ6ZbN5eTSSvQpA3A0/Z0mhSmlQuj3P9b7rnrdIfFCkTmkVjOewj6xT5Ly9oF2CCPlBFA==@vger.kernel.org X-Gm-Message-State: AOJu0YzmzlZypFrGmZ1yCQUuyvHkuIdOtMSOiCh1NBMrCqAFbEqVLfMg FQ7ZCaogONynt1YTfhoK+BkumMiJy+TwnbITlH7wG1zLvxwwfW6ASO0wEAtSIzpP4pSRDrXWeOo ua2mFSP9JyE66fJDasGjFOYpy04FNc2Ao5k9LO/BGmPVFOAHuD4UF X-Gm-Gg: ASbGnct5VHcKPxOg3fDLzqQ/8ar1QEnH3Av66FvLqWgKm7KRf9MKuIDWmSuCLwd9V5E nCuNMiPNIEuPFKjSym6FTRKgUXrsNdyNp72e+h4D8lJkz5vDjiuF97FhxTtfxSWdLBU7mGAcQc7 Kjyps0tnUg5lTFMvE9CNyEPLB7PWv8YP53HhuzrqbkGQ08xxDkUfmqyk7qs3MJpGZ9SzNgx5oS9 QgdrqL7bG32deCAx8KGweSpMjCfMud2kWK1YVzfbYAEjKs8SecebUtyxAj2y+eb6B9us6b6q/Zy H2S6hTWyFAkmDyFmg2+hcb/ENG/biBfEAAp3lIr+ X-Google-Smtp-Source: AGHT+IE8YlKT/00F+Yu2SYeEG2yU67VWu/UZkefui/vdHgZzLvAUibn1j109YPG+6uWbe8+4Dc9QKFIVL0m4 X-Received: by 2002:a05:6870:e0a8:b0:2e8:f7fd:6a75 with SMTP id 586e51a60fabf-2f796a0b1afmr4657958fac.12.1752006142392; Tue, 08 Jul 2025 13:22:22 -0700 (PDT) Received: from c7-smtp-2023.dev.purestorage.com ([2620:125:9017:12:36:3:5:0]) by smtp-relay.gmail.com with ESMTPS id 586e51a60fabf-2f78fdff09csm717795fac.8.2025.07.08.13.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 13:22:22 -0700 (PDT) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.7.70.37]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id A4BA13402B1; Tue, 8 Jul 2025 14:22:21 -0600 (MDT) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id A2B46E41CDE; Tue, 8 Jul 2025 14:22:21 -0600 (MDT) From: Caleb Sander Mateos To: Chris Mason , Josef Bacik , David Sterba , Jens Axboe Cc: Mark Harmstone , linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, Caleb Sander Mateos Subject: [PATCH v2 2/4] io_uring/cmd: introduce IORING_URING_CMD_REISSUE flag Date: Tue, 8 Jul 2025 14:22:10 -0600 Message-ID: <20250708202212.2851548-3-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250708202212.2851548-1-csander@purestorage.com> References: <20250708202212.2851548-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a flag IORING_URING_CMD_REISSUE that ->uring_cmd() implementations can use to tell whether this is the first or subsequent issue of the uring_cmd. This will allow ->uring_cmd() implementations to store information in the io_uring_cmd's pdu across issues. Signed-off-by: Caleb Sander Mateos --- include/linux/io_uring/cmd.h | 2 ++ io_uring/uring_cmd.c | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/include/linux/io_uring/cmd.h b/include/linux/io_uring/cmd.h index 53408124c1e5..29892f54e0ac 100644 --- a/include/linux/io_uring/cmd.h +++ b/include/linux/io_uring/cmd.h @@ -6,10 +6,12 @@ #include #include /* only top 8 bits of sqe->uring_cmd_flags for kernel internal use */ #define IORING_URING_CMD_CANCELABLE (1U << 30) +/* io_uring_cmd is being issued again */ +#define IORING_URING_CMD_REISSUE (1U << 31) struct io_uring_cmd { struct file *file; const struct io_uring_sqe *sqe; /* callback to defer completions to task context */ diff --git a/io_uring/uring_cmd.c b/io_uring/uring_cmd.c index b228b84a510f..58964a2f8582 100644 --- a/io_uring/uring_cmd.c +++ b/io_uring/uring_cmd.c @@ -259,11 +259,15 @@ int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags) req->iopoll_start = ktime_get_ns(); } } ret = file->f_op->uring_cmd(ioucmd, issue_flags); - if (ret == -EAGAIN || ret == -EIOCBQUEUED) + if (ret == -EAGAIN) { + ioucmd->flags |= IORING_URING_CMD_REISSUE; + return ret; + } + if (ret == -EIOCBQUEUED) return ret; if (ret < 0) req_set_fail(req); io_req_uring_cleanup(req, issue_flags); io_req_set_res(req, ret, 0); -- 2.45.2