public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH liburing 0/2] liburing fixes
@ 2025-07-25 17:59 Ammar Faizi
  2025-07-25 17:59 ` [PATCH liburing 1/2] sanitize: Fix missing `IORING_OP_PIPE` Ammar Faizi
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Ammar Faizi @ 2025-07-25 17:59 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Ammar Faizi, Alviro Iskandar Setiawan, Christian Mazakas,
	Michael de Lang, io-uring Mailing List, GNU/Weeb Mailing List,
	Linux Kernel Mailing List

Hi Jens,

Hopefully, not too late for 2.12. Two small final fixes here:

  - Fix build error when using address sanitizer due to missing
    `IORING_OP_PIPE` in `sanitize.c`.

  - Don't use `IOURINGINLINE` on `__io_uring_prep_poll_mask` as it
    is not a function that should be exported in the FFI API.

Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---

Ammar Faizi (2):
  sanitize: Fix missing `IORING_OP_PIPE`
  liburing: Don't use `IOURINGINLINE` on `__io_uring_prep_poll_mask`

 src/include/liburing.h | 2 +-
 src/sanitize.c         | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)


base-commit: ec856cecab2ed4bcbdba2b06a8c7cb5a52083c28
-- 
Ammar Faizi


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH liburing 1/2] sanitize: Fix missing `IORING_OP_PIPE`
  2025-07-25 17:59 [PATCH liburing 0/2] liburing fixes Ammar Faizi
@ 2025-07-25 17:59 ` Ammar Faizi
  2025-07-25 17:59 ` [PATCH liburing 2/2] liburing: Don't use `IOURINGINLINE` on `__io_uring_prep_poll_mask` Ammar Faizi
  2025-07-25 18:21 ` [PATCH liburing 0/2] liburing fixes Jens Axboe
  2 siblings, 0 replies; 4+ messages in thread
From: Ammar Faizi @ 2025-07-25 17:59 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Ammar Faizi, Alviro Iskandar Setiawan, Christian Mazakas,
	Michael de Lang, io-uring Mailing List, GNU/Weeb Mailing List,
	Linux Kernel Mailing List

Fix build error due to missing `IORING_OP_PIPE`.

```
 sanitize.c:122:17: error: static assertion failed due to requirement \
 'IORING_OP_WRITEV_FIXED + 1 == IORING_OP_LAST': Need an implementation \
 for all IORING_OP_* codes
  122 |         _Static_assert(IORING_OP_WRITEV_FIXED + 1 == IORING_OP_LAST,\
                               "Need an implementation for all IORING_OP_* codes");
      |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

Fixes: eca641e0ea37 ("Add support for IORING_OP_PIPE")
Cc: Michael de Lang <michael@volt-software.nl>
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---
 src/sanitize.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/sanitize.c b/src/sanitize.c
index 48f794545999..383b7d64bbf2 100644
--- a/src/sanitize.c
+++ b/src/sanitize.c
@@ -119,7 +119,8 @@ static inline void initialize_sanitize_handlers()
 	sanitize_handlers[IORING_OP_EPOLL_WAIT] = sanitize_sqe_addr;
 	sanitize_handlers[IORING_OP_READV_FIXED] = sanitize_sqe_addr;
 	sanitize_handlers[IORING_OP_WRITEV_FIXED] = sanitize_sqe_addr;
-	_Static_assert(IORING_OP_WRITEV_FIXED + 1 == IORING_OP_LAST, "Need an implementation for all IORING_OP_* codes");
+	sanitize_handlers[IORING_OP_PIPE] = sanitize_sqe_addr;
+	_Static_assert(IORING_OP_PIPE + 1 == IORING_OP_LAST, "Need an implementation for all IORING_OP_* codes");
 	sanitize_handlers_initialized = true;
 }
 
-- 
Ammar Faizi


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH liburing 2/2] liburing: Don't use `IOURINGINLINE` on `__io_uring_prep_poll_mask`
  2025-07-25 17:59 [PATCH liburing 0/2] liburing fixes Ammar Faizi
  2025-07-25 17:59 ` [PATCH liburing 1/2] sanitize: Fix missing `IORING_OP_PIPE` Ammar Faizi
@ 2025-07-25 17:59 ` Ammar Faizi
  2025-07-25 18:21 ` [PATCH liburing 0/2] liburing fixes Jens Axboe
  2 siblings, 0 replies; 4+ messages in thread
From: Ammar Faizi @ 2025-07-25 17:59 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Ammar Faizi, Alviro Iskandar Setiawan, Christian Mazakas,
	Michael de Lang, io-uring Mailing List, GNU/Weeb Mailing List,
	Linux Kernel Mailing List

Not exported for FFI.

Cc: Christian Mazakas <christian.mazakas@gmail.com>
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---
 src/include/liburing.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/include/liburing.h b/src/include/liburing.h
index dda0d5c4facd..83434f6eca65 100644
--- a/src/include/liburing.h
+++ b/src/include/liburing.h
@@ -704,7 +704,7 @@ IOURINGINLINE void io_uring_prep_sendmsg(struct io_uring_sqe *sqe, int fd,
 	sqe->msg_flags = flags;
 }
 
-IOURINGINLINE unsigned __io_uring_prep_poll_mask(unsigned poll_mask)
+static inline unsigned __io_uring_prep_poll_mask(unsigned poll_mask)
 	LIBURING_NOEXCEPT
 {
 #if __BYTE_ORDER == __BIG_ENDIAN
-- 
Ammar Faizi


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH liburing 0/2] liburing fixes
  2025-07-25 17:59 [PATCH liburing 0/2] liburing fixes Ammar Faizi
  2025-07-25 17:59 ` [PATCH liburing 1/2] sanitize: Fix missing `IORING_OP_PIPE` Ammar Faizi
  2025-07-25 17:59 ` [PATCH liburing 2/2] liburing: Don't use `IOURINGINLINE` on `__io_uring_prep_poll_mask` Ammar Faizi
@ 2025-07-25 18:21 ` Jens Axboe
  2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2025-07-25 18:21 UTC (permalink / raw)
  To: Ammar Faizi
  Cc: Alviro Iskandar Setiawan, Christian Mazakas, Michael de Lang,
	io-uring Mailing List, GNU/Weeb Mailing List,
	Linux Kernel Mailing List


On Sat, 26 Jul 2025 00:59:11 +0700, Ammar Faizi wrote:
> Hopefully, not too late for 2.12. Two small final fixes here:
> 
>   - Fix build error when using address sanitizer due to missing
>     `IORING_OP_PIPE` in `sanitize.c`.
> 
>   - Don't use `IOURINGINLINE` on `__io_uring_prep_poll_mask` as it
>     is not a function that should be exported in the FFI API.
> 
> [...]

Applied, thanks!

[1/2] sanitize: Fix missing `IORING_OP_PIPE`
      commit: ed54d3b7e324220f70dac48b83df4e61763bf844
[2/2] liburing: Don't use `IOURINGINLINE` on `__io_uring_prep_poll_mask`
      commit: 6d3d27bc42733f5a407424c76aadcc84bd4b0cf0

Best regards,
-- 
Jens Axboe




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-07-25 18:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-25 17:59 [PATCH liburing 0/2] liburing fixes Ammar Faizi
2025-07-25 17:59 ` [PATCH liburing 1/2] sanitize: Fix missing `IORING_OP_PIPE` Ammar Faizi
2025-07-25 17:59 ` [PATCH liburing 2/2] liburing: Don't use `IOURINGINLINE` on `__io_uring_prep_poll_mask` Ammar Faizi
2025-07-25 18:21 ` [PATCH liburing 0/2] liburing fixes Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox