Re: [RFC v1 15/22] eth: bnxt: store the rx buf size per queue

[Jakub Kicinski <kuba@kernel.org>]

On Mon, 28 Jul 2025 15:33:55 -0700 Mina Almasry wrote:
> > From: Jakub Kicinski <kuba@kernel.org>
> >
> > In normal operation only a subset of queues is configured for
> > zero-copy. Since zero-copy is the main use for larger buffer
> > sizes we need to configure the sizes per queue.
> >
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>  
> 
> I wonder if this is necessary for some reason, or is it better to
> expect the driver to refer to the netdev->qcfgs directly?
> 
> By my count the configs can now live in 4 places: the core netdev
> config, the core per-queue config, the driver netdev config, and the
> driver per-queue config.
> 
> I honestly I'm not sure about duplicating settings between the netdev
> configs and the per-queue configs in the first place (seems like
> configs should be either driver wide or per-queue to me, and not
> both), and I'm less sure about again duplicating the settings between
> core structs and in-driver structs. Seems like the same information
> duplicated in many places and a nightmare to keep it all in sync.

Does patch 20 answer this question?