From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 918081917E3; Fri, 1 Aug 2025 23:20:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754090411; cv=none; b=ZUoXQVkbacODquXadd1EWAxiu25kfe5oC2qJ1rx75xxUwrLZr7tao/WyUZSF6wf51O9ZV3TwiVgpIEQhchJffczmhEzINaW/YRZBKY9ERMsBkufVIROcS5Fc5/IClcmUp4/wpHQ1DmTGS2s8dqJLEsyEviFfClVVWuKa2TZ5cYc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754090411; c=relaxed/simple; bh=bZ4xo8b9MP/9ePId0VtPvGV942wIprx7/UB1pEqffN4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NUqZzTmamM9qhnT0clbB+XmX2192mHSmyDbs+ijIzaDANmUjO54MRb7ADoWo1m9T4YkoDJ7MQ7Ah0LD6K1pISproEcbkHP6TD/gpIq3YHXe37hQTk/f34aZuqoAcolbnURDXB2icA0lkqOpstKpkLnpBhSoEQz1TbRcQOJjAjZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pUlXpxGe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pUlXpxGe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFEE9C4CEE7; Fri, 1 Aug 2025 23:20:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754090411; bh=bZ4xo8b9MP/9ePId0VtPvGV942wIprx7/UB1pEqffN4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pUlXpxGejdBj+e6AbFnC0enMogF7j0F8ba7B3Dsq5UvzEYitLCnaKj3/8ci87l4ZM 7u0DuL6slLTBWqh8P6el/h5oimGALuaeKw6wZf3lKr8xu+4mTZ+lrQ2vpcm+N6J2hk 34IhZVjcqTnkoDKOZOJqndX2bYSUCr8PFnwUcmfrCOHcn7MtEUIARByx/vo6vspi/I SoGjcTdidryxfBv+W54y4ma0GJWkJ8vy8G93YT89Ef/ONb9U5nYa1fIqwSYxd6b31b hIHhcU42Gbi8oXIWhs3gbNoEUyoChsrZcMkExdBEsLHPrRHFnTs3pkhD8qG/yiqhKs Nyj88EZQL1BsA== Date: Fri, 1 Aug 2025 16:20:10 -0700 From: Jakub Kicinski To: Mina Almasry Cc: Pavel Begunkov , netdev@vger.kernel.org, io-uring@vger.kernel.org, Eric Dumazet , Willem de Bruijn , Paolo Abeni , andrew+netdev@lunn.ch, horms@kernel.org, davem@davemloft.net, sdf@fomichev.me, dw@davidwei.uk, michael.chan@broadcom.com, dtatulea@nvidia.com, ap420073@gmail.com Subject: Re: [RFC v1 15/22] eth: bnxt: store the rx buf size per queue Message-ID: <20250801162010.1f5b3fba@kernel.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 28 Jul 2025 15:33:55 -0700 Mina Almasry wrote: > > From: Jakub Kicinski > > > > In normal operation only a subset of queues is configured for > > zero-copy. Since zero-copy is the main use for larger buffer > > sizes we need to configure the sizes per queue. > > > > Signed-off-by: Jakub Kicinski > > Signed-off-by: Pavel Begunkov > > I wonder if this is necessary for some reason, or is it better to > expect the driver to refer to the netdev->qcfgs directly? > > By my count the configs can now live in 4 places: the core netdev > config, the core per-queue config, the driver netdev config, and the > driver per-queue config. > > I honestly I'm not sure about duplicating settings between the netdev > configs and the per-queue configs in the first place (seems like > configs should be either driver wide or per-queue to me, and not > both), and I'm less sure about again duplicating the settings between > core structs and in-driver structs. Seems like the same information > duplicated in many places and a nightmare to keep it all in sync. Does patch 20 answer this question?