From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECEC337F20B for ; Thu, 21 Aug 2025 20:08:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755806927; cv=none; b=AMbxDJO14mTMaKG1Op+vCIn47fgUYJaIFscp+3FRVOcrkGKe5sJDZ/+5pDFJyFC5+j2pEtH/R7du1HRh4XtGIdJRTtPeLxP1M6UK4oOkVOSRSE8xiYxU29r0GlCVgTmyfDj7gjKWixXnsRY+gITJwdwxbHmrkapCt7kX+/V/1XM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755806927; c=relaxed/simple; bh=+AkJ4dNPQE9q5oho0ySkYtQ5iyrBmFIRoWrlEu7Fgds=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VgfVr1kWW49cJDunk7VXgbv0pLIXQgHQUt3ER+6GBR5IiITutLBbsR7UseLuynXT2kWZKF9oMqrutN5saCP5G+We/DDPOIs0XWSyeMKbp9fQVvu3KbFqKmwJsfuzVhTEVS4pkbiDfVI5h40rszirsB06iSWNgLFrDzbSImfcs6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MNGPJu8i; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MNGPJu8i" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755806922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OnKBChYNBt6k7pWFZ1VK2zlCQ3hhOdGhc0x5VCAB6rA=; b=MNGPJu8iTcM7AFqcPxSU7k89kw8yUjYmPnj/0ZTdp1dgCbA3tR8zbZ1oeBqvZAEYM6p6Mc rFaGyEDYwlxsl4wh3l7Cz+/uVi+BhcqGy7jP3ao08kfnXZEuczpTjT9BgcB2QaxaU06iKL 6n8z1MW6+cNg4eVAoj3detMG+tECnPU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-576-nY5oooBxMTiGfqEW4m71HA-1; Thu, 21 Aug 2025 16:08:41 -0400 X-MC-Unique: nY5oooBxMTiGfqEW4m71HA-1 X-Mimecast-MFC-AGG-ID: nY5oooBxMTiGfqEW4m71HA_1755806920 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3b9e4146902so562532f8f.2 for ; Thu, 21 Aug 2025 13:08:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755806920; x=1756411720; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OnKBChYNBt6k7pWFZ1VK2zlCQ3hhOdGhc0x5VCAB6rA=; b=MEYA1+hf8nPEcOleXZnFVPqXIfaF5zH+6byC2/EzYHUE8YC2iIVJm9/S5N2syapnJN XBR2mZhYPigp6vLaB3SUd0ar5t+L1X6mpdim1AZW5U/pf7Dk5q4JUZsoFrDiCb0J/aGq Yg2yfezk1aE0JEP/moT+MW7bE61kVhzdZPrjjqgWgWCu3VYg998VawSRPY8O0Idc4Gbv v2ND6Rdd0rXQcRYvN/p1F4ua+DUXSA4pRBmFYarc2t71xDenbFFLlX1V7bXB8ckhOfp/ Huld4AkEgR+LF7UqLMI3Aw/OqKIIORP7h1l6Ya9izcZ1eQApMMncW+7/7CwCl4fgIvzd o6ag== X-Forwarded-Encrypted: i=1; AJvYcCX1xoXlvVRqC7bcvUZi0IT29fQb4i0mFkYAE2tWcn/0L6zu+eQqZpfQqpJSXKCBpNsTORwjcoqgbw==@vger.kernel.org X-Gm-Message-State: AOJu0YxD0gi7bgDzpHm6fKfzr6hH99uoTVu4pq8oaqBe7fCiw3bGFw/0 2L1mcOHU3/UQskArDzWjhETIjL8aSCsOQ587bivif/CbhGs+hmp7B7eIUqFSwXGELWAuLQ8vdYR y3Q1p0s1ROEVU6WcDGmQor2QCnVX5xiF1qvC7dO0cr+mkXJ2klDl6Kj8VaoDL X-Gm-Gg: ASbGncupcUKcqGfYex2MrT4D5+gM+c9EtSsgNFX5oGRqMQzl8qp1xMtMcWaAyKVPesJ 5y3SNdUAzpt6hC6xXurEujBBEIduj3RhmQuCjgpA46TbbMGiY62yeZF1Qv21QNxcoCybd8QKx7j CGoDBt7ggvmwKNfQMJr6D1vcuPwHEsNN6uCFdrBfB0qk/N24X0mR0Ne8Of/ytSUhuTAKlR2r6NC AmgVlzTdG+1JHNYkQuFzHPSZb85GuoOCfdU0rOw/nJh3byHd54R3f+71YmwNFBWk2QCefb5urss iISbD/p/UGI6Ajbj63UBZO6sNwWgO4UQ/gAdPOH7kqAGM36osCuS1SPHkffJ4MrBvO7mkcndFY7 2twUA5B8wBBj9FBMmp29/kA== X-Received: by 2002:a05:6000:2405:b0:3a4:e841:b236 with SMTP id ffacd0b85a97d-3c5dc735246mr192352f8f.33.1755806920374; Thu, 21 Aug 2025 13:08:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFrWn9aM0C/1GZBHvF1UL+fKz7WhllpDdsBGpm2GmVOIF4Yc/dULhABMcTdk4u9sLFplZdR3g== X-Received: by 2002:a05:6000:2405:b0:3a4:e841:b236 with SMTP id ffacd0b85a97d-3c5dc735246mr192328f8f.33.1755806919917; Thu, 21 Aug 2025 13:08:39 -0700 (PDT) Received: from localhost (p200300d82f26ba0008036ec5991806fd.dip0.t-ipconnect.de. [2003:d8:2f26:ba00:803:6ec5:9918:6fd]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3c0771c166bsm12920369f8f.33.2025.08.21.13.08.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Aug 2025 13:08:39 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: David Hildenbrand , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Lorenzo Stoakes , Marek Szyprowski , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan Subject: [PATCH RFC 33/35] kfence: drop nth_page() usage Date: Thu, 21 Aug 2025 22:06:59 +0200 Message-ID: <20250821200701.1329277-34-david@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821200701.1329277-1-david@redhat.com> References: <20250821200701.1329277-1-david@redhat.com> Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We want to get rid of nth_page(), and kfence init code is the last user. Unfortunately, we might actually walk a PFN range where the pages are not contiguous, because we might be allocating an area from memblock that could span memory sections in problematic kernel configs (SPARSEMEM without SPARSEMEM_VMEMMAP). We could check whether the page range is contiguous using page_range_contiguous() and failing kfence init, or making kfence incompatible these problemtic kernel configs. Let's keep it simple and simply use pfn_to_page() by iterating PFNs. Cc: Alexander Potapenko Cc: Marco Elver Cc: Dmitry Vyukov Signed-off-by: David Hildenbrand --- mm/kfence/core.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/mm/kfence/core.c b/mm/kfence/core.c index 0ed3be100963a..793507c77f9e8 100644 --- a/mm/kfence/core.c +++ b/mm/kfence/core.c @@ -594,15 +594,15 @@ static void rcu_guarded_free(struct rcu_head *h) */ static unsigned long kfence_init_pool(void) { - unsigned long addr; - struct page *pages; + unsigned long addr, pfn, start_pfn, end_pfn; int i; if (!arch_kfence_init_pool()) return (unsigned long)__kfence_pool; addr = (unsigned long)__kfence_pool; - pages = virt_to_page(__kfence_pool); + start_pfn = PHYS_PFN(virt_to_phys(__kfence_pool)); + end_pfn = start_pfn + KFENCE_POOL_SIZE / PAGE_SIZE; /* * Set up object pages: they must have PGTY_slab set to avoid freeing @@ -612,12 +612,13 @@ static unsigned long kfence_init_pool(void) * fast-path in SLUB, and therefore need to ensure kfree() correctly * enters __slab_free() slow-path. */ - for (i = 0; i < KFENCE_POOL_SIZE / PAGE_SIZE; i++) { - struct slab *slab = page_slab(nth_page(pages, i)); + for (pfn = start_pfn; pfn != end_pfn; pfn++) { + struct slab *slab; if (!i || (i % 2)) continue; + slab = page_slab(pfn_to_page(pfn)); __folio_set_slab(slab_folio(slab)); #ifdef CONFIG_MEMCG slab->obj_exts = (unsigned long)&kfence_metadata_init[i / 2 - 1].obj_exts | @@ -664,11 +665,13 @@ static unsigned long kfence_init_pool(void) return 0; reset_slab: - for (i = 0; i < KFENCE_POOL_SIZE / PAGE_SIZE; i++) { - struct slab *slab = page_slab(nth_page(pages, i)); + for (pfn = start_pfn; pfn != end_pfn; pfn++) { + struct slab *slab; if (!i || (i % 2)) continue; + + slab = page_slab(pfn_to_page(pfn)); #ifdef CONFIG_MEMCG slab->obj_exts = 0; #endif -- 2.50.1