From: Keith Busch <kbusch@meta.com>
To: <io-uring@vger.kernel.org>, <axboe@kernel.dk>, <csander@purestorage.com>
Cc: Keith Busch <kbusch@kernel.org>
Subject: [RFC PATCHv2 3/3] Add mixed sqe test for uring commands
Date: Thu, 4 Sep 2025 12:27:16 -0700 [thread overview]
Message-ID: <20250904192716.3064736-5-kbusch@meta.com> (raw)
In-Reply-To: <20250904192716.3064736-1-kbusch@meta.com>
From: Keith Busch <kbusch@kernel.org>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
test/Makefile | 1 +
test/sqe-mixed-uring_cmd.c | 168 +++++++++++++++++++++++++++++++++++++
2 files changed, 169 insertions(+)
diff --git a/test/Makefile b/test/Makefile
index a36c70a4..25af26a2 100644
--- a/test/Makefile
+++ b/test/Makefile
@@ -234,6 +234,7 @@ test_srcs := \
sq-space_left.c \
sqe-mixed-nop.c \
sqe-mixed-bad-wrap.c \
+ sqe-mixed-uring_cmd.c \
sqwait.c \
stdout.c \
submit-and-wait.c \
diff --git a/test/sqe-mixed-uring_cmd.c b/test/sqe-mixed-uring_cmd.c
index e69de29b..b213270b 100644
--- a/test/sqe-mixed-uring_cmd.c
+++ b/test/sqe-mixed-uring_cmd.c
@@ -0,0 +1,168 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Description: mixed sqes utilizing basic nop and io_uring passthrough commands
+ */
+#include <errno.h>
+#include <stdio.h>
+#include <unistd.h>
+#include <stdlib.h>
+#include <string.h>
+
+#include "helpers.h"
+#include "liburing.h"
+#include "../src/syscall.h"
+#include "nvme.h"
+
+#define min(a, b) ((a) < (b) ? (a) : (b))
+
+static int seq;
+
+static int test_single_nop(struct io_uring *ring, unsigned req_flags)
+{
+ struct io_uring_cqe *cqe;
+ struct io_uring_sqe *sqe;
+ int ret;
+
+ sqe = io_uring_get_sqe(ring);
+ if (!sqe) {
+ fprintf(stderr, "get sqe failed\n");
+ goto err;
+ }
+
+ io_uring_prep_nop(sqe);
+ sqe->user_data = ++seq;
+ sqe->flags |= req_flags;
+
+ ret = io_uring_submit(ring);
+ if (ret <= 0) {
+ fprintf(stderr, "sqe submit failed: %d\n", ret);
+ goto err;
+ }
+
+ ret = io_uring_wait_cqe(ring, &cqe);
+ if (ret < 0) {
+ fprintf(stderr, "wait completion %d\n", ret);
+ goto err;
+ }
+ if (cqe->user_data != seq) {
+ fprintf(stderr, "Unexpected user_data: %ld\n", (long) cqe->user_data);
+ goto err;
+ }
+ io_uring_cqe_seen(ring, cqe);
+ return T_EXIT_PASS;
+err:
+ return T_EXIT_FAIL;
+}
+
+static int test_single_nvme_read(struct io_uring *ring, int fd)
+{
+ struct nvme_uring_cmd *cmd;
+ struct io_uring_cqe *cqe;
+ struct io_uring_sqe *sqe;
+ int ret;
+
+ unsigned len = 0x1000;
+ unsigned char buf[0x1000] = {};
+
+ sqe = io_uring_get_sqe128_mixed(ring);
+ if (!sqe) {
+ fprintf(stderr, "get sqe failed\n");
+ goto err;
+ }
+
+ sqe->fd = fd;
+ sqe->user_data = ++seq;
+ sqe->opcode = IORING_OP_URING_CMD;
+ sqe->cmd_op = NVME_URING_CMD_IO;
+
+ cmd = (struct nvme_uring_cmd *)sqe->cmd;
+ memset(cmd, 0, sizeof(struct nvme_uring_cmd));
+ cmd->opcode = nvme_cmd_read;
+ cmd->cdw12 = (len >> lba_shift) - 1;
+ cmd->addr = (__u64)(uintptr_t)buf;
+ cmd->data_len = len;
+ cmd->nsid = nsid;
+
+ ret = io_uring_submit(ring);
+ if (ret <= 0) {
+ fprintf(stderr, "sqe submit failed: %d\n", ret);
+ goto err;
+ }
+
+ ret = io_uring_wait_cqe(ring, &cqe);
+ if (ret < 0) {
+ fprintf(stderr, "wait completion %d\n", ret);
+ goto err;
+ }
+ if (cqe->res != 0) {
+ fprintf(stderr, "cqe res %d, wanted 0\n", cqe->res);
+ goto err;
+ }
+ if (cqe->user_data != seq) {
+ fprintf(stderr, "Unexpected user_data: %ld\n", (long) cqe->user_data);
+ goto err;
+ }
+
+ io_uring_cqe_seen(ring, cqe);
+ return T_EXIT_PASS;
+err:
+ return T_EXIT_FAIL;
+}
+
+static int test_io(const char *file)
+{
+ struct io_uring_params p = { .flags = IORING_SETUP_SQE_MIXED };
+ struct io_uring ring;
+ int fd, ret, i;
+
+ fd = open(file, O_RDONLY);
+ if (fd < 0) {
+ if (errno == EACCES || errno == EPERM)
+ return T_EXIT_SKIP;
+ perror("file open");
+ goto err;
+ }
+
+ ret = io_uring_queue_init_params(8, &ring, &p);
+ if (ret) {
+ if (ret == -EINVAL)
+ return T_EXIT_SKIP;
+ fprintf(stderr, "ring setup failed: %d\n", ret);
+ goto close;
+ }
+
+ for (i = 0; i < 32; i++) {
+ if (i & 2)
+ ret = test_single_nvme_read(&ring, fd);
+ else
+ ret = test_single_nop(&ring, 0);
+
+ if (ret) {
+ fprintf(stderr, "test_single_nop failed\n");
+ goto exit;
+ }
+ }
+
+ io_uring_queue_exit(&ring);
+ return T_EXIT_PASS;
+exit:
+ io_uring_queue_exit(&ring);
+close:
+ close(fd);
+err:
+ return T_EXIT_FAIL;
+}
+
+int main(int argc, char *argv[])
+{
+ int ret;
+
+ if (argc < 2)
+ return T_EXIT_SKIP;
+
+ ret = nvme_get_info(argv[1]);
+ if (ret)
+ return T_EXIT_SKIP;
+
+ return test_io(argv[1]);
+}
--
2.47.3
prev parent reply other threads:[~2025-09-04 19:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 19:27 [RFC PATCHv2 0/1] Keith Busch
2025-09-04 19:27 ` [RFC PATCHv2 1/3] Add support IORING_SETUP_SQE_MIXED Keith Busch
2025-09-11 16:27 ` Caleb Sander Mateos
2025-09-04 19:27 ` [RFC PATCHv2 1/1] io_uring: add support for IORING_SETUP_SQE_MIXED Keith Busch
2025-09-10 17:44 ` Caleb Sander Mateos
2025-09-11 0:28 ` Jens Axboe
2025-09-11 2:11 ` Ming Lei
2025-09-11 2:19 ` Ming Lei
2025-09-11 13:02 ` Keith Busch
2025-09-11 13:07 ` Ming Lei
2025-09-17 14:44 ` Jens Axboe
2025-09-18 21:22 ` Keith Busch
2025-09-18 23:35 ` Jens Axboe
2025-09-11 2:06 ` Keith Busch
2025-09-04 19:27 ` [RFC PATCHv2 2/3] Add nop testing " Keith Busch
2025-09-04 19:27 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904192716.3064736-5-kbusch@meta.com \
--to=kbusch@meta.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
--cc=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox