From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31704130A73; Sat, 6 Sep 2025 11:27:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757158028; cv=none; b=GfXtjWf6jvFdGtPvj17uyXmaqY/hRSN2elEfY/4aZiwfwmIEIAM1PThhjuvZEmEpeA3QocH5UfcjBEuaLSfgGWx8G0UT+7aYqk13bpcBp8Wdjn/tW4F7ZBJFV43WA0XbLrN/PFyxxw4aNT2SdW8OInQoHmCR4E+0ls3KWyLZpAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757158028; c=relaxed/simple; bh=7zX4TNEVYNMqJvz5CRJPzq4tSr5NNVK4tEormnQdmjo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RfnuLLKCLFnfvopeNIVQ0n2tcdNLjEgDzw2eGJKE6ERGGzgsUCWIG4EXJgC/jJgv1q1UcBqH7aZTaARUgZMoFcEoJIX8WJfDy/jXJq0SOXlgLAV4cK2G42wJ2C0YZkzfI8tClB9voSbS8WHMhhyMv/aBQNN0NcyL9MSCSgX/D/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CYAa3jge; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CYAa3jge" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54129C4CEE7; Sat, 6 Sep 2025 11:27:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1757158027; bh=7zX4TNEVYNMqJvz5CRJPzq4tSr5NNVK4tEormnQdmjo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CYAa3jgeOCLG8gO+q/JrWJXlNNsRaiLNLZHkzif5CG2Q1Wvz2hSvFZ3jApqE6bVuL 3aQClOis6aPUbGzgP6B9nMd2aDas9UPd7JeiIvnu5s51lNKbU35CGBtgqzQwVEZyy1 BO4PWHiKrz5oUw2H8Gc6/zH81etOZS4JrVIgYiI8= Date: Sat, 6 Sep 2025 13:27:04 +0200 From: Greg KH To: Konstantin Ryabitsev Cc: Linus Torvalds , Jens Axboe , Caleb Sander Mateos , io-uring , workflows@vger.kernel.org Subject: Re: Link trailers revisited (was Re: [GIT PULL] io_uring fix for 6.17-rc5) Message-ID: <2025090614-busily-upright-444d@gregkh> References: <9ef87524-d15c-4b2c-9f86-00417dad9c48@kernel.dk> <20250905-lovely-prehistoric-goldfish-04e1c3@lemur> <20250905-sparkling-stalwart-galago-8a87e0@lemur> Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250905-sparkling-stalwart-galago-8a87e0@lemur> On Fri, Sep 05, 2025 at 03:33:14PM -0400, Konstantin Ryabitsev wrote: > (Changing the subject and aiming this at workflows.) > > On Fri, Sep 05, 2025 at 11:06:01AM -0700, Linus Torvalds wrote: > > On Fri, 5 Sept 2025 at 10:45, Konstantin Ryabitsev > > wrote: > > > > > > Do you just want this to become a no-op, or will it be better if it's used > > > only with the patch.msgid.link domain namespace to clearly indicate that it's > > > just a provenance link? > > > > So I wish it at least had some way to discourage the normal mindless > > use - and in a perfect world that there was some more useful model for > > adding links automatically. > > > > For example, I feel like for the cover letter of a multi-commit > > series, the link to the patch series submission is potentially more > > useful - and likely much less annoying - because it would go into the > > merge message, not individual commits. > > We do support this usage using `b4 shazam -M` -- it's the functional > equivalent of applying a pull request and will use the cover letter contents > as the initial source of the merge commit message. I do encourage people to > use this more than just a linear `git am` for series, for a number of reasons: > > - this clearly delineates the start and end of the series > - this incorporates the contents cover letter that can give more info about > the series than just individual commits *without* the need to hit the lore > archive > - this lets maintainers record any additional thoughts they may have in the > merge commit, alongside with the original cover letter > > Obviously, we don't want to use the cover letter as-is, which is why b4 will > open the configured editor to let the maintainer pulling in the series make > any changes to the cover letter before it becomes the merge commit. I like this a lot, and just tried it, but it ends up applying the patches from the list without my signed-off-by, which will cause linux-next to complain when it sees that I committed patches without that. Did I miss an option to `b4 shazam`? Does it need to add a -s option like `b4 am` has? thanks, greg k-h