From: Yang Xiuwei <yangxiuwei2025@163.com>
To: axboe@kernel.dk
Cc: io-uring@vger.kernel.org, Yang Xiuwei <yangxiuwei@kylinos.cn>
Subject: [PATCH] io_uring: fix incorrect io_kiocb reference in io_link_skb
Date: Fri, 19 Sep 2025 17:03:52 +0800 [thread overview]
Message-ID: <20250919090352.2725950-1-yangxiuwei2025@163.com> (raw)
From: Yang Xiuwei <yangxiuwei@kylinos.cn>
In io_link_skb function, there is a bug where prev_notif is incorrectly
assigned using 'nd' instead of 'prev_nd'. This causes the context
validation check to compare the current notification with itself instead
of comparing it with the previous notification.
Fix by using the correct prev_nd parameter when obtaining prev_notif.
Signed-off-by: Yang Xiuwei <yangxiuwei@kylinos.cn>
diff --git a/io_uring/notif.c b/io_uring/notif.c
index 9a6f6e92d742..ea9c0116cec2 100644
--- a/io_uring/notif.c
+++ b/io_uring/notif.c
@@ -85,7 +85,7 @@ static int io_link_skb(struct sk_buff *skb, struct ubuf_info *uarg)
return -EEXIST;
prev_nd = container_of(prev_uarg, struct io_notif_data, uarg);
- prev_notif = cmd_to_io_kiocb(nd);
+ prev_notif = cmd_to_io_kiocb(prev_nd);
/* make sure all noifications can be finished in the same task_work */
if (unlikely(notif->ctx != prev_notif->ctx ||
--
2.25.1
next reply other threads:[~2025-09-19 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 9:03 Yang Xiuwei [this message]
2025-09-19 11:18 ` [PATCH] io_uring: fix incorrect io_kiocb reference in io_link_skb Pavel Begunkov
[not found] ` <CAAZOf24YaETroWiDjmTxu=2b2KVTxA1+rq_p5uxqtJqTVBfsJw@mail.gmail.com>
2025-09-19 11:25 ` David Kahurani
2025-09-19 14:16 ` Pavel Begunkov
2025-09-19 14:28 ` David Kahurani
2025-09-22 7:52 ` Pavel Begunkov
2025-09-22 8:17 ` David Kahurani
2025-09-19 13:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250919090352.2725950-1-yangxiuwei2025@163.com \
--to=yangxiuwei2025@163.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=yangxiuwei@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox