From: Christoph Hellwig <hch@lst.de>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>, Miklos Szeredi <miklos@szeredi.hu>,
Ming Lei <ming.lei@redhat.com>, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] io_uring/uring_cmd: avoid double indirect call in task work dispatch
Date: Mon, 27 Oct 2025 08:51:42 +0100 [thread overview]
Message-ID: <20251027075142.GA14661@lst.de> (raw)
In-Reply-To: <20251027020302.822544-5-csander@purestorage.com>
> +static void blk_cmd_complete(struct io_tw_req tw_req, io_tw_token_t tw)
> {
> + unsigned int issue_flags = IO_URING_CMD_TASK_WORK_ISSUE_FLAGS;
In most of these ioctl handlers issue_flags only has a single user,
so you might as well pass it directly.
In fact asm most external callers of io_uring_cmd_done pass that, would
a helper that just harcodes it make sense and then maybe switch the
special cases to use __io_uring_cmd_done directly?
next prev parent reply other threads:[~2025-10-27 7:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 2:02 [PATCH v3 0/4] io_uring/uring_cmd: avoid double indirect call in task work dispatch Caleb Sander Mateos
2025-10-27 2:02 ` [PATCH v3 1/4] io_uring: expose io_should_terminate_tw() Caleb Sander Mateos
2025-10-27 2:03 ` [PATCH v3 2/4] io_uring/uring_cmd: call io_should_terminate_tw() when needed Caleb Sander Mateos
2025-10-27 2:03 ` [PATCH v3 3/4] io_uring: add wrapper type for io_req_tw_func_t arg Caleb Sander Mateos
2025-10-27 2:03 ` [PATCH v3 4/4] io_uring/uring_cmd: avoid double indirect call in task work dispatch Caleb Sander Mateos
2025-10-27 7:51 ` Christoph Hellwig [this message]
2025-10-31 18:29 ` Caleb Sander Mateos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027075142.GA14661@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=csander@purestorage.com \
--cc=dsterba@suse.com \
--cc=io-uring@vger.kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=miklos@szeredi.hu \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox