public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	David Sterba <dsterba@suse.com>, Jan Kara <jack@suse.cz>,
	Mike Marshall <hubcap@omnibond.com>,
	Martin Brandenburg <martin@omnibond.com>,
	Carlos Maiolino <cem@kernel.org>, Stefan Roesch <shr@fb.com>,
	Jeff Layton <jlayton@kernel.org>,
	linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	gfs2@lists.linux.dev, io-uring@vger.kernel.org,
	devel@lists.orangefs.org, linux-unionfs@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-xfs@vger.kernel.org,
	linux-nfs@vger.kernel.org
Subject: [PATCH 04/14] btrfs: use vfs_utimes to update file timestamps
Date: Fri, 14 Nov 2025 07:26:07 +0100	[thread overview]
Message-ID: <20251114062642.1524837-5-hch@lst.de> (raw)
In-Reply-To: <20251114062642.1524837-1-hch@lst.de>

Btrfs updates the device node timestamps for block device special files
when it stop using the device.

Commit 8f96a5bfa150 ("btrfs: update the bdev time directly when closing")
switch that update from the correct layering to directly call the
low-level helper on the bdev inode.  This is wrong and got fixed in
commit 54fde91f52f5 ("btrfs: update device path inode time instead of
bd_inode") by updating the file system inode instead of the bdev inode,
but this kept the incorrect bypassing of the VFS interfaces and file
system ->update_times method.  Fix this by using the propet vfs_utimes
interface.

Fixes: 8f96a5bfa150 ("btrfs: update the bdev time directly when closing")
Fixes: 54fde91f52f5 ("btrfs: update device path inode time instead of bd_inode")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/btrfs/volumes.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 2bec544d8ba3..259e8b0496df 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2002,14 +2002,11 @@ static int btrfs_add_dev_item(struct btrfs_trans_handle *trans,
 static void update_dev_time(const char *device_path)
 {
 	struct path path;
-	int ret;
 
-	ret = kern_path(device_path, LOOKUP_FOLLOW, &path);
-	if (ret)
-		return;
-
-	inode_update_time(d_inode(path.dentry), S_MTIME | S_CTIME | S_VERSION);
-	path_put(&path);
+	if (!kern_path(device_path, LOOKUP_FOLLOW, &path)) {
+		vfs_utimes(&path, NULL);
+		path_put(&path);
+	}
 }
 
 static int btrfs_rm_dev_item(struct btrfs_trans_handle *trans,
-- 
2.47.3


  parent reply	other threads:[~2025-11-14  6:27 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14  6:26 re-enable IOCB_NOWAIT writes to files Christoph Hellwig
2025-11-14  6:26 ` [PATCH 01/14] fs: refactor file timestamp update logic Christoph Hellwig
2025-11-17  6:32   ` Chaitanya Kulkarni
2025-11-24 11:51   ` Jan Kara
2025-11-14  6:26 ` [PATCH 02/14] fs: lift the FMODE_NOCMTIME check into file_update_time_flags Christoph Hellwig
2025-11-17  6:38   ` Chaitanya Kulkarni
2025-11-24 11:54   ` Jan Kara
2025-11-14  6:26 ` [PATCH 03/14] fs: export vfs_utimes Christoph Hellwig
2025-11-17  6:38   ` Chaitanya Kulkarni
2025-11-24 11:55   ` Jan Kara
2025-11-14  6:26 ` Christoph Hellwig [this message]
2025-11-14  6:26 ` [PATCH 05/14] fs: remove inode_update_time Christoph Hellwig
2025-11-17  6:59   ` Chaitanya Kulkarni
2025-11-19  6:25     ` Christoph Hellwig
2025-11-24 13:06   ` Jan Kara
2025-11-14  6:26 ` [PATCH 06/14] organgefs: use inode_update_timestamps directly Christoph Hellwig
2025-11-14 14:06   ` Jeff Layton
2025-11-14 15:26     ` Christoph Hellwig
2025-11-24 13:09   ` Jan Kara
2025-11-14  6:26 ` [PATCH 07/14] fs: return a negative error from generic_update_time Christoph Hellwig
2025-11-17  7:07   ` Chaitanya Kulkarni
2025-11-24 13:10   ` Jan Kara
2025-11-14  6:26 ` [PATCH 08/14] fs: exit early in generic_update_time when there is no work Christoph Hellwig
2025-11-24 13:11   ` Jan Kara
2025-11-14  6:26 ` [PATCH 09/14] fs: factor out a mark_inode_dirty_time helper Christoph Hellwig
2025-11-17  7:13   ` Chaitanya Kulkarni
2025-11-24 13:22   ` Jan Kara
2025-11-24 14:07     ` Christoph Hellwig
2025-11-14  6:26 ` [PATCH 10/14] fs: factor out a sync_lazytime helper Christoph Hellwig
2025-11-17  7:38   ` Chaitanya Kulkarni
2025-11-19  6:28     ` Christoph Hellwig
2025-11-24 13:31   ` Jan Kara
2025-11-24 14:09     ` Christoph Hellwig
2025-11-24 17:36       ` Jan Kara
2025-11-14  6:26 ` [PATCH 11/14] fs: add a ->sync_lazytime method Christoph Hellwig
2025-11-17  7:50   ` Chaitanya Kulkarni
2025-11-14  6:26 ` [PATCH 12/14] fs: add support for non-blocking timestamp updates Christoph Hellwig
2025-11-14  6:26 ` [PATCH 13/14] xfs: implement ->sync_lazytime Christoph Hellwig
2025-11-14  6:26 ` [PATCH 14/14] xfs: enable non-blocking timestamp updates Christoph Hellwig
2025-11-14 15:30   ` Christoph Hellwig
2025-11-16  8:23   ` Dave Chinner
2025-11-19  7:29     ` Christoph Hellwig
2025-11-14 14:04 ` re-enable IOCB_NOWAIT writes to files Jeff Layton
2025-11-14 15:28   ` Christoph Hellwig
2025-11-14 19:47     ` Jeff Layton
2025-11-14 17:01   ` Darrick J. Wong
2025-11-14 17:21     ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251114062642.1524837-5-hch@lst.de \
    --to=hch@lst.de \
    --cc=brauner@kernel.org \
    --cc=cem@kernel.org \
    --cc=devel@lists.orangefs.org \
    --cc=dsterba@suse.com \
    --cc=gfs2@lists.linux.dev \
    --cc=hubcap@omnibond.com \
    --cc=io-uring@vger.kernel.org \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=martin@omnibond.com \
    --cc=shr@fb.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox