public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] io_uring/kbuf: remove obsolete buf_nr_pages and update comments
@ 2025-11-20 19:15 Joanne Koong
  2025-11-20 20:23 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Joanne Koong @ 2025-11-20 19:15 UTC (permalink / raw)
  To: axboe; +Cc: asml.silence, io-uring

The buf_nr_pages field in io_buffer_list was previously used to
determine whether the buffer list uses ring-provided buffers or classic
provided buffers. This is now determined by checking the IOBL_BUF_RING
flag.

Remove the buf_nr_pages field and update related comments.

Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
---
 include/linux/io_uring_types.h | 4 ++--
 io_uring/kbuf.h                | 5 ++---
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/include/linux/io_uring_types.h b/include/linux/io_uring_types.h
index c2ea6280901d..e3aa54239a21 100644
--- a/include/linux/io_uring_types.h
+++ b/include/linux/io_uring_types.h
@@ -328,8 +328,8 @@ struct io_ring_ctx {
 
 		/*
 		 * Modifications are protected by ->uring_lock and ->mmap_lock.
-		 * The flags, buf_pages and buf_nr_pages fields should be stable
-		 * once published.
+		 * The buffer list's io mapped region should be stable once
+		 * published.
 		 */
 		struct xarray		io_bl_xa;
 
diff --git a/io_uring/kbuf.h b/io_uring/kbuf.h
index ada382ff38d7..bf15e26520d3 100644
--- a/io_uring/kbuf.h
+++ b/io_uring/kbuf.h
@@ -14,8 +14,8 @@ enum {
 
 struct io_buffer_list {
 	/*
-	 * If ->buf_nr_pages is set, then buf_pages/buf_ring are used. If not,
-	 * then these are classic provided buffers and ->buf_list is used.
+	 * If the IOBL_BUF_RING flag is set, then buf_ring is used. If not, then
+	 * these are classic provided buffers and ->buf_list is used.
 	 */
 	union {
 		struct list_head buf_list;
@@ -27,7 +27,6 @@ struct io_buffer_list {
 	__u16 bgid;
 
 	/* below is for ring provided buffers */
-	__u16 buf_nr_pages;
 	__u16 nr_entries;
 	__u16 head;
 	__u16 mask;
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] io_uring/kbuf: remove obsolete buf_nr_pages and update comments
  2025-11-20 19:15 [PATCH v1] io_uring/kbuf: remove obsolete buf_nr_pages and update comments Joanne Koong
@ 2025-11-20 20:23 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2025-11-20 20:23 UTC (permalink / raw)
  To: Joanne Koong; +Cc: asml.silence, io-uring


On Thu, 20 Nov 2025 11:15:56 -0800, Joanne Koong wrote:
> The buf_nr_pages field in io_buffer_list was previously used to
> determine whether the buffer list uses ring-provided buffers or classic
> provided buffers. This is now determined by checking the IOBL_BUF_RING
> flag.
> 
> Remove the buf_nr_pages field and update related comments.
> 
> [...]

Applied, thanks!

[1/1] io_uring/kbuf: remove obsolete buf_nr_pages and update comments
      commit: 84692a1519b32d61ff882cf24a9eda900961acad

Best regards,
-- 
Jens Axboe




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-20 20:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-20 19:15 [PATCH v1] io_uring/kbuf: remove obsolete buf_nr_pages and update comments Joanne Koong
2025-11-20 20:23 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox