public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] io_uring/trace: rename io_uring_queue_async_work event "rw" field
@ 2025-12-02 18:21 Caleb Sander Mateos
  2025-12-03 14:53 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Caleb Sander Mateos @ 2025-12-02 18:21 UTC (permalink / raw)
  To: Jens Axboe, Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers
  Cc: Caleb Sander Mateos, io-uring, linux-kernel, linux-trace-kernel

The io_uring_queue_async_work tracepoint event stores an int rw field
that represents whether the work item is hashed. Rename it to "hashed"
and change its type to bool to more accurately reflect its value.

Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
---
 include/trace/events/io_uring.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/include/trace/events/io_uring.h b/include/trace/events/io_uring.h
index 45d15460b495..34b31a855ea4 100644
--- a/include/trace/events/io_uring.h
+++ b/include/trace/events/io_uring.h
@@ -131,28 +131,28 @@ TRACE_EVENT(io_uring_file_get,
 
 /**
  * io_uring_queue_async_work - called before submitting a new async work
  *
  * @req:	pointer to a submitted request
- * @rw:		type of workqueue, hashed or normal
+ * @hashed:	whether async work is hashed
  *
  * Allows to trace asynchronous work submission.
  */
 TRACE_EVENT(io_uring_queue_async_work,
 
-	TP_PROTO(struct io_kiocb *req, int rw),
+	TP_PROTO(struct io_kiocb *req, bool hashed),
 
-	TP_ARGS(req, rw),
+	TP_ARGS(req, hashed),
 
 	TP_STRUCT__entry (
 		__field(  void *,			ctx		)
 		__field(  void *,			req		)
 		__field(  u64,				user_data	)
 		__field(  u8,				opcode		)
 		__field(  unsigned long long,		flags		)
 		__field(  struct io_wq_work *,		work		)
-		__field(  int,				rw		)
+		__field(  bool,				hashed		)
 
 		__string( op_str, io_uring_get_opcode(req->opcode)	)
 	),
 
 	TP_fast_assign(
@@ -160,19 +160,19 @@ TRACE_EVENT(io_uring_queue_async_work,
 		__entry->req		= req;
 		__entry->user_data	= req->cqe.user_data;
 		__entry->flags		= (__force unsigned long long) req->flags;
 		__entry->opcode		= req->opcode;
 		__entry->work		= &req->work;
-		__entry->rw		= rw;
+		__entry->hashed		= hashed;
 
 		__assign_str(op_str);
 	),
 
 	TP_printk("ring %p, request %p, user_data 0x%llx, opcode %s, flags 0x%llx, %s queue, work %p",
 		__entry->ctx, __entry->req, __entry->user_data,
 		__get_str(op_str), __entry->flags,
-		__entry->rw ? "hashed" : "normal", __entry->work)
+		__entry->hashed ? "hashed" : "normal", __entry->work)
 );
 
 /**
  * io_uring_defer - called when an io_uring request is deferred
  *
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] io_uring/trace: rename io_uring_queue_async_work event "rw" field
  2025-12-02 18:21 [PATCH] io_uring/trace: rename io_uring_queue_async_work event "rw" field Caleb Sander Mateos
@ 2025-12-03 14:53 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2025-12-03 14:53 UTC (permalink / raw)
  To: Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
	Caleb Sander Mateos
  Cc: io-uring, linux-kernel, linux-trace-kernel


On Tue, 02 Dec 2025 11:21:31 -0700, Caleb Sander Mateos wrote:
> The io_uring_queue_async_work tracepoint event stores an int rw field
> that represents whether the work item is hashed. Rename it to "hashed"
> and change its type to bool to more accurately reflect its value.
> 
> 

Applied, thanks!

[1/1] io_uring/trace: rename io_uring_queue_async_work event "rw" field
      commit: 4bab5940c31b5d8686c56fb3caafad83a5545a0d

Best regards,
-- 
Jens Axboe




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-03 14:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-02 18:21 [PATCH] io_uring/trace: rename io_uring_queue_async_work event "rw" field Caleb Sander Mateos
2025-12-03 14:53 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox