public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Xiaobing Li <xiaobing.li@samsung.com>,
	miklos@szeredi.hu, axboe@kernel.dk
Cc: oe-kbuild-all@lists.linux.dev, io-uring@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, bschubert@ddn.com,
	asml.silence@gmail.com, joannelkoong@gmail.com, dw@davidwei.uk,
	josef@toxicpanda.com, kbusch@kernel.org, peiwei.li@samsung.com,
	joshi.k@samsung.com, Xiaobing Li <xiaobing.li@samsung.com>
Subject: Re: [PATCH] fuse: add zero-copy to fuse-over-io_uring
Date: Fri, 5 Dec 2025 06:37:10 +0800	[thread overview]
Message-ID: <202512050506.gwZpnWio-lkp@intel.com> (raw)
In-Reply-To: <20251204082536.17349-1-xiaobing.li@samsung.com>

Hi Xiaobing,

kernel test robot noticed the following build warnings:

[auto build test WARNING on mszeredi-fuse/for-next]
[also build test WARNING on linus/master v6.18 next-20251204]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Xiaobing-Li/fuse-add-zero-copy-to-fuse-over-io_uring/20251204-165924
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-next
patch link:    https://lore.kernel.org/r/20251204082536.17349-1-xiaobing.li%40samsung.com
patch subject: [PATCH] fuse: add zero-copy to fuse-over-io_uring
config: um-randconfig-r052-20251205 (https://download.01.org/0day-ci/archive/20251205/202512050506.gwZpnWio-lkp@intel.com/config)
compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251205/202512050506.gwZpnWio-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512050506.gwZpnWio-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from fs/fuse/dev_uring.c:8:
   fs/fuse/dev_uring_i.h:43:25: error: field 'payload_iter' has incomplete type
      43 |         struct iov_iter payload_iter;
         |                         ^~~~~~~~~~~~
   fs/fuse/dev_uring.c: In function 'fuse_uring_create_ring_ent':
>> fs/fuse/dev_uring.c:1086:49: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    1086 |                 err = io_uring_cmd_import_fixed((u64)ent->payload, payload_size, ITER_DEST,
         |                                                 ^


vim +1086 fs/fuse/dev_uring.c

  1042	
  1043	static struct fuse_ring_ent *
  1044	fuse_uring_create_ring_ent(struct io_uring_cmd *cmd,
  1045				   struct fuse_ring_queue *queue)
  1046	{
  1047		struct fuse_ring *ring = queue->ring;
  1048		struct fuse_ring_ent *ent;
  1049		size_t payload_size;
  1050		struct iovec iov[FUSE_URING_IOV_SEGS];
  1051		int err;
  1052	
  1053		err = fuse_uring_get_iovec_from_sqe(cmd->sqe, iov);
  1054		if (err) {
  1055			pr_info_ratelimited("Failed to get iovec from sqe, err=%d\n",
  1056					    err);
  1057			return ERR_PTR(err);
  1058		}
  1059	
  1060		err = -EINVAL;
  1061		if (iov[0].iov_len < sizeof(struct fuse_uring_req_header)) {
  1062			pr_info_ratelimited("Invalid header len %zu\n", iov[0].iov_len);
  1063			return ERR_PTR(err);
  1064		}
  1065	
  1066		payload_size = iov[1].iov_len;
  1067		if (payload_size < ring->max_payload_sz) {
  1068			pr_info_ratelimited("Invalid req payload len %zu\n",
  1069					    payload_size);
  1070			return ERR_PTR(err);
  1071		}
  1072	
  1073		err = -ENOMEM;
  1074		ent = kzalloc(sizeof(*ent), GFP_KERNEL_ACCOUNT);
  1075		if (!ent)
  1076			return ERR_PTR(err);
  1077	
  1078		INIT_LIST_HEAD(&ent->list);
  1079	
  1080		ent->queue = queue;
  1081		ent->headers = iov[0].iov_base;
  1082		ent->payload = iov[1].iov_base;
  1083	
  1084		if (READ_ONCE(cmd->sqe->uring_cmd_flags) & IORING_URING_CMD_FIXED) {
  1085			ent->zero_copy = true;
> 1086			err = io_uring_cmd_import_fixed((u64)ent->payload, payload_size, ITER_DEST,
  1087							&ent->payload_iter, cmd, 0);
  1088	
  1089			if (err) {
  1090				kfree(ent);
  1091				return ERR_PTR(err);
  1092			}
  1093		}
  1094	
  1095		atomic_inc(&ring->queue_refs);
  1096		return ent;
  1097	}
  1098	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2025-12-04 22:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20251204083010epcas5p2735e829064ff592b67e88c41fb1e44b3@epcas5p2.samsung.com>
2025-12-04  8:25 ` [PATCH] fuse: add zero-copy to fuse-over-io_uring Xiaobing Li
2025-12-04 22:37   ` kernel test robot [this message]
2025-12-05  0:26   ` Joanne Koong
2025-12-12 16:50   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202512050506.gwZpnWio-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=bschubert@ddn.com \
    --cc=dw@davidwei.uk \
    --cc=io-uring@vger.kernel.org \
    --cc=joannelkoong@gmail.com \
    --cc=josef@toxicpanda.com \
    --cc=joshi.k@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=peiwei.li@samsung.com \
    --cc=xiaobing.li@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox