public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: linux-fsdevel@vger.kernel.org
Cc: torvalds@linux-foundation.org, brauner@kernel.org, jack@suse.cz,
	mjguzik@gmail.com, paul@paul-moore.com, axboe@kernel.dk,
	audit@vger.kernel.org, io-uring@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [RFC PATCH v3 48/59] namei.c: convert getname_kernel() callers to CLASS(filename_kernel)
Date: Tue, 16 Dec 2025 03:55:07 +0000	[thread overview]
Message-ID: <20251216035518.4037331-49-viro@zeniv.linux.org.uk> (raw)
In-Reply-To: <20251216035518.4037331-1-viro@zeniv.linux.org.uk>

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 fs/namei.c | 36 ++++++++++--------------------------
 1 file changed, 10 insertions(+), 26 deletions(-)

diff --git a/fs/namei.c b/fs/namei.c
index 0221cdb92297..e0c8d3832861 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2996,7 +2996,7 @@ static struct dentry *__start_removing_path(int dfd, struct filename *name,
 struct dentry *kern_path_parent(const char *name, struct path *path)
 {
 	struct path parent_path __free(path_put) = {};
-	struct filename *filename __free(putname) = getname_kernel(name);
+	CLASS(filename_kernel, filename)(name);
 	struct dentry *d;
 	struct qstr last;
 	int type, error;
@@ -3017,11 +3017,8 @@ struct dentry *kern_path_parent(const char *name, struct path *path)
 
 struct dentry *start_removing_path(const char *name, struct path *path)
 {
-	struct filename *filename = getname_kernel(name);
-	struct dentry *res = __start_removing_path(AT_FDCWD, filename, path);
-
-	putname(filename);
-	return res;
+	CLASS(filename_kernel, filename)(name);
+	return __start_removing_path(AT_FDCWD, filename, path);
 }
 
 struct dentry *start_removing_user_path_at(int dfd,
@@ -3038,12 +3035,8 @@ EXPORT_SYMBOL(start_removing_user_path_at);
 
 int kern_path(const char *name, unsigned int flags, struct path *path)
 {
-	struct filename *filename = getname_kernel(name);
-	int ret = filename_lookup(AT_FDCWD, filename, flags, path, NULL);
-
-	putname(filename);
-	return ret;
-
+	CLASS(filename_kernel, filename)(name);
+	return filename_lookup(AT_FDCWD, filename, flags, path, NULL);
 }
 EXPORT_SYMBOL(kern_path);
 
@@ -3077,15 +3070,11 @@ int vfs_path_lookup(struct dentry *dentry, struct vfsmount *mnt,
 		    const char *name, unsigned int flags,
 		    struct path *path)
 {
-	struct filename *filename;
+	CLASS(filename_kernel, filename)(name);
 	struct path root = {.mnt = mnt, .dentry = dentry};
-	int ret;
 
-	filename = getname_kernel(name);
 	/* the first argument of filename_lookup() is ignored with root */
-	ret = filename_lookup(AT_FDCWD, filename, flags, path, &root);
-	putname(filename);
-	return ret;
+	return filename_lookup(AT_FDCWD, filename, flags, path, &root);
 }
 EXPORT_SYMBOL(vfs_path_lookup);
 
@@ -4882,13 +4871,12 @@ struct file *do_file_open_root(const struct path *root,
 {
 	struct nameidata nd;
 	struct file *file;
-	struct filename *filename;
 	int flags = op->lookup_flags;
 
 	if (d_is_symlink(root->dentry) && op->intent & LOOKUP_OPEN)
 		return ERR_PTR(-ELOOP);
 
-	filename = getname_kernel(name);
+	CLASS(filename_kernel, filename)(name);
 	if (IS_ERR(filename))
 		return ERR_CAST(filename);
 
@@ -4899,7 +4887,6 @@ struct file *do_file_open_root(const struct path *root,
 	if (unlikely(file == ERR_PTR(-ESTALE)))
 		file = path_openat(&nd, op, flags | LOOKUP_REVAL);
 	restore_nameidata();
-	putname(filename);
 	return file;
 }
 
@@ -4955,11 +4942,8 @@ static struct dentry *filename_create(int dfd, struct filename *name,
 struct dentry *start_creating_path(int dfd, const char *pathname,
 				   struct path *path, unsigned int lookup_flags)
 {
-	struct filename *filename = getname_kernel(pathname);
-	struct dentry *res = filename_create(dfd, filename, path, lookup_flags);
-
-	putname(filename);
-	return res;
+	CLASS(filename_kernel, filename)(pathname);
+	return filename_create(dfd, filename, path, lookup_flags);
 }
 EXPORT_SYMBOL(start_creating_path);
 
-- 
2.47.3


  parent reply	other threads:[~2025-12-16  4:10 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16  3:54 [RFC PATCH v3 00/59] struct filename work Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 01/59] do_faccessat(): import pathname only once Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 02/59] do_fchmodat(): " Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 03/59] do_fchownat(): " Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 04/59] do_utimes_path(): " Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 05/59] chdir(2): " Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 06/59] chroot(2): " Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 07/59] user_statfs(): " Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 08/59] do_sys_truncate(): " Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 09/59] do_readlinkat(): " Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 10/59] get rid of audit_reusename() Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 11/59] ntfs: ->d_compare() must not block Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 12/59] getname_flags() massage, part 1 Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 13/59] getname_flags() massage, part 2 Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 14/59] struct filename: use names_cachep only for getname() and friends Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 15/59] struct filename: saner handling of long names Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 16/59] fs: hide names_cache behind runtime const machinery Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 17/59] allow incomplete imports of filenames Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 18/59] struct filename ->refcnt doesn't need to be atomic Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 19/59] allow to use CLASS() for struct filename * Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 20/59] file_getattr(): filename_lookup() accepts ERR_PTR() as filename Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 21/59] file_setattr(): " Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 22/59] move_mount(): " Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 23/59] ksmbd_vfs_path_lookup(): vfs_path_parent_lookup() accepts ERR_PTR() as name Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 24/59] ksmbd_vfs_rename(): " Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 25/59] do_filp_open(): DTRT when getting ERR_PTR() as pathname Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 26/59] rename do_filp_open() to do_file_open() Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 27/59] do_sys_openat2(): get rid of useless check, switch to CLASS(filename) Al Viro
2025-12-16 20:08   ` Askar Safin
2025-12-16 20:29     ` Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 28/59] simplify the callers of file_open_name() Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 29/59] simplify the callers of do_open_execat() Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 30/59] simplify the callers of alloc_bprm() Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 31/59] switch {alloc,free}_bprm() to CLASS() Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 32/59] file_[gs]etattr(2): switch to CLASS(filename_maybe_null) Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 33/59] mount_setattr(2): don't mess with LOOKUP_EMPTY Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 34/59] do_open_execat(): don't care about LOOKUP_EMPTY Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 35/59] vfs_open_tree(): use CLASS(filename_uflags) Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 36/59] name_to_handle_at(): " Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 37/59] fspick(2): use CLASS(filename_flags) Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 38/59] do_fchownat(): unspaghettify a bit Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 39/59] chdir(2): " Al Viro
2025-12-16  3:54 ` [RFC PATCH v3 40/59] do_utimes_path(): switch to CLASS(filename_uflags) Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 41/59] do_sys_truncate(): switch to CLASS(filename) Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 42/59] do_readlinkat(): switch to CLASS(filename_flags) Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 43/59] do_f{chmod,chown,access}at(): use CLASS(filename_uflags) Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 44/59] io_openat2(): use CLASS(filename_complete_delayed) Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 45/59] io_statx(): " Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 46/59] do_{renameat2,linkat,symlinkat}(): use CLASS(filename_consume) Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 47/59] do_{mknodat,mkdirat,unlinkat,rmdir}(): " Al Viro
2025-12-16  3:55 ` Al Viro [this message]
2025-12-16  3:55 ` [RFC PATCH v3 49/59] namei.c: switch user pathname imports to CLASS(filename{,_flags}) Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 50/59] filename_...xattr(): don't consume filename reference Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 51/59] move_mount(2): switch to CLASS(filename_maybe_null) Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 52/59] chroot(2): switch to CLASS(filename) Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 53/59] quotactl_block(): " Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 54/59] statx: switch to CLASS(filename_maybe_null) Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 55/59] user_statfs(): switch to CLASS(filename) Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 56/59] mqueue: " Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 57/59] ksmbd: use CLASS(filename_kernel) Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 58/59] alpha: switch osf_mount() to strndup_user() Al Viro
2025-12-16  3:55 ` [RFC PATCH v3 59/59] sysfs(2): fs_index() argument is _not_ a pathname Al Viro
2025-12-16  4:32 ` [RFC PATCH v3 00/59] struct filename work Linus Torvalds
2025-12-16  5:23   ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251216035518.4037331-49-viro@zeniv.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=audit@vger.kernel.org \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=io-uring@vger.kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjguzik@gmail.com \
    --cc=paul@paul-moore.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox