public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	David Sterba <dsterba@suse.com>, Jan Kara <jack@suse.cz>,
	Mike Marshall <hubcap@omnibond.com>,
	Martin Brandenburg <martin@omnibond.com>,
	Carlos Maiolino <cem@kernel.org>, Stefan Roesch <shr@fb.com>,
	Jeff Layton <jlayton@kernel.org>,
	linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev,
	io-uring@vger.kernel.org, devel@lists.orangefs.org,
	linux-unionfs@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: re-enable IOCB_NOWAIT writes to files v3
Date: Wed, 17 Dec 2025 07:09:33 +0100	[thread overview]
Message-ID: <20251217061015.923954-1-hch@lst.de> (raw)

Hi all,

commit 66fa3cedf16a ("fs: Add async write file modification handling.")
effectively disabled IOCB_NOWAIT writes as timestamp updates currently
always require blocking, and the modern timestamp resolution means we
always update timestamps.  This leads to a lot of context switches from
applications using io_uring to submit file writes, making it often worse
than using the legacy aio code that is not using IOCB_NOWAIT.

This series allows non-blocking updates for lazytime if the file system
supports it, and adds that support for XFS.

Changes since v2:
 - drop patches merged upstream
 - adjust for the inode state accesors
 - keep a check in __writeback_single_inode instead of exercising
   potentially undefined behavior
 - more spelling fixes

Changes since v1:
 - more regular numbering of the S_* flags
 - fix XFS to actually not block
 - don't ignore the generic_update_time return value in
   file_update_time_flags
 - fix the sync_lazytime return value
 - fix an out of data comment in btrfs
 - fix a race that would update i_version before returning -EAGAIN in XFS

Diffstat:
 Documentation/filesystems/locking.rst |    2 
 Documentation/filesystems/vfs.rst     |    6 ++
 fs/btrfs/inode.c                      |   11 +++-
 fs/fat/misc.c                         |    3 +
 fs/fs-writeback.c                     |   52 ++++++++++++++++---
 fs/gfs2/inode.c                       |    6 +-
 fs/inode.c                            |   89 +++++++++++++++++++---------------
 fs/internal.h                         |    3 -
 fs/nfs/inode.c                        |    4 -
 fs/orangefs/inode.c                   |    8 ++-
 fs/overlayfs/inode.c                  |    3 +
 fs/sync.c                             |    4 -
 fs/ubifs/file.c                       |   11 ++--
 fs/xfs/xfs_iops.c                     |   35 ++++++++++++-
 fs/xfs/xfs_super.c                    |   29 -----------
 include/linux/fs.h                    |   19 ++++---
 include/trace/events/writeback.h      |    6 --
 17 files changed, 182 insertions(+), 109 deletions(-)

             reply	other threads:[~2025-12-17  6:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-17  6:09 Christoph Hellwig [this message]
2025-12-17  6:09 ` [PATCH 01/10] fs: remove inode_update_time Christoph Hellwig
2025-12-17  6:09 ` [PATCH 02/10] fs: allow error returns from generic_update_time Christoph Hellwig
2025-12-17  6:09 ` [PATCH 03/10] fs: exit early in generic_update_time when there is no work Christoph Hellwig
2025-12-17  6:09 ` [PATCH 04/10] fs: factor out a mark_inode_dirty_time helper Christoph Hellwig
2025-12-17  6:09 ` [PATCH 05/10] fs: allow error returns from inode_update_timestamps Christoph Hellwig
2025-12-17 12:23   ` Jan Kara
2025-12-17  6:09 ` [PATCH 06/10] fs: factor out a sync_lazytime helper Christoph Hellwig
2025-12-17 12:26   ` Jan Kara
2025-12-17  6:09 ` [PATCH 07/10] fs: add a ->sync_lazytime method Christoph Hellwig
2025-12-17 12:30   ` Jan Kara
2025-12-18  6:13     ` Christoph Hellwig
2025-12-17  6:09 ` [PATCH 08/10] fs: add support for non-blocking timestamp updates Christoph Hellwig
2025-12-17 12:42   ` Jan Kara
2025-12-18  6:19     ` Christoph Hellwig
2025-12-19 15:12       ` Jan Kara
2025-12-22 23:41         ` Christoph Hellwig
2025-12-17  6:09 ` [PATCH 09/10] xfs: implement ->sync_lazytime Christoph Hellwig
2025-12-17  6:09 ` [PATCH 10/10] xfs: enable non-blocking timestamp updates Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251217061015.923954-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=brauner@kernel.org \
    --cc=cem@kernel.org \
    --cc=devel@lists.orangefs.org \
    --cc=dsterba@suse.com \
    --cc=gfs2@lists.linux.dev \
    --cc=hubcap@omnibond.com \
    --cc=io-uring@vger.kernel.org \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=martin@omnibond.com \
    --cc=shr@fb.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox