From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>,
Christian Brauner <brauner@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
David Sterba <dsterba@suse.com>,
Mike Marshall <hubcap@omnibond.com>,
Martin Brandenburg <martin@omnibond.com>,
Carlos Maiolino <cem@kernel.org>, Stefan Roesch <shr@fb.com>,
Jeff Layton <jlayton@kernel.org>,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev,
io-uring@vger.kernel.org, devel@lists.orangefs.org,
linux-unionfs@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 07/10] fs: add a ->sync_lazytime method
Date: Thu, 18 Dec 2025 07:13:17 +0100 [thread overview]
Message-ID: <20251218061317.GA2775@lst.de> (raw)
In-Reply-To: <ghtgokkzdo7owrkfkpittqlc6xvjhr5w4eprbq5gcszqpmy7z3@7m3ecvlqfrzu>
On Wed, Dec 17, 2025 at 01:30:18PM +0100, Jan Kara wrote:
> > if (flags & I_DIRTY_INODE) {
> > + bool was_dirty_time =
> > + inode_state_read_once(inode) & I_DIRTY_TIME;
> > +
> > /*
> > * Inode timestamp update will piggback on this dirtying.
> > * We tell ->dirty_inode callback that timestamps need to
> > * be updated by setting I_DIRTY_TIME in flags.
> > */
> > - if (inode_state_read_once(inode) & I_DIRTY_TIME) {
> > + if (was_dirty_time) {
> > spin_lock(&inode->i_lock);
> > if (inode_state_read(inode) & I_DIRTY_TIME) {
> > inode_state_clear(inode, I_DIRTY_TIME);
> > flags |= I_DIRTY_TIME;
> > + was_dirty_time = true;
>
> This looks bogus. was_dirty_time is already true here. What I think you
> wanted here is to set it to false if locked I_DIRTY_TIME check failed.
> Otherwise the patch looks good.
Or better set it to false at initialization time and only set it to
true here to simply things a bit. But otherwise: yes.
next prev parent reply other threads:[~2025-12-18 6:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 6:09 re-enable IOCB_NOWAIT writes to files v3 Christoph Hellwig
2025-12-17 6:09 ` [PATCH 01/10] fs: remove inode_update_time Christoph Hellwig
2025-12-17 6:09 ` [PATCH 02/10] fs: allow error returns from generic_update_time Christoph Hellwig
2025-12-17 6:09 ` [PATCH 03/10] fs: exit early in generic_update_time when there is no work Christoph Hellwig
2025-12-17 6:09 ` [PATCH 04/10] fs: factor out a mark_inode_dirty_time helper Christoph Hellwig
2025-12-17 6:09 ` [PATCH 05/10] fs: allow error returns from inode_update_timestamps Christoph Hellwig
2025-12-17 12:23 ` Jan Kara
2025-12-17 6:09 ` [PATCH 06/10] fs: factor out a sync_lazytime helper Christoph Hellwig
2025-12-17 12:26 ` Jan Kara
2025-12-17 6:09 ` [PATCH 07/10] fs: add a ->sync_lazytime method Christoph Hellwig
2025-12-17 12:30 ` Jan Kara
2025-12-18 6:13 ` Christoph Hellwig [this message]
2025-12-17 6:09 ` [PATCH 08/10] fs: add support for non-blocking timestamp updates Christoph Hellwig
2025-12-17 12:42 ` Jan Kara
2025-12-18 6:19 ` Christoph Hellwig
2025-12-19 15:12 ` Jan Kara
2025-12-22 23:41 ` Christoph Hellwig
2025-12-17 6:09 ` [PATCH 09/10] xfs: implement ->sync_lazytime Christoph Hellwig
2025-12-17 6:09 ` [PATCH 10/10] xfs: enable non-blocking timestamp updates Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251218061317.GA2775@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=devel@lists.orangefs.org \
--cc=dsterba@suse.com \
--cc=gfs2@lists.linux.dev \
--cc=hubcap@omnibond.com \
--cc=io-uring@vger.kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin@omnibond.com \
--cc=shr@fb.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox