From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Cc: io-uring@vger.kernel.org,
Caleb Sander Mateos <csander@purestorage.com>,
huang-jl <huang-jl@deepseek.com>,
Nitesh Shetty <nj.shetty@samsung.com>,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH 3/3] io_uring: don't re-calculate iov_iter nr_segs in io_import_kbuf()
Date: Thu, 18 Dec 2025 17:31:44 +0800 [thread overview]
Message-ID: <20251218093146.1218279-4-ming.lei@redhat.com> (raw)
In-Reply-To: <20251218093146.1218279-1-ming.lei@redhat.com>
We have provide correct byte counts to iov_iter, and it is enough to
cap the iteration, not necessary to re-calculate exact nr_segs.
Especially the previous two patches avoid to use bio->bi_vcnt as
split hint, and don't use iov_iter->nr_segs to initialize bio->bi_vcnt.
The iov_iter nr_segs re-calculation[1] is added for avoiding unnecessary
bio split, which is fixed now by the previous two patches.
[1] https://lkml.org/lkml/2025/4/16/351
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
io_uring/rsrc.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c
index a63474b331bf..ee6283676ba7 100644
--- a/io_uring/rsrc.c
+++ b/io_uring/rsrc.c
@@ -1055,16 +1055,6 @@ static int io_import_kbuf(int ddir, struct iov_iter *iter,
iov_iter_bvec(iter, ddir, imu->bvec, imu->nr_bvecs, count);
iov_iter_advance(iter, offset);
-
- if (count < imu->len) {
- const struct bio_vec *bvec = iter->bvec;
-
- while (len > bvec->bv_len) {
- len -= bvec->bv_len;
- bvec++;
- }
- iter->nr_segs = 1 + bvec - iter->bvec;
- }
return 0;
}
--
2.47.0
prev parent reply other threads:[~2025-12-18 9:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 9:31 [PATCH 0/3] block: fix bi_vcnt misuse for cloned bio Ming Lei
2025-12-18 9:31 ` [PATCH 1/3] block: fix bio_may_need_split() by using bvec iterator way Ming Lei
2025-12-18 9:37 ` Christoph Hellwig
2025-12-18 9:45 ` Ming Lei
2025-12-18 15:16 ` Nitesh Shetty
2025-12-18 16:08 ` Ming Lei
2025-12-20 8:16 ` Nitesh Shetty
2025-12-20 8:19 ` Nitesh Shetty
2025-12-18 9:31 ` [PATCH 2/3] block: don't initialize bi_vcnt for cloned bio in bio_iov_bvec_set() Ming Lei
2025-12-18 9:38 ` Christoph Hellwig
2025-12-18 9:48 ` Ming Lei
2025-12-18 9:31 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251218093146.1218279-4-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=huang-jl@deepseek.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=nj.shetty@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox