public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	David Sterba <dsterba@suse.com>, Jan Kara <jack@suse.cz>,
	Mike Marshall <hubcap@omnibond.com>,
	Martin Brandenburg <martin@omnibond.com>,
	Carlos Maiolino <cem@kernel.org>, Stefan Roesch <shr@fb.com>,
	Jeff Layton <jlayton@kernel.org>,
	linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev,
	io-uring@vger.kernel.org, devel@lists.orangefs.org,
	linux-unionfs@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH 03/11] fs: exit early in generic_update_time when there is no work
Date: Tue, 23 Dec 2025 09:37:46 +0900	[thread overview]
Message-ID: <20251223003756.409543-4-hch@lst.de> (raw)
In-Reply-To: <20251223003756.409543-1-hch@lst.de>

Exit early if no attributes are to be updated, to avoid a spurious call
to __mark_inode_dirty which can turn into a fairly expensive no-op due to
the extra checks and locking.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
---
 fs/inode.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/inode.c b/fs/inode.c
index 7eb28dd45a5a..876641a6e478 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -2148,6 +2148,9 @@ int generic_update_time(struct inode *inode, int flags)
 	int updated = inode_update_timestamps(inode, flags);
 	int dirty_flags = 0;
 
+	if (!updated)
+		return 0;
+
 	if (updated & (S_ATIME|S_MTIME|S_CTIME))
 		dirty_flags = inode->i_sb->s_flags & SB_LAZYTIME ? I_DIRTY_TIME : I_DIRTY_SYNC;
 	if (updated & S_VERSION)
-- 
2.47.3


  parent reply	other threads:[~2025-12-23  0:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-23  0:37 re-enable IOCB_NOWAIT writes to files v4 Christoph Hellwig
2025-12-23  0:37 ` [PATCH 01/11] fs: remove inode_update_time Christoph Hellwig
2025-12-23  0:37 ` [PATCH 02/11] fs: allow error returns from generic_update_time Christoph Hellwig
2025-12-23  0:37 ` Christoph Hellwig [this message]
2025-12-23  5:33   ` [PATCH 03/11] fs: exit early in generic_update_time when there is no work Chaitanya Kulkarni
2025-12-23  0:37 ` [PATCH 04/11] fs: delay the actual timestamp updates in inode_update_timestamps Christoph Hellwig
2025-12-23  5:35   ` Chaitanya Kulkarni
2025-12-23  0:37 ` [PATCH 05/11] fs: return I_DIRTY_* and allow error returns from inode_update_timestamps Christoph Hellwig
2025-12-23  5:36   ` Chaitanya Kulkarni
2025-12-23  0:37 ` [PATCH 06/11] fs: factor out a sync_lazytime helper Christoph Hellwig
2025-12-23  5:36   ` Chaitanya Kulkarni
2025-12-23  0:37 ` [PATCH 07/11] fs: add a ->sync_lazytime method Christoph Hellwig
2025-12-23  5:37   ` Chaitanya Kulkarni
2025-12-23  0:37 ` [PATCH 08/11] fs: add support for non-blocking timestamp updates Christoph Hellwig
2025-12-23  5:38   ` Chaitanya Kulkarni
2025-12-23  0:37 ` [PATCH 09/11] fat: enable " Christoph Hellwig
2025-12-23  0:37 ` [PATCH 10/11] xfs: implement ->sync_lazytime Christoph Hellwig
2025-12-23  0:37 ` [PATCH 11/11] xfs: enable non-blocking timestamp updates Christoph Hellwig
2025-12-23  5:39   ` Chaitanya Kulkarni
2025-12-23 22:53 ` re-enable IOCB_NOWAIT writes to files v4 Christoph Hellwig
2025-12-24 13:11 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251223003756.409543-4-hch@lst.de \
    --to=hch@lst.de \
    --cc=brauner@kernel.org \
    --cc=cem@kernel.org \
    --cc=devel@lists.orangefs.org \
    --cc=dsterba@suse.com \
    --cc=gfs2@lists.linux.dev \
    --cc=hubcap@omnibond.com \
    --cc=io-uring@vger.kernel.org \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=martin@omnibond.com \
    --cc=shr@fb.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox