[PATCH] io_uring/memmap: drop unused sz param in io_uring_validate_mmap_request()

[PATCH] io_uring/memmap: drop unused sz param in io_uring_validate_mmap_request()

[Caleb Sander Mateos]

io_uring_validate_mmap_request() doesn't use its size_t sz argument, so
remove it.

Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
---
 io_uring/memmap.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/io_uring/memmap.c b/io_uring/memmap.c
index dc4bfc5b6fb8..cb9dfc411c3b 100644
--- a/io_uring/memmap.c
+++ b/io_uring/memmap.c
@@ -266,12 +266,11 @@ static void *io_region_validate_mmap(struct io_ring_ctx *ctx,
 		return ERR_PTR(-EINVAL);
 
 	return io_region_get_ptr(mr);
 }
 
-static void *io_uring_validate_mmap_request(struct file *file, loff_t pgoff,
-					    size_t sz)
+static void *io_uring_validate_mmap_request(struct file *file, loff_t pgoff)
 {
 	struct io_ring_ctx *ctx = file->private_data;
 	struct io_mapped_region *region;
 
 	region = io_mmap_get_region(ctx, pgoff);
@@ -302,11 +301,11 @@ __cold int io_uring_mmap(struct file *file, struct vm_area_struct *vma)
 	struct io_mapped_region *region;
 	void *ptr;
 
 	guard(mutex)(&ctx->mmap_lock);
 
-	ptr = io_uring_validate_mmap_request(file, vma->vm_pgoff, sz);
+	ptr = io_uring_validate_mmap_request(file, vma->vm_pgoff);
 	if (IS_ERR(ptr))
 		return PTR_ERR(ptr);
 
 	switch (offset & IORING_OFF_MMAP_MASK) {
 	case IORING_OFF_SQ_RING:
@@ -334,11 +333,11 @@ unsigned long io_uring_get_unmapped_area(struct file *filp, unsigned long addr,
 	if (addr)
 		return -EINVAL;
 
 	guard(mutex)(&ctx->mmap_lock);
 
-	ptr = io_uring_validate_mmap_request(filp, pgoff, len);
+	ptr = io_uring_validate_mmap_request(filp, pgoff);
 	if (IS_ERR(ptr))
 		return -ENOMEM;
 
 	/*
 	 * Some architectures have strong cache aliasing requirements.
@@ -384,11 +383,11 @@ unsigned long io_uring_get_unmapped_area(struct file *file, unsigned long addr,
 	struct io_ring_ctx *ctx = file->private_data;
 	void *ptr;
 
 	guard(mutex)(&ctx->mmap_lock);
 
-	ptr = io_uring_validate_mmap_request(file, pgoff, len);
+	ptr = io_uring_validate_mmap_request(file, pgoff);
 	if (IS_ERR(ptr))
 		return PTR_ERR(ptr);
 
 	return (unsigned long) ptr;
 }
-- 
2.45.2

Re: [PATCH] io_uring/memmap: drop unused sz param in io_uring_validate_mmap_request()

[Jens Axboe]

On Wed, 31 Dec 2025 11:19:06 -0700, Caleb Sander Mateos wrote:
> io_uring_validate_mmap_request() doesn't use its size_t sz argument, so
> remove it.
> 
> 

Applied, thanks!

[1/1] io_uring/memmap: drop unused sz param in io_uring_validate_mmap_request()
      commit: 70eafc743016b1df73e00fd726ffedd44ce1bdd3

Best regards,
-- 
Jens Axboe