From: Hillf Danton <hdanton@sina.com>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Joanne Koong <joannelkoong@gmail.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 0/3] io_uring: use release-acquire ordering for IORING_SETUP_R_DISABLED
Date: Thu, 8 Jan 2026 12:54:11 +0800 [thread overview]
Message-ID: <20260108045414.2028-1-hdanton@sina.com> (raw)
In-Reply-To: <20260105210543.3471082-1-csander@purestorage.com>
On Mon, 5 Jan 2026 14:05:39 -0700 Caleb Sander Mateos wrote:
> io_uring_enter(), __io_msg_ring_data(), and io_msg_send_fd() read
> ctx->flags and ctx->submitter_task without holding the ctx's uring_lock.
> This means they may race with the assignment to ctx->submitter_task and
> the clearing of IORING_SETUP_R_DISABLED from ctx->flags in
> io_register_enable_rings(). Ensure the correct ordering of the
> ctx->flags and ctx->submitter_task memory accesses by storing to
> ctx->flags using release ordering and loading it using acquire ordering.
>
Given no race is erased without locking, can you specify the observable effects
without enforced ordering?
next prev parent reply other threads:[~2026-01-08 4:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 21:05 [PATCH v7 0/3] io_uring: use release-acquire ordering for IORING_SETUP_R_DISABLED Caleb Sander Mateos
2026-01-05 21:05 ` [PATCH v7 1/3] " Caleb Sander Mateos
2026-01-05 21:05 ` [PATCH v7 2/3] io_uring/msg_ring: drop unnecessary submitter_task checks Caleb Sander Mateos
2026-01-08 4:25 ` Joanne Koong
2026-01-08 7:06 ` Caleb Sander Mateos
2026-01-08 22:04 ` Joanne Koong
2026-01-05 21:05 ` [PATCH v7 3/3] io_uring/register: drop io_register_enable_rings() submitter_task check Caleb Sander Mateos
2026-01-08 22:10 ` Joanne Koong
2026-01-06 18:41 ` [PATCH v7 0/3] io_uring: use release-acquire ordering for IORING_SETUP_R_DISABLED Gabriel Krisman Bertazi
2026-01-08 4:54 ` Hillf Danton [this message]
2026-01-12 18:34 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108045414.2028-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
--cc=joannelkoong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox