From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CA1030B536; Thu, 8 Jan 2026 07:36:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767857812; cv=none; b=RakFHz7IVLOY8XVgffbSmT+8pWx2CpMCHF5jWk9Z5t4C3CzCAlocEK0XjovgjWwcTcsfYPY5NNYKfnErCjs7tL+NpHIcQOseo7f25nJBjtqnKWfNswXdMxYbOAsDiKD9zMV0D8vQK0e22clzzIWsFe+dNZiB7elkEHiYVpiAyMw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767857812; c=relaxed/simple; bh=VJR7OANqAnNeKsJcpMXd5sA1W1qzF/DrbRQlYMiYeY8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rtqDJvm09wAo1LxH1fpe8YHXr1rKVOoK7XghOS735ICRC6Gw7iN2TCPr7PaS9BfefLfoDuPdXYZFWozvQTXHl7wD5TcQZ8wLFocB36xFiI2zBKOObXSYNiDFvrU92i1u1Mb6PVYhFECKTEQDwlZHk9yFA20b/dTbBBjX/l4s9LQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=fHW1fzwc; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="fHW1fzwc" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=nND/UTx2fHPWcfLy6K3U1k4zO8irk7L/OKSvicadqNs=; b=fHW1fzwcMG6P7inaFp/YFw4DXG rF83IKcjKwWWX55wXjqZDZnZEc0Pygeqow8+4Z3OZUJurC225qrnyuPKzMBayjzhMlrmqj58c0gaH t52v8S95+U2FSBySsWfHlQnlvQExx0kOFtehHQWYKUEYEkBZp5ucCRmfRyNDYPQdhKW+mkp5G5eB9 xbm7h97gM7v5aD0+NySI2+APlYh68d0hQr2Q8toFH8lvx/i0MB4KOcrbI1McWi4m8T819G0UFvFmy dNWcXkoCnbqegzX+H60NINnF0erQTNb9vO2CHkiIWNMSRcODELQstxO2ueJPIcQ2c0QPvaaGjRE8m sEovErBA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.99 #2 (Red Hat Linux)) id 1vdkaq-00000001mez-08VD; Thu, 08 Jan 2026 07:38:04 +0000 From: Al Viro To: linux-fsdevel@vger.kernel.org Cc: torvalds@linux-foundation.org, brauner@kernel.org, jack@suse.cz, mjguzik@gmail.com, paul@paul-moore.com, axboe@kernel.dk, audit@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 03/59] do_fchownat(): import pathname only once Date: Thu, 8 Jan 2026 07:37:07 +0000 Message-ID: <20260108073803.425343-4-viro@zeniv.linux.org.uk> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260108073803.425343-1-viro@zeniv.linux.org.uk> References: <20260108073803.425343-1-viro@zeniv.linux.org.uk> Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Al Viro Convert the user_path_at() call inside a retry loop into getname_flags() + filename_lookup() + putname() and leave only filename_lookup() inside the loop. Since we have the default logics for use of LOOKUP_EMPTY (passed iff AT_EMPTY_PATH is present in flags), just use getname_uflags() and don't bother with setting LOOKUP_EMPTY in lookup_flags - getname_uflags() will pass the right thing to getname_flags() and filename_lookup() doesn't care about LOOKUP_EMPTY at all. The things could be further simplified by use of cleanup.h stuff, but let's not clutter the patch with that. Signed-off-by: Al Viro --- fs/open.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/fs/open.c b/fs/open.c index 82bfa06dbfa5..a2d775bec8c1 100644 --- a/fs/open.c +++ b/fs/open.c @@ -801,17 +801,17 @@ int do_fchownat(int dfd, const char __user *filename, uid_t user, gid_t group, int flag) { struct path path; - int error = -EINVAL; + int error; int lookup_flags; + struct filename *name; if ((flag & ~(AT_SYMLINK_NOFOLLOW | AT_EMPTY_PATH)) != 0) - goto out; + return -EINVAL; lookup_flags = (flag & AT_SYMLINK_NOFOLLOW) ? 0 : LOOKUP_FOLLOW; - if (flag & AT_EMPTY_PATH) - lookup_flags |= LOOKUP_EMPTY; + name = getname_uflags(filename, flag); retry: - error = user_path_at(dfd, filename, lookup_flags, &path); + error = filename_lookup(dfd, name, lookup_flags, &path, NULL); if (error) goto out; error = mnt_want_write(path.mnt); @@ -826,6 +826,7 @@ int do_fchownat(int dfd, const char __user *filename, uid_t user, gid_t group, goto retry; } out: + putname(name); return error; } -- 2.47.3