public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Joanne Koong <joannelkoong@gmail.com>
To: axboe@kernel.dk, miklos@szeredi.hu
Cc: bschubert@ddn.com, csander@purestorage.com, krisman@suse.de,
	io-uring@vger.kernel.org, asml.silence@gmail.com,
	xiaobing.li@samsung.com, safinaskar@gmail.com,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH v4 08/25] io_uring: add io_uring_fixed_index_get() and io_uring_fixed_index_put()
Date: Fri, 16 Jan 2026 15:30:27 -0800	[thread overview]
Message-ID: <20260116233044.1532965-9-joannelkoong@gmail.com> (raw)
In-Reply-To: <20260116233044.1532965-1-joannelkoong@gmail.com>

Add two new helpers, io_uring_fixed_index_get() and
io_uring_fixed_index_put(). io_uring_fixed_index_get() constructs an
iter for a fixed buffer at a given index and acquires a refcount on
the underlying node. io_uring_fixed_index_put() decrements this
refcount. The caller is responsible for ensuring
io_uring_fixed_index_put() is properly called for releasing the refcount
after it is done using the iter it obtained through
io_uring_fixed_index_get().

The struct io_rsrc_node pointer needs to be returned in
io_uring_fixed_index_get() because the buffer at the index may be
unregistered/replaced in the meantime between this and the
io_uring_fixed_index_put() call. io_uring_fixed_index_put() takes in the
struct io_rsrc_node pointer as an arg.

This is a preparatory patch needed for fuse-over-io-uring support, as
the metadata for fuse requests will be stored at the last index, which
will be different from the buf index set on the sqe.

Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
---
 include/linux/io_uring/cmd.h | 20 ++++++++++++
 io_uring/rsrc.c              | 59 ++++++++++++++++++++++++++++++++++++
 2 files changed, 79 insertions(+)

diff --git a/include/linux/io_uring/cmd.h b/include/linux/io_uring/cmd.h
index a488e945f883..de3f550598cf 100644
--- a/include/linux/io_uring/cmd.h
+++ b/include/linux/io_uring/cmd.h
@@ -44,6 +44,14 @@ int io_uring_cmd_import_fixed_vec(struct io_uring_cmd *ioucmd,
 				  size_t uvec_segs,
 				  int ddir, struct iov_iter *iter,
 				  unsigned issue_flags);
+struct io_rsrc_node *io_uring_fixed_index_get(struct io_uring_cmd *cmd,
+					      int buf_index, unsigned int off,
+					      size_t len, int ddir,
+					      struct iov_iter *iter,
+					      unsigned int issue_flags);
+void io_uring_fixed_index_put(struct io_uring_cmd *cmd,
+			      struct io_rsrc_node *node,
+			      unsigned int issue_flags);
 
 /*
  * Completes the request, i.e. posts an io_uring CQE and deallocates @ioucmd
@@ -108,6 +116,18 @@ static inline int io_uring_cmd_import_fixed_vec(struct io_uring_cmd *ioucmd,
 {
 	return -EOPNOTSUPP;
 }
+static inline struct io_rsrc_node *
+io_uring_fixed_index_get(struct io_uring_cmd *cmd, int buf_index,
+			 unsigned int off, size_t len, int ddir,
+			 struct iov_iter *iter, unsigned int issue_flags)
+{
+	return ERR_PTR(-EOPNOTSUPP);
+}
+static inline void io_uring_fixed_index_put(struct io_uring_cmd *cmd,
+					    struct io_rsrc_node *node,
+					    unsigned int issue_flags)
+{
+}
 static inline void __io_uring_cmd_done(struct io_uring_cmd *cmd, s32 ret,
 		u64 ret2, unsigned issue_flags, bool is_cqe32)
 {
diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c
index 41c89f5c616d..fa41cae5e922 100644
--- a/io_uring/rsrc.c
+++ b/io_uring/rsrc.c
@@ -1152,6 +1152,65 @@ int io_import_reg_buf(struct io_kiocb *req, struct iov_iter *iter,
 	return io_import_fixed(ddir, iter, node->buf, buf_addr, len);
 }
 
+struct io_rsrc_node *io_uring_fixed_index_get(struct io_uring_cmd *cmd,
+					      int buf_index, unsigned int off,
+					      size_t len, int ddir,
+					      struct iov_iter *iter,
+					      unsigned int issue_flags)
+{
+	struct io_ring_ctx *ctx = cmd_to_io_kiocb(cmd)->ctx;
+	struct io_rsrc_node *node;
+	struct io_mapped_ubuf *imu;
+	u64 addr;
+	int err;
+
+	io_ring_submit_lock(ctx, issue_flags);
+
+	node = io_rsrc_node_lookup(&ctx->buf_table, buf_index);
+	if (!node) {
+		io_ring_submit_unlock(ctx, issue_flags);
+		return ERR_PTR(-EINVAL);
+	}
+
+	node->refs++;
+
+	io_ring_submit_unlock(ctx, issue_flags);
+
+	imu = node->buf;
+	if (!imu) {
+		err = -EFAULT;
+		goto error;
+	}
+
+	if (check_add_overflow(imu->ubuf, off, &addr)) {
+		err = -EINVAL;
+		goto error;
+	}
+
+	err = io_import_fixed(ddir, iter, imu, addr, len);
+	if (err)
+		goto error;
+
+	return node;
+
+error:
+	io_uring_fixed_index_put(cmd, node, issue_flags);
+	return ERR_PTR(err);
+}
+EXPORT_SYMBOL_GPL(io_uring_fixed_index_get);
+
+void io_uring_fixed_index_put(struct io_uring_cmd *cmd,
+			      struct io_rsrc_node *node,
+			      unsigned int issue_flags)
+{
+	struct io_ring_ctx *ctx = cmd_to_io_kiocb(cmd)->ctx;
+
+	io_ring_submit_lock(ctx, issue_flags);
+	io_put_rsrc_node(ctx, node);
+	io_ring_submit_unlock(ctx, issue_flags);
+}
+EXPORT_SYMBOL_GPL(io_uring_fixed_index_put);
+
 /* Lock two rings at once. The rings must be different! */
 static void lock_two_rings(struct io_ring_ctx *ctx1, struct io_ring_ctx *ctx2)
 {
-- 
2.47.3


  parent reply	other threads:[~2026-01-16 23:31 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16 23:30 [PATCH v4 00/25] fuse/io-uring: add kernel-managed buffer rings and zero-copy Joanne Koong
2026-01-16 23:30 ` [PATCH v4 01/25] io_uring/kbuf: refactor io_buf_pbuf_register() logic into generic helpers Joanne Koong
2026-01-16 23:30 ` [PATCH v4 02/25] io_uring/kbuf: rename io_unregister_pbuf_ring() to io_unregister_buf_ring() Joanne Koong
2026-01-16 23:30 ` [PATCH v4 03/25] io_uring/kbuf: add support for kernel-managed buffer rings Joanne Koong
2026-01-16 23:30 ` [PATCH v4 04/25] io_uring/kbuf: add mmap " Joanne Koong
2026-01-16 23:30 ` [PATCH v4 05/25] io_uring/kbuf: support kernel-managed buffer rings in buffer selection Joanne Koong
2026-01-16 23:30 ` [PATCH v4 06/25] io_uring/kbuf: add buffer ring pinning/unpinning Joanne Koong
2026-01-16 23:30 ` [PATCH v4 07/25] io_uring/kbuf: add recycling for kernel managed buffer rings Joanne Koong
2026-01-16 23:30 ` Joanne Koong [this message]
2026-01-22 21:02   ` [PATCH v4 08/25] io_uring: add io_uring_fixed_index_get() and io_uring_fixed_index_put() Caleb Sander Mateos
2026-01-27 20:05     ` Joanne Koong
2026-01-16 23:30 ` [PATCH v4 09/25] io_uring/kbuf: add io_uring_is_kmbuf_ring() Joanne Koong
2026-01-16 23:30 ` [PATCH v4 10/25] io_uring/kbuf: export io_ring_buffer_select() Joanne Koong
2026-01-16 23:30 ` [PATCH v4 11/25] io_uring/kbuf: return buffer id in buffer selection Joanne Koong
2026-01-16 23:30 ` [PATCH v4 12/25] io_uring/cmd: set selected buffer index in __io_uring_cmd_done() Joanne Koong
2026-01-16 23:30 ` [PATCH v4 13/25] fuse: refactor io-uring logic for getting next fuse request Joanne Koong
2026-01-16 23:30 ` [PATCH v4 14/25] fuse: refactor io-uring header copying to ring Joanne Koong
2026-01-16 23:30 ` [PATCH v4 15/25] fuse: refactor io-uring header copying from ring Joanne Koong
2026-01-27 23:11   ` Bernd Schubert
2026-01-16 23:30 ` [PATCH v4 16/25] fuse: use enum types for header copying Joanne Koong
2026-01-16 23:30 ` [PATCH v4 17/25] fuse: refactor setting up copy state for payload copying Joanne Koong
2026-01-16 23:30 ` [PATCH v4 18/25] fuse: support buffer copying for kernel addresses Joanne Koong
2026-01-27 23:39   ` Bernd Schubert
2026-01-28  0:23     ` Joanne Koong
2026-01-28 21:14       ` Bernd Schubert
2026-01-29  1:16         ` Joanne Koong
2026-01-16 23:30 ` [PATCH v4 19/25] fuse: add io-uring kernel-managed buffer ring Joanne Koong
2026-01-17  5:28   ` kernel test robot
2026-01-28 21:44   ` Bernd Schubert
2026-01-29  1:15     ` Joanne Koong
2026-01-16 23:30 ` [PATCH v4 20/25] io_uring/rsrc: rename io_buffer_register_bvec()/io_buffer_unregister_bvec() Joanne Koong
2026-01-16 23:30 ` [PATCH v4 21/25] io_uring/rsrc: split io_buffer_register_request() logic Joanne Koong
2026-01-16 23:30 ` [PATCH v4 22/25] io_uring/rsrc: Allow buffer release callback to be optional Joanne Koong
2026-01-16 23:30 ` [PATCH v4 23/25] io_uring/rsrc: add io_buffer_register_bvec() Joanne Koong
2026-01-16 23:30 ` [PATCH v4 24/25] fuse: add zero-copy over io-uring Joanne Koong
2026-01-16 23:30 ` [PATCH v4 25/25] docs: fuse: add io-uring bufring and zero-copy documentation Joanne Koong
2026-01-27 20:12 ` [PATCH v4 00/25] fuse/io-uring: add kernel-managed buffer rings and zero-copy Joanne Koong
2026-01-27 22:44   ` Bernd Schubert
2026-01-27 23:27     ` Joanne Koong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260116233044.1532965-9-joannelkoong@gmail.com \
    --to=joannelkoong@gmail.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=bschubert@ddn.com \
    --cc=csander@purestorage.com \
    --cc=io-uring@vger.kernel.org \
    --cc=krisman@suse.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=safinaskar@gmail.com \
    --cc=xiaobing.li@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox