From: Dylan Yudaken <dyudaken@gmail.com>
To: axboe@kernel.dk, io-uring@vger.kernel.org, asml.silence@gmail.com
Cc: Dylan Yudaken <dyudaken@gmail.com>
Subject: [PATCH] io_uring: remove unneeded io_send_zc accounting
Date: Sun, 15 Feb 2026 23:15:23 +0000 [thread overview]
Message-ID: <20260215231523.308665-1-dyudaken@gmail.com> (raw)
zc->len and zc->buf are not actually used once you get to the retry
stage. The buffer remains in kmsg->msg.msg_iter, which is setup in
io_send_setup.
Note: it still seems needed in io_send due to io_send_select_buffer
needing it (for the len parameter).
Signed-off-by: Dylan Yudaken <dyudaken@gmail.com>
---
Hi,
I'm reasonably sure this is correct - but I think Pavel might want to
double check that I did not miss anything. The tests seem to pass with no
changes.
Thanks,
Dylan
io_uring/net.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/io_uring/net.c b/io_uring/net.c
index a6f3cbb7dfea..8576c6cb2236 100644
--- a/io_uring/net.c
+++ b/io_uring/net.c
@@ -1493,8 +1493,6 @@ int io_send_zc(struct io_kiocb *req, unsigned int issue_flags)
return -EAGAIN;
if (ret > 0 && io_net_retry(sock, kmsg->msg.msg_flags)) {
- zc->len -= ret;
- zc->buf += ret;
zc->done_io += ret;
return -EAGAIN;
}
base-commit: 26a4cfaff82a2dcb810f6bfd5f4842f9b6046c8a
--
2.50.1
next reply other threads:[~2026-02-15 23:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 23:15 Dylan Yudaken [this message]
2026-02-15 23:39 ` [PATCH] io_uring: remove unneeded io_send_zc accounting Pavel Begunkov
2026-02-16 11:43 ` Pavel Begunkov
2026-02-15 23:51 ` Jens Axboe
2026-02-16 15:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260215231523.308665-1-dyudaken@gmail.com \
--to=dyudaken@gmail.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox