From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f98.google.com (mail-qv1-f98.google.com [209.85.219.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC6EE1FC101 for ; Thu, 19 Feb 2026 01:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.98 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771465428; cv=none; b=i9Wvdx6s/YhM8TBLeHe791OIc//ndN/wNDmjnahK+/FNM4i83wl1PH99PenBsOC1eHdtxPQ7+3cd4vlKF8HX1zZnXMzDJ8xRljifJ2VAqzrD7YASHx86MEwNAsXl62ALN9gixGvgzWkmaGpKGGi0hynUXI8V1hRCxFzYlO9Akps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771465428; c=relaxed/simple; bh=EHWMm11e5TVx8NT/hLERqyUnuuxjz5z5bCiInE9uL2M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l+xD7P9nPbHMBnczWyEKya44iztvwBiXkmCqj2WCpiwLIghHcFwHV4AUqQrTDeYjMkSNy7Baxem1oD6MJnk1IcanuzUlVVIJ/RQFMVE0Ihy20JD+2lgh6K2w3RJtDIKl3lvSJ51N44VymBzOoFk4Y/ZSM9kxXCL/T9+1c4Jmgr8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=RAsUNME5; arc=none smtp.client-ip=209.85.219.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="RAsUNME5" Received: by mail-qv1-f98.google.com with SMTP id 6a1803df08f44-895498f3819so553506d6.3 for ; Wed, 18 Feb 2026 17:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1771465425; x=1772070225; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CUz10elldwZxLQFWq4Cian3B5sXmfA0qWI2X4aUf25A=; b=RAsUNME5Lq34d59skzAPAZjc5hZtWTK1Il+RSv0SxoV5jeQkYfmP48rqK7T3RnSkYz HxV/3KPu7TLfQ+4Nu7WfGCy37jteVCF4e1m6l93NmYec+wSX+m5hC8xjeNw25xXihLl4 X9UJJ+ZcXYnGT5k7xDBU9d4Z2BjcAz16uNS6ezD7IZHZ5r8YXWcGl4sCLmXY6SaSEkU3 L4g8nRUeBY6ZI2JO9rfgtDfQRi21cxSqBd+RHXy6t57xo6Ayhc10+PK9PM3IqLFVdaYU dTWdACa8hFKifcEWjX86M7AB4kIM/Q/Tnb278BZlk0pdN5Z8Q5uG8P05H5KABdzl+a50 m1pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771465425; x=1772070225; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CUz10elldwZxLQFWq4Cian3B5sXmfA0qWI2X4aUf25A=; b=A+bDSaXpLAjnBMlxlaiKME9nB2ROwT8azBa+Yu6KswWDzZC7zt3stmjuZWHZfhcAwG iZ0B5fJah60VuHQxQOp0oOGTCeD/fxdPRmEOEb4fBmYNoAftRoo2vln45XS1qG+XsjYx PAQ+mANVsD5EEIs5EaBnoJVg7dhWDP8abAsXzcWhZdii29l0KRLDBkRyy4w3wylYGLlO xX2zSG2lJg90SGmly2CMXjaQxinJa7l3v6LkhpEAnnVKVIT5/4JwxQOfcB20Hl+BSDpb ElASZSDXlXnQ+kadW1YBGvuySplig8QawUzg6WaChvFa0ixInQQSoquj3hmV4l0QM/5n +caw== X-Gm-Message-State: AOJu0Yy21AaGoDDYwA0ZBJ8GL8IXPSnJFF7FiZmgSvOhzlfDO1FkdYhN 9Z0pkHcagq3f0vvySDc5PIsJmGelYzTF4MP/CRkv8V+kJyPZs9h2WfgmN7GX0RAO9m7iQkCNDZj 1ItqzOVi41Q5k6/cwfb3DBYqtI0Gan1kBC/1Y X-Gm-Gg: AZuq6aIOtbXG2QPnlqQB3OBYbvEBkOd9Te7SXAJCxt0n97fO9woy4bheIVPBb9BjA6T J+kE4CYSvrQQPo+H4rUJbBtA1UB8mmUuWDo1RsM9JPKj9YSh5SMtuAF4SHBfk7BBHAcQ2ZoabFa doz36nLx2H2Keks/qA8cEHnVX7NhBCoMUbXYK64oZHRQBYwCdzij0So3JYoHNxaJUtgX2IxC3XM vhA+2WC72aC9+naHetTpOQP2oQAIvII/EdQL0/Usd/1fIpzSouO34oC8H/aJvyu+Knz/0fK/uzT rRB6v9OqoNAEKAZnfiAok1LNifR3a1bw6wVjL2fDNOAxLEvDfs5q5xlvsYFB0priUcdb88NPyRY lb0TKLCllBY602djM9aNfcfQm3svv4zjiCQpUy9Hphkfqqjg4koNptg== X-Received: by 2002:a05:6214:4f05:b0:897:12e:8e8b with SMTP id 6a1803df08f44-897347e287emr204249686d6.7.1771465424836; Wed, 18 Feb 2026 17:43:44 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([208.88.159.128]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-8971cd37a80sm27810226d6.19.2026.02.18.17.43.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 17:43:44 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.29.101]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id AEB22342224; Wed, 18 Feb 2026 18:43:43 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id A9B98E41D2F; Wed, 18 Feb 2026 18:43:43 -0700 (MST) From: Caleb Sander Mateos To: Jens Axboe , Christoph Hellwig , Keith Busch , Sagi Grimberg Cc: io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Caleb Sander Mateos Subject: [PATCH v2 2/4] io_uring: remove iopoll_queue from struct io_issue_def Date: Wed, 18 Feb 2026 18:43:33 -0700 Message-ID: <20260219014335.9061-3-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260219014335.9061-1-csander@purestorage.com> References: <20260219014335.9061-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The opcode iopoll_queue flag is now redundant with REQ_F_IOPOLL. Only io_{read,write}{,_fixed}() and io_uring_cmd() set the REQ_F_IOPOLL flag, and the opcodes with these ->issue() implementations are precisely the ones that set iopoll_queue. So don't bother checking the iopoll_queue flag in io_issue_sqe(). Remove the unused flag from struct io_issue_def. Signed-off-by: Caleb Sander Mateos --- io_uring/io_uring.c | 3 +-- io_uring/opdef.c | 10 ---------- io_uring/opdef.h | 2 -- 3 files changed, 1 insertion(+), 14 deletions(-) diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index 43059f6e10e0..2be46e11e1a7 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -1415,12 +1415,11 @@ static int io_issue_sqe(struct io_kiocb *req, unsigned int issue_flags) } if (ret == IOU_ISSUE_SKIP_COMPLETE) { ret = 0; - /* If the op doesn't have a file, we're not polling for it */ - if ((req->flags & REQ_F_IOPOLL) && def->iopoll_queue) + if (req->flags & REQ_F_IOPOLL) io_iopoll_req_issued(req, issue_flags); } return ret; } diff --git a/io_uring/opdef.c b/io_uring/opdef.c index 91a23baf415e..4b3fb19b0cde 100644 --- a/io_uring/opdef.c +++ b/io_uring/opdef.c @@ -65,11 +65,10 @@ const struct io_issue_def io_issue_defs[] = { .buffer_select = 1, .plug = 1, .audit_skip = 1, .ioprio = 1, .iopoll = 1, - .iopoll_queue = 1, .vectored = 1, .async_size = sizeof(struct io_async_rw), .prep = io_prep_readv, .issue = io_read, }, @@ -80,11 +79,10 @@ const struct io_issue_def io_issue_defs[] = { .pollout = 1, .plug = 1, .audit_skip = 1, .ioprio = 1, .iopoll = 1, - .iopoll_queue = 1, .vectored = 1, .async_size = sizeof(struct io_async_rw), .prep = io_prep_writev, .issue = io_write, }, @@ -100,11 +98,10 @@ const struct io_issue_def io_issue_defs[] = { .pollin = 1, .plug = 1, .audit_skip = 1, .ioprio = 1, .iopoll = 1, - .iopoll_queue = 1, .async_size = sizeof(struct io_async_rw), .prep = io_prep_read_fixed, .issue = io_read_fixed, }, [IORING_OP_WRITE_FIXED] = { @@ -114,11 +111,10 @@ const struct io_issue_def io_issue_defs[] = { .pollout = 1, .plug = 1, .audit_skip = 1, .ioprio = 1, .iopoll = 1, - .iopoll_queue = 1, .async_size = sizeof(struct io_async_rw), .prep = io_prep_write_fixed, .issue = io_write_fixed, }, [IORING_OP_POLL_ADD] = { @@ -248,11 +244,10 @@ const struct io_issue_def io_issue_defs[] = { .buffer_select = 1, .plug = 1, .audit_skip = 1, .ioprio = 1, .iopoll = 1, - .iopoll_queue = 1, .async_size = sizeof(struct io_async_rw), .prep = io_prep_read, .issue = io_read, }, [IORING_OP_WRITE] = { @@ -262,11 +257,10 @@ const struct io_issue_def io_issue_defs[] = { .pollout = 1, .plug = 1, .audit_skip = 1, .ioprio = 1, .iopoll = 1, - .iopoll_queue = 1, .async_size = sizeof(struct io_async_rw), .prep = io_prep_write, .issue = io_write, }, [IORING_OP_FADVISE] = { @@ -421,11 +415,10 @@ const struct io_issue_def io_issue_defs[] = { [IORING_OP_URING_CMD] = { .buffer_select = 1, .needs_file = 1, .plug = 1, .iopoll = 1, - .iopoll_queue = 1, .async_size = sizeof(struct io_async_cmd), .prep = io_uring_cmd_prep, .issue = io_uring_cmd, }, [IORING_OP_SEND_ZC] = { @@ -554,11 +547,10 @@ const struct io_issue_def io_issue_defs[] = { .pollin = 1, .plug = 1, .audit_skip = 1, .ioprio = 1, .iopoll = 1, - .iopoll_queue = 1, .vectored = 1, .async_size = sizeof(struct io_async_rw), .prep = io_prep_readv_fixed, .issue = io_read, }, @@ -569,11 +561,10 @@ const struct io_issue_def io_issue_defs[] = { .pollout = 1, .plug = 1, .audit_skip = 1, .ioprio = 1, .iopoll = 1, - .iopoll_queue = 1, .vectored = 1, .async_size = sizeof(struct io_async_rw), .prep = io_prep_writev_fixed, .issue = io_write, }, @@ -591,11 +582,10 @@ const struct io_issue_def io_issue_defs[] = { [IORING_OP_URING_CMD128] = { .buffer_select = 1, .needs_file = 1, .plug = 1, .iopoll = 1, - .iopoll_queue = 1, .is_128 = 1, .async_size = sizeof(struct io_async_cmd), .prep = io_uring_cmd_prep, .issue = io_uring_cmd, }, diff --git a/io_uring/opdef.h b/io_uring/opdef.h index faf3955dce8b..667f981e63b0 100644 --- a/io_uring/opdef.h +++ b/io_uring/opdef.h @@ -23,12 +23,10 @@ struct io_issue_def { unsigned pollin : 1; unsigned pollout : 1; unsigned poll_exclusive : 1; /* skip auditing */ unsigned audit_skip : 1; - /* have to be put into the iopoll list */ - unsigned iopoll_queue : 1; /* vectored opcode, set if 1) vectored, and 2) handler needs to know */ unsigned vectored : 1; /* set to 1 if this opcode uses 128b sqes in a mixed sq */ unsigned is_128 : 1; -- 2.45.2