From: Caleb Sander Mateos <csander@purestorage.com>
To: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>
Cc: io-uring@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org, Anuj gupta <anuj1072538@gmail.com>,
Kanchan Joshi <joshi.k@samsung.com>,
Caleb Sander Mateos <csander@purestorage.com>
Subject: [PATCH v3 4/4] nvme: remove nvme_dev_uring_cmd() IO_URING_F_IOPOLL check
Date: Thu, 19 Feb 2026 10:22:27 -0700 [thread overview]
Message-ID: <20260219172228.429479-5-csander@purestorage.com> (raw)
In-Reply-To: <20260219172228.429479-1-csander@purestorage.com>
nvme_dev_uring_cmd() is part of struct file_operations nvme_dev_fops,
which doesn't implement ->uring_cmd_iopoll(). So it won't be called with
issue_flags that include IO_URING_F_IOPOLL. Drop the unnecessary
IO_URING_F_IOPOLL check in nvme_dev_uring_cmd().
Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
---
drivers/nvme/host/ioctl.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/nvme/host/ioctl.c b/drivers/nvme/host/ioctl.c
index 8844bbd39515..9597a87cf05d 100644
--- a/drivers/nvme/host/ioctl.c
+++ b/drivers/nvme/host/ioctl.c
@@ -784,14 +784,10 @@ int nvme_ns_head_chr_uring_cmd(struct io_uring_cmd *ioucmd,
int nvme_dev_uring_cmd(struct io_uring_cmd *ioucmd, unsigned int issue_flags)
{
struct nvme_ctrl *ctrl = ioucmd->file->private_data;
int ret;
- /* IOPOLL not supported yet */
- if (issue_flags & IO_URING_F_IOPOLL)
- return -EOPNOTSUPP;
-
ret = nvme_uring_cmd_checks(issue_flags);
if (ret)
return ret;
switch (ioucmd->cmd_op) {
--
2.45.2
next prev parent reply other threads:[~2026-02-19 17:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260219172309epcas5p2bd985f806bafcd2b919963ef689dc9a1@epcas5p2.samsung.com>
2026-02-19 17:22 ` [PATCH v3 0/4] io_uring/uring_cmd: allow non-iopoll cmds with IORING_SETUP_IOPOLL Caleb Sander Mateos
2026-02-19 17:22 ` [PATCH v3 1/4] io_uring: add REQ_F_IOPOLL Caleb Sander Mateos
2026-02-19 17:22 ` [PATCH v3 2/4] io_uring: remove iopoll_queue from struct io_issue_def Caleb Sander Mateos
2026-02-19 17:22 ` [PATCH v3 3/4] io_uring/uring_cmd: allow non-iopoll cmds with IORING_SETUP_IOPOLL Caleb Sander Mateos
2026-02-19 17:22 ` Caleb Sander Mateos [this message]
2026-02-20 13:21 ` [PATCH v3 0/4] " Kanchan Joshi
2026-02-20 14:00 ` Anuj gupta
2026-02-20 14:25 ` Ming Lei
2026-02-20 15:55 ` Caleb Sander Mateos
2026-02-20 16:11 ` Ming Lei
2026-02-20 16:22 ` Caleb Sander Mateos
2026-02-20 16:31 ` Ming Lei
2026-02-20 17:47 ` Caleb Sander Mateos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260219172228.429479-5-csander@purestorage.com \
--to=csander@purestorage.com \
--cc=anuj1072538@gmail.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=io-uring@vger.kernel.org \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox